[PATCH 01/13] arm64: dts: ti: k3-am625-beagleplay: Enable "cpsw3g" in the board file

Siddharth Vadapalli posted 13 patches 6 months, 3 weeks ago
There is a newer version of this series
[PATCH 01/13] arm64: dts: ti: k3-am625-beagleplay: Enable "cpsw3g" in the board file
Posted by Siddharth Vadapalli 6 months, 3 weeks ago
In preparation for disabling "cpsw3g" device-tree node in the SoC file,
namely "k3-am62-main.dtsi", enable it in the board file. The motivation
for this change is that of following the existing convention of disabling
nodes in the SoC file and only enabling the required ones in the board
file.

Signed-off-by: Siddharth Vadapalli <s-vadapalli@ti.com>
---
 arch/arm64/boot/dts/ti/k3-am625-beagleplay.dts | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm64/boot/dts/ti/k3-am625-beagleplay.dts b/arch/arm64/boot/dts/ti/k3-am625-beagleplay.dts
index 72b09f9c69d8..999f5baaba1a 100644
--- a/arch/arm64/boot/dts/ti/k3-am625-beagleplay.dts
+++ b/arch/arm64/boot/dts/ti/k3-am625-beagleplay.dts
@@ -585,6 +585,7 @@ &usb1 {
 };
 
 &cpsw3g {
+	status = "okay";
 	pinctrl-names = "default";
 	pinctrl-0 = <&rgmii1_pins_default>, <&spe_pins_default>,
 		    <&gbe_pmx_obsclk>;
-- 
2.34.1
Re: [PATCH 01/13] arm64: dts: ti: k3-am625-beagleplay: Enable "cpsw3g" in the board file
Posted by Krzysztof Kozlowski 6 months, 3 weeks ago
On 29/05/2025 15:34, Siddharth Vadapalli wrote:
> In preparation for disabling "cpsw3g" device-tree node in the SoC file,
> namely "k3-am62-main.dtsi", enable it in the board file. The motivation
> for this change is that of following the existing convention of disabling
> nodes in the SoC file and only enabling the required ones in the board
> file.


That's not separate commit. You disable in DTSI and enable in DTS in the
same one, to avoid any duplicated statuses like in this case (even if
one is default).



Best regards,
Krzysztof
Re: [PATCH 01/13] arm64: dts: ti: k3-am625-beagleplay: Enable "cpsw3g" in the board file
Posted by Siddharth Vadapalli 6 months, 2 weeks ago
On Thu, May 29, 2025 at 03:37:22PM +0200, Krzysztof Kozlowski wrote:
> On 29/05/2025 15:34, Siddharth Vadapalli wrote:
> > In preparation for disabling "cpsw3g" device-tree node in the SoC file,
> > namely "k3-am62-main.dtsi", enable it in the board file. The motivation
> > for this change is that of following the existing convention of disabling
> > nodes in the SoC file and only enabling the required ones in the board
> > file.
> 
> 
> That's not separate commit. You disable in DTSI and enable in DTS in the
> same one, to avoid any duplicated statuses like in this case (even if
> one is default).

I will squash the commits. Thank you for reviewing the patch.

Regards,
Siddharth.