pmdomain: renesas: rcar: Use str_on_off() helper in rcar_sysc_power() and rcar_gen4_sysc_power()

Posted by shao.mingyin@zte.com.cn 6 months, 3 weeks ago

From: Shao Mingyin <shao.mingyin@zte.com.cn>

Remove hard-coded strings by using the str_on_off() helper function.

Signed-off-by: Shao Mingyin <shao.mingyin@zte.com.cn>
---
 drivers/pmdomain/renesas/rcar-gen4-sysc.c | 3 ++-
 drivers/pmdomain/renesas/rcar-sysc.c      | 3 ++-
 2 files changed, 4 insertions(+), 2 deletions(-)

diff --git a/drivers/pmdomain/renesas/rcar-gen4-sysc.c b/drivers/pmdomain/renesas/rcar-gen4-sysc.c
index e001b5c25bed..c8aa7538e95f 100644
--- a/drivers/pmdomain/renesas/rcar-gen4-sysc.c
+++ b/drivers/pmdomain/renesas/rcar-gen4-sysc.c
@@ -18,6 +18,7 @@
 #include <linux/slab.h>
 #include <linux/spinlock.h>
 #include <linux/types.h>
+#include <linux/string_choices.h>

 #include "rcar-gen4-sysc.h"

@@ -171,7 +172,7 @@ static int rcar_gen4_sysc_power(u8 pdr, bool on)
  out:
 	spin_unlock_irqrestore(&rcar_gen4_sysc_lock, flags);

-	pr_debug("sysc power %s domain %d: %08x -> %d\n", on ? "on" : "off",
+	pr_debug("sysc power %s domain %d: %08x -> %d\n", str_on_off(on),
 		 pdr, ioread32(rcar_gen4_sysc_base + SYSCISCR(reg_idx)), ret);
 	return ret;
 }
diff --git a/drivers/pmdomain/renesas/rcar-sysc.c b/drivers/pmdomain/renesas/rcar-sysc.c
index 047495f54e8a..dae01ca0ef6a 100644
--- a/drivers/pmdomain/renesas/rcar-sysc.c
+++ b/drivers/pmdomain/renesas/rcar-sysc.c
@@ -17,6 +17,7 @@
 #include <linux/io.h>
 #include <linux/iopoll.h>
 #include <linux/soc/renesas/rcar-sysc.h>
+#include <linux/string_choices.h>

 #include "rcar-sysc.h"

@@ -162,7 +163,7 @@ static int rcar_sysc_power(const struct rcar_sysc_pd *pd, bool on)

 	spin_unlock_irqrestore(&rcar_sysc_lock, flags);

-	pr_debug("sysc power %s domain %d: %08x -> %d\n", on ? "on" : "off",
+	pr_debug("sysc power %s domain %d: %08x -> %d\n", str_on_off(on),
 		 pd->isr_bit, ioread32(rcar_sysc_base + SYSCISR), ret);
 	return ret;
 }
-- 
2.25.1

Re: pmdomain: renesas: rcar: Use str_on_off() helper in rcar_sysc_power() and rcar_gen4_sysc_power()

Posted by Krzysztof Kozlowski 6 months, 3 weeks ago

On 29/05/2025 04:13, shao.mingyin@zte.com.cn wrote:
> From: Shao Mingyin <shao.mingyin@zte.com.cn>
> 
> Remove hard-coded strings by using the str_on_off() helper function.
> 
> Signed-off-by: Shao Mingyin <shao.mingyin@zte.com.cn>
> ---
>  drivers/pmdomain/renesas/rcar-gen4-sysc.c | 3 ++-
>  drivers/pmdomain/renesas/rcar-sysc.c      | 3 ++-

Stop sending such trivial patches one driver per patch, but entire
subsystem in one patch. That's a lot of churn, considering this was
rejected:


https://lore.kernel.org/all/20250114203547.1013010-1-krzysztof.kozlowski@linaro.org/


Best regards,
Krzysztof

Re: pmdomain: renesas: rcar: Use str_on_off() helper in rcar_sysc_power() and rcar_gen4_sysc_power()

Posted by Geert Uytterhoeven 6 months, 2 weeks ago

Hi Krzysztof,

On Thu, 29 May 2025 at 08:41, Krzysztof Kozlowski <krzk@kernel.org> wrote:
> On 29/05/2025 04:13, shao.mingyin@zte.com.cn wrote:
> > From: Shao Mingyin <shao.mingyin@zte.com.cn>
> >
> > Remove hard-coded strings by using the str_on_off() helper function.
> >
> > Signed-off-by: Shao Mingyin <shao.mingyin@zte.com.cn>
> > ---
> >  drivers/pmdomain/renesas/rcar-gen4-sysc.c | 3 ++-
> >  drivers/pmdomain/renesas/rcar-sysc.c      | 3 ++-
>
> Stop sending such trivial patches one driver per patch, but entire
> subsystem in one patch. That's a lot of churn, considering this was
> rejected:

Was it? I only see my Rb, and a review comment asking for more...

> https://lore.kernel.org/all/20250114203547.1013010-1-krzysztof.kozlowski@linaro.org/

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Re: pmdomain: renesas: rcar: Use str_on_off() helper in rcar_sysc_power() and rcar_gen4_sysc_power()

Posted by Krzysztof Kozlowski 6 months, 2 weeks ago

On 30/05/2025 10:07, Geert Uytterhoeven wrote:
> Hi Krzysztof,
> 
> On Thu, 29 May 2025 at 08:41, Krzysztof Kozlowski <krzk@kernel.org> wrote:
>> On 29/05/2025 04:13, shao.mingyin@zte.com.cn wrote:
>>> From: Shao Mingyin <shao.mingyin@zte.com.cn>
>>>
>>> Remove hard-coded strings by using the str_on_off() helper function.
>>>
>>> Signed-off-by: Shao Mingyin <shao.mingyin@zte.com.cn>
>>> ---
>>>  drivers/pmdomain/renesas/rcar-gen4-sysc.c | 3 ++-
>>>  drivers/pmdomain/renesas/rcar-sysc.c      | 3 ++-
>>
>> Stop sending such trivial patches one driver per patch, but entire
>> subsystem in one patch. That's a lot of churn, considering this was
>> rejected:
> 
> Was it? I only see my Rb, and a review comment asking for more...
> 
>> https://lore.kernel.org/all/20250114203547.1013010-1-krzysztof.kozlowski@linaro.org/
Indeed this one was not, but my other patchsets were - several
subsystems clearly expressed that this is just a churn. So if doing
this, because you do not consider it a churn, do it all at once to, not
line by line.

Best regards,
Krzysztof