wifi: mac80211: Add limit to ignore NSS change warning

[PATCH] wifi: mac80211: Add limit to ignore NSS change warning

Posted by Paul Menzel 6 months, 3 weeks ago

Currently, Linux warns as below:

    Ignoring NSS change in VHT Operating Mode Notification from cc:d4:2e:bb:59:f4 with invalid nss 4

For the ignorant reader, it’s unclear, why it’s invalid. Checking the
code, valid means it’s smaller or equal to `link_sta->op_mode_nss,` so
add that to the warning.

Signed-off-by: Paul Menzel <pmenzel@molgen.mpg.de>
---
 net/mac80211/vht.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/net/mac80211/vht.c b/net/mac80211/vht.c
index c5c5d16ed6c8..9f7938ac4031 100644
--- a/net/mac80211/vht.c
+++ b/net/mac80211/vht.c
@@ -672,8 +672,8 @@ u32 __ieee80211_vht_handle_opmode(struct ieee80211_sub_if_data *sdata,
 				sta_opmode.changed |= STA_OPMODE_N_SS_CHANGED;
 			}
 		} else {
-			pr_warn_ratelimited("Ignoring NSS change in VHT Operating Mode Notification from %pM with invalid nss %d",
-					    link_sta->pub->addr, nss);
+			pr_warn_ratelimited("Ignoring NSS change in VHT Operating Mode Notification from %pM with invalid nss %d > %d",
+					    link_sta->pub->addr, nss, link_sta->op_mode_nss);
 		}
 	}
 
-- 
2.49.0

Re: [PATCH] wifi: mac80211: Add limit to ignore NSS change warning

Posted by Johannes Berg 5 months, 3 weeks ago

On Thu, 2025-05-29 at 09:09 +0200, Paul Menzel wrote:
> Currently, Linux warns as below:
> 
>     Ignoring NSS change in VHT Operating Mode Notification from cc:d4:2e:bb:59:f4 with invalid nss 4
> 

I think we should make it a debug message as well, that's a really
pointless thing to bother users with.

Want to make that change too?

johannes