arch/arm/boot/dts/aspeed/aspeed-bmc-opp-lanyang.dts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
Fix an obvious spelling error in the dts file for Lanyang BMC.
This was reported by bugzilla a few years ago but never got fixed.
Reported by: Jens Schleusener <Jens.Schleusener@fossies.org>
Closes: https://bugzilla.kernel.org/show_bug.cgi?id=205891
Signed-off-by: Ankit Chauhan <ankitchauhan2065@gmail.com>
---
arch/arm/boot/dts/aspeed/aspeed-bmc-opp-lanyang.dts | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm/boot/dts/aspeed/aspeed-bmc-opp-lanyang.dts b/arch/arm/boot/dts/aspeed/aspeed-bmc-opp-lanyang.dts
index 370738572a55b2498fff31a4aabf336cc41e1eac..8b9d382241ff11329fcbaca5a469aebb11fd3460 100644
--- a/arch/arm/boot/dts/aspeed/aspeed-bmc-opp-lanyang.dts
+++ b/arch/arm/boot/dts/aspeed/aspeed-bmc-opp-lanyang.dts
@@ -52,12 +52,12 @@ hdd_fault {
gpios = <&gpio ASPEED_GPIO(B, 3) GPIO_ACTIVE_HIGH>;
};
bmc_err {
- lable = "BMC_fault";
+ label = "BMC_fault";
gpios = <&gpio ASPEED_GPIO(H, 6) GPIO_ACTIVE_HIGH>;
};
sys_err {
- lable = "Sys_fault";
+ label = "Sys_fault";
gpios = <&gpio ASPEED_GPIO(H, 7) GPIO_ACTIVE_HIGH>;
};
};
---
base-commit: a5806cd506af5a7c19bcd596e4708b5c464bfd21
change-id: 20250529-lanyang-lable-fix-0e36bf4c4fd9
Best regards,
--
Ankit Chauhan <ankitchauhan2065@gmail.com>
Hi Ankit, thanks for the fix. Regarding the subject, can you please use the prefix 'ARM: dts: aspeed:'? From there, I'd prefer something like: ARM: dts: aspeed: lanyang: Fix 'lable' typo in LED nodes On Thu, 2025-05-29 at 17:09 +0530, Ankit Chauhan wrote: > Fix an obvious spelling error in the dts file for Lanyang BMC. > This was reported by bugzilla a few years ago but never got fixed. > > Reported by: Jens Schleusener <Jens.Schleusener@fossies.org> Please make sure these tags reflect convention: https://docs.kernel.org/process/submitting-patches.html#using-reported-by-tested-by-reviewed-by-suggested-by-and-fixes Rather than spaces, they use `-` to separate words, so: Reported-by: ... > Closes: https://bugzilla.kernel.org/show_bug.cgi?id=205891 > > Signed-off-by: Ankit Chauhan <ankitchauhan2065@gmail.com> Finally, all the tags should go together in the 'trailer' (final paragraph). There should not be an empty line between the `Closes:` tag and your `Signed-off-by:` tag above. Cheers, Andrew
On Thu, Jun 12, 2025 at 03:01:58PM +0930, Andrew Jeffery wrote: > Hi Ankit, thanks for the fix. > > Regarding the subject, can you please use the prefix 'ARM: dts: > aspeed:'? From there, I'd prefer something like: > > ARM: dts: aspeed: lanyang: Fix 'lable' typo in LED nodes > > On Thu, 2025-05-29 at 17:09 +0530, Ankit Chauhan wrote: > > Fix an obvious spelling error in the dts file for Lanyang BMC. > > This was reported by bugzilla a few years ago but never got fixed. > > > > Reported by: Jens Schleusener <Jens.Schleusener@fossies.org> > > Please make sure these tags reflect convention: > > https://docs.kernel.org/process/submitting-patches.html#using-reported-by-tested-by-reviewed-by-suggested-by-and-fixes > > Rather than spaces, they use `-` to separate words, so: > > Reported-by: ... > > > Closes: https://bugzilla.kernel.org/show_bug.cgi?id=205891 > > > > Signed-off-by: Ankit Chauhan <ankitchauhan2065@gmail.com> > > Finally, all the tags should go together in the 'trailer' (final > paragraph). There should not be an empty line between the `Closes:` tag > and your `Signed-off-by:` tag above. > Hi Andrew, Thanks for the feedback. I will make all the necessary changes and send a v2 PATCH. Kind regards, Ankit Chauhan
© 2016 - 2025 Red Hat, Inc.