Add device tree binding for the Radxa CM5 IO board.
This board is based on the rk3588s.
Signed-off-by: Joseph Kogut <joseph.kogut@gmail.com>
---
Documentation/devicetree/bindings/arm/rockchip.yaml | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/Documentation/devicetree/bindings/arm/rockchip.yaml b/Documentation/devicetree/bindings/arm/rockchip.yaml
index 650fb833d96e..64b0a0dfcf12 100644
--- a/Documentation/devicetree/bindings/arm/rockchip.yaml
+++ b/Documentation/devicetree/bindings/arm/rockchip.yaml
@@ -840,6 +840,13 @@ properties:
- const: radxa,cm3
- const: rockchip,rk3566
+ - description: Radxa Compute Module 5 (CM5)
+ items:
+ - enum:
+ - radxa,cm5-io
+ - const: radxa,cm5
+ - const: rockchip,rk3588s
+
- description: Radxa CM3 Industrial
items:
- enum:
--
2.49.0On Wed, May 28, 2025 at 03:18:21PM GMT, Joseph Kogut wrote: > Add device tree binding for the Radxa CM5 IO board. > > This board is based on the rk3588s. Do not attach (thread) your patchsets to some other threads (unrelated or older versions). This buries them deep in the mailbox and might interfere with applying entire sets. Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> <form letter> This is an automated instruction, just in case, because many review tags are being ignored. If you know the process, just skip it entirely (please do not feel offended by me posting it here - no bad intentions intended, no patronizing, I just want to avoid wasted efforts). If you do not know the process, here is a short explanation: Please add Acked-by/Reviewed-by/Tested-by tags when posting new versions of patchset, under or above your Signed-off-by tag, unless patch changed significantly (e.g. new properties added to the DT bindings). Tag is "received", when provided in a message replied to you on the mailing list. Tools like b4 can help here (). However, there's no need to repost patches *only* to add the tags. The upstream maintainer will do that for tags received on the version they apply. https://elixir.bootlin.com/linux/v6.15/source/Documentation/process/submitting-patches.rst#L591 </form letter> Best regards, Krzysztof
Hi Krzysztof, https://patchwork.kernel.org/project/linux-rockchip/patch/20250528221823.2974653-2-joseph.kogut@gmail.com/ On 5/29/25 18:19, Krzysztof Kozlowski wrote: > On Wed, May 28, 2025 at 03:18:21PM GMT, Joseph Kogut wrote: >> Add device tree binding for the Radxa CM5 IO board. >> >> This board is based on the rk3588s. > > Do not attach (thread) your patchsets to some other threads (unrelated > or older versions). This buries them deep in the mailbox and might > interfere with applying entire sets. > > > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Please explain the sorting rule used for this file. You must have known the sorting rule; otherwise, how can you be sure this patch is correct? Best regards, -- FUKAUMI Naoki Radxa Computer (Shenzhen) Co., Ltd.
On 28/10/2025 10:33, FUKAUMI Naoki wrote: > Hi Krzysztof, > > https://patchwork.kernel.org/project/linux-rockchip/patch/20250528221823.2974653-2-joseph.kogut@gmail.com/ > > On 5/29/25 18:19, Krzysztof Kozlowski wrote: >> On Wed, May 28, 2025 at 03:18:21PM GMT, Joseph Kogut wrote: >>> Add device tree binding for the Radxa CM5 IO board. >>> >>> This board is based on the rk3588s. >> >> Do not attach (thread) your patchsets to some other threads (unrelated >> or older versions). This buries them deep in the mailbox and might >> interfere with applying entire sets. >> >> >> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > Please explain the sorting rule used for this file. You must have known > the sorting rule; otherwise, how can you be sure this patch is correct? Huh? I don't have a clue about sorting rule but if you mock my review let's make it different: NAK Best regards, Krzysztof
On 28/10/2025 10:37, Krzysztof Kozlowski wrote: > On 28/10/2025 10:33, FUKAUMI Naoki wrote: >> Hi Krzysztof, >> >> https://patchwork.kernel.org/project/linux-rockchip/patch/20250528221823.2974653-2-joseph.kogut@gmail.com/ >> >> On 5/29/25 18:19, Krzysztof Kozlowski wrote: >>> On Wed, May 28, 2025 at 03:18:21PM GMT, Joseph Kogut wrote: >>>> Add device tree binding for the Radxa CM5 IO board. >>>> >>>> This board is based on the rk3588s. >>> >>> Do not attach (thread) your patchsets to some other threads (unrelated >>> or older versions). This buries them deep in the mailbox and might >>> interfere with applying entire sets. >>> >>> >>> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> >> Please explain the sorting rule used for this file. You must have known >> the sorting rule; otherwise, how can you be sure this patch is correct? > > Huh? I don't have a clue about sorting rule but if you mock my review > let's make it different: > > NAK Please ignore, I thought that's patch from FUKAUMI Naoki which code and then pokes about that. Best regards, Krzysztof
Hi Joseph Your patch seems to be NAKed. I will submit new patch soon. Best regards, -- FUKAUMI Naoki Radxa Computer (Shenzhen) Co., Ltd. On 10/28/25 18:37, Krzysztof Kozlowski wrote: > On 28/10/2025 10:33, FUKAUMI Naoki wrote: >> Hi Krzysztof, >> >> https://patchwork.kernel.org/project/linux-rockchip/patch/20250528221823.2974653-2-joseph.kogut@gmail.com/ >> >> On 5/29/25 18:19, Krzysztof Kozlowski wrote: >>> On Wed, May 28, 2025 at 03:18:21PM GMT, Joseph Kogut wrote: >>>> Add device tree binding for the Radxa CM5 IO board. >>>> >>>> This board is based on the rk3588s. >>> >>> Do not attach (thread) your patchsets to some other threads (unrelated >>> or older versions). This buries them deep in the mailbox and might >>> interfere with applying entire sets. >>> >>> >>> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> >> Please explain the sorting rule used for this file. You must have known >> the sorting rule; otherwise, how can you be sure this patch is correct? > > Huh? I don't have a clue about sorting rule but if you mock my review > let's make it different: > > NAK > > Best regards, > Krzysztof >
On 28/10/2025 10:44, FUKAUMI Naoki wrote: > Hi Joseph > > Your patch seems to be NAKed. > I will submit new patch soon. Sorry, what? Don't hijack other people's work. > > Best regards, > > -- > FUKAUMI Naoki > Radxa Computer (Shenzhen) Co., Ltd. > > On 10/28/25 18:37, Krzysztof Kozlowski wrote: >> On 28/10/2025 10:33, FUKAUMI Naoki wrote: >>> Hi Krzysztof, >>> >>> https://patchwork.kernel.org/project/linux-rockchip/patch/20250528221823.2974653-2-joseph.kogut@gmail.com/ >>> >>> On 5/29/25 18:19, Krzysztof Kozlowski wrote: >>>> On Wed, May 28, 2025 at 03:18:21PM GMT, Joseph Kogut wrote: >>>>> Add device tree binding for the Radxa CM5 IO board. >>>>> >>>>> This board is based on the rk3588s. >>>> >>>> Do not attach (thread) your patchsets to some other threads (unrelated >>>> or older versions). This buries them deep in the mailbox and might >>>> interfere with applying entire sets. >>>> >>>> >>>> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> >>> Please explain the sorting rule used for this file. You must have known >>> the sorting rule; otherwise, how can you be sure this patch is correct? >> >> Huh? I don't have a clue about sorting rule but if you mock my review >> let's make it different: >> >> NAK Ah, you were poking around other patch? I should have ignored that :/ Best regards, Krzysztof
Hi Krzysztof On 10/28/25 19:41, Krzysztof Kozlowski wrote: > On 28/10/2025 10:44, FUKAUMI Naoki wrote: >> Hi Joseph >> >> Your patch seems to be NAKed. >> I will submit new patch soon. > > Sorry, what? Don't hijack other people's work. I have Joseph's permission to post my patch. Furthermore, this is not the first time, to my knowledge, that someone else has posted another patch for the same board. (See below) https://lore.kernel.org/linux-rockchip/20241226005845.46473-1-naoki@radxa.com/T/#u https://lore.kernel.org/linux-rockchip/20250324-rock5bp-for-upstream-v1-0-6217edf15b19@kernel.org/T/#u Best regards, -- FUKAUMI Naoki Radxa Computer (Shenzhen) Co., Ltd. >> >> Best regards, >> >> -- >> FUKAUMI Naoki >> Radxa Computer (Shenzhen) Co., Ltd. >> >> On 10/28/25 18:37, Krzysztof Kozlowski wrote: >>> On 28/10/2025 10:33, FUKAUMI Naoki wrote: >>>> Hi Krzysztof, >>>> >>>> https://patchwork.kernel.org/project/linux-rockchip/patch/20250528221823.2974653-2-joseph.kogut@gmail.com/ >>>> >>>> On 5/29/25 18:19, Krzysztof Kozlowski wrote: >>>>> On Wed, May 28, 2025 at 03:18:21PM GMT, Joseph Kogut wrote: >>>>>> Add device tree binding for the Radxa CM5 IO board. >>>>>> >>>>>> This board is based on the rk3588s. >>>>> >>>>> Do not attach (thread) your patchsets to some other threads (unrelated >>>>> or older versions). This buries them deep in the mailbox and might >>>>> interfere with applying entire sets. >>>>> >>>>> >>>>> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> >>>> Please explain the sorting rule used for this file. You must have known >>>> the sorting rule; otherwise, how can you be sure this patch is correct? >>> >>> Huh? I don't have a clue about sorting rule but if you mock my review >>> let's make it different: >>> >>> NAK > > > Ah, you were poking around other patch? I should have ignored that :/ > > > Best regards, > Krzysztof >
On 11/5/25 10:37, FUKAUMI Naoki wrote: > Hi Krzysztof > > On 10/28/25 19:41, Krzysztof Kozlowski wrote: >> On 28/10/2025 10:44, FUKAUMI Naoki wrote: >>> Hi Joseph >>> >>> Your patch seems to be NAKed. >>> I will submit new patch soon. >> >> Sorry, what? Don't hijack other people's work. > > I have Joseph's permission to post my patch. > > Furthermore, this is not the first time, to my knowledge, that someone > else has posted another patch for the same board. (See below) > > https://lore.kernel.org/linux-rockchip/20241226005845.46473-1- > naoki@radxa.com/T/#u > https://lore.kernel.org/linux-rockchip/20250324-rock5bp-for-upstream- > v1-0-6217edf15b19@kernel.org/T/#u Could you please write concise and precise answers/comments for the part you previously snipped[1]? [1] https://lore.kernel.org/linux-rockchip/86939056-7617-4730-9464-f7ecbd0e4537@kernel.org/ Best regards, -- FUKAUMI Naoki Radxa Computer (Shenzhen) Co., Ltd. > Best regards, > > -- > FUKAUMI Naoki > Radxa Computer (Shenzhen) Co., Ltd. > >>> >>> Best regards, >>> >>> -- >>> FUKAUMI Naoki >>> Radxa Computer (Shenzhen) Co., Ltd. >>> >>> On 10/28/25 18:37, Krzysztof Kozlowski wrote: >>>> On 28/10/2025 10:33, FUKAUMI Naoki wrote: >>>>> Hi Krzysztof, >>>>> >>>>> https://patchwork.kernel.org/project/linux-rockchip/ >>>>> patch/20250528221823.2974653-2-joseph.kogut@gmail.com/ >>>>> >>>>> On 5/29/25 18:19, Krzysztof Kozlowski wrote: >>>>>> On Wed, May 28, 2025 at 03:18:21PM GMT, Joseph Kogut wrote: >>>>>>> Add device tree binding for the Radxa CM5 IO board. >>>>>>> >>>>>>> This board is based on the rk3588s. >>>>>> >>>>>> Do not attach (thread) your patchsets to some other threads >>>>>> (unrelated >>>>>> or older versions). This buries them deep in the mailbox and might >>>>>> interfere with applying entire sets. >>>>>> >>>>>> >>>>>> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> >>>>> Please explain the sorting rule used for this file. You must have >>>>> known >>>>> the sorting rule; otherwise, how can you be sure this patch is >>>>> correct? >>>> >>>> Huh? I don't have a clue about sorting rule but if you mock my review >>>> let's make it different: >>>> >>>> NAK >> >> >> Ah, you were poking around other patch? I should have ignored that :/ >> >> >> Best regards, >> Krzysztof >> >
On 05/11/2025 02:37, FUKAUMI Naoki wrote: > Hi Krzysztof > > On 10/28/25 19:41, Krzysztof Kozlowski wrote: >> On 28/10/2025 10:44, FUKAUMI Naoki wrote: >>> Hi Joseph >>> >>> Your patch seems to be NAKed. >>> I will submit new patch soon. >> >> Sorry, what? Don't hijack other people's work. > > I have Joseph's permission to post my patch. This patch is correct, so you taking and hijacking it is not acceptable. Best regards, Krzysztof
I've reviewed the man page for git-send-email. If I'm understanding correctly, I should only thread the *cover letter* of the patch series when submitting a new version. That didn't work for me here because I didn't initially include a cover letter, then tried to thread the first patch in the series. I see now how that would be disruptive. Thanks for the review, and the help with threading, Krzysztof. Parts of the mailing list etiquette are still new to me. Best, Joseph
On 29/05/2025 19:00, Joseph Kogut wrote: > I've reviewed the man page for git-send-email. If I'm understanding > correctly, I should only thread the *cover letter* of the patch series > when submitting a new version. That didn't work for me here because I > didn't initially include a cover letter, then tried to thread the > first patch in the series. I see now how that would be disruptive. You should not thread manually anything. b4 does it for you. If you want to use git-send-email, then you also don't care: git format-patch -v3 -3 HEAD git send-email <whatever-to-and-cc-arguments> v3* That's it. No manual threading. Best regards, Krzysztof
On Thu, May 29, 2025 at 10:07 AM Krzysztof Kozlowski <krzk@kernel.org> wrote: > > On 29/05/2025 19:00, Joseph Kogut wrote: > > I've reviewed the man page for git-send-email. If I'm understanding > > correctly, I should only thread the *cover letter* of the patch series > > when submitting a new version. That didn't work for me here because I > > didn't initially include a cover letter, then tried to thread the > > first patch in the series. I see now how that would be disruptive. > You should not thread manually anything. b4 does it for you. If you want > to use git-send-email, then you also don't care: > > git format-patch -v3 -3 HEAD > git send-email <whatever-to-and-cc-arguments> v3* > > That's it. No manual threading. > I wasn't aware of b4, it looks like a great tool for this workflow. Thanks again for your help, I'll give it a try. Best, Joseph
© 2016 - 2025 Red Hat, Inc.