[PATCH 2/2] arm64: dts: renesas: r9a09g056n48-rzv2n-evk: Enable USB2.0 support

Prabhakar posted 2 patches 8 months, 2 weeks ago
[PATCH 2/2] arm64: dts: renesas: r9a09g056n48-rzv2n-evk: Enable USB2.0 support
Posted by Prabhakar 8 months, 2 weeks ago
From: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>

Enable USB2.0 support on the RZ/V2N EVK board, CN2 connector on the EVK
supports host/function operation.

Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
---
 .../dts/renesas/r9a09g056n48-rzv2n-evk.dts    | 36 +++++++++++++++++++
 1 file changed, 36 insertions(+)

diff --git a/arch/arm64/boot/dts/renesas/r9a09g056n48-rzv2n-evk.dts b/arch/arm64/boot/dts/renesas/r9a09g056n48-rzv2n-evk.dts
index 55aa2bdce132..795d9f6b9651 100644
--- a/arch/arm64/boot/dts/renesas/r9a09g056n48-rzv2n-evk.dts
+++ b/arch/arm64/boot/dts/renesas/r9a09g056n48-rzv2n-evk.dts
@@ -82,6 +82,11 @@ &audio_extal_clk {
 	clock-frequency = <22579200>;
 };
 
+&ehci0 {
+	dr_mode = "otg";
+	status = "okay";
+};
+
 &eth0 {
 	pinctrl-0 = <&eth0_pins>;
 	pinctrl-names = "default";
@@ -103,6 +108,11 @@ &gpu {
 	mali-supply = <&reg_0p8v>;
 };
 
+&hsusb {
+	dr_mode = "otg";
+	status = "okay";
+};
+
 &i2c0 {
 	pinctrl-0 = <&i2c0_pins>;
 	pinctrl-names = "default";
@@ -190,6 +200,11 @@ phy1: ethernet-phy@1 {
 	};
 };
 
+&ohci0 {
+	dr_mode = "otg";
+	status = "okay";
+};
+
 &ostm0 {
 	status = "okay";
 };
@@ -302,6 +317,16 @@ sd1-dat-cmd {
 			slew-rate = <0>;
 		};
 	};
+
+	usb20_pins: usb20 {
+		ovc {
+			pinmux =  <RZV2N_PORT_PINMUX(9, 6, 14)>; /* OVC */
+		};
+
+		vbus {
+			pinmux = <RZV2N_PORT_PINMUX(9, 5, 14)>; /* VBUS */
+		};
+	};
 };
 
 &qextal_clk {
@@ -330,6 +355,17 @@ &sdhi1 {
 	status = "okay";
 };
 
+&usb20phyrst {
+	status = "okay";
+};
+
+&usb2_phy0 {
+	pinctrl-0 = <&usb20_pins>;
+	pinctrl-names = "default";
+
+	status = "okay";
+};
+
 &wdt1 {
 	status = "okay";
 };
-- 
2.49.0
Re: [PATCH 2/2] arm64: dts: renesas: r9a09g056n48-rzv2n-evk: Enable USB2.0 support
Posted by Geert Uytterhoeven 8 months ago
Hi Prabhakar,

On Wed, 28 May 2025 at 16:05, Prabhakar <prabhakar.csengg@gmail.com> wrote:
> From: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
>
> Enable USB2.0 support on the RZ/V2N EVK board, CN2 connector on the EVK
> supports host/function operation.
>
> Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>

Thanks for your patch!

> --- a/arch/arm64/boot/dts/renesas/r9a09g056n48-rzv2n-evk.dts
> +++ b/arch/arm64/boot/dts/renesas/r9a09g056n48-rzv2n-evk.dts
> @@ -302,6 +317,16 @@ sd1-dat-cmd {
>                         slew-rate = <0>;
>                 };
>         };
> +
> +       usb20_pins: usb20 {
> +               ovc {
> +                       pinmux =  <RZV2N_PORT_PINMUX(9, 6, 14)>; /* OVC */

Any specific reason why OVC needs "bias-pull-up" on RZ/V2H EVK, but
not on RZ/V2N EVK?

> +               };
> +
> +               vbus {
> +                       pinmux = <RZV2N_PORT_PINMUX(9, 5, 14)>; /* VBUS */
> +               };
> +       };
>  };
>
>  &qextal_clk {

The rest LGTM, so
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
i.e. will queue in renesas-devel for v6.17 when the above is sorted out.

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
Re: [PATCH 2/2] arm64: dts: renesas: r9a09g056n48-rzv2n-evk: Enable USB2.0 support
Posted by Lad, Prabhakar 8 months ago
Hi Geert,

Thank you for the review.

On Thu, Jun 12, 2025 at 1:49 PM Geert Uytterhoeven <geert@linux-m68k.org> wrote:
>
> Hi Prabhakar,
>
> On Wed, 28 May 2025 at 16:05, Prabhakar <prabhakar.csengg@gmail.com> wrote:
> > From: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
> >
> > Enable USB2.0 support on the RZ/V2N EVK board, CN2 connector on the EVK
> > supports host/function operation.
> >
> > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
>
> Thanks for your patch!
>
> > --- a/arch/arm64/boot/dts/renesas/r9a09g056n48-rzv2n-evk.dts
> > +++ b/arch/arm64/boot/dts/renesas/r9a09g056n48-rzv2n-evk.dts
> > @@ -302,6 +317,16 @@ sd1-dat-cmd {
> >                         slew-rate = <0>;
> >                 };
> >         };
> > +
> > +       usb20_pins: usb20 {
> > +               ovc {
> > +                       pinmux =  <RZV2N_PORT_PINMUX(9, 6, 14)>; /* OVC */
>
> Any specific reason why OVC needs "bias-pull-up" on RZ/V2H EVK, but
> not on RZ/V2N EVK?
>
On the RZ/V2N EVK for the USB20_OVRCUR pin we have R13110K0603 pullup
resistor, this was missing on the earlier version of the RZ/V2H EVK
due to which we saw false OC condition (as seen below). Said that the
actual EVKs for RZ/V2H for which support is being added do have this
pullup resistor. After testing I will post a patch to drop the
`bias-pull-up` property from the RZ/V2H DTS (thanks for reminding me
:-)).

[    2.672424] usb usb3-port1: over-current condition
[    2.792424] usb usb4-port1: over-current condition

Cheers,
Prabhakar
Re: [PATCH 2/2] arm64: dts: renesas: r9a09g056n48-rzv2n-evk: Enable USB2.0 support
Posted by Geert Uytterhoeven 8 months ago
Hi Prabhakar,

On Thu, 12 Jun 2025 at 15:25, Lad, Prabhakar <prabhakar.csengg@gmail.com> wrote:
> On Thu, Jun 12, 2025 at 1:49 PM Geert Uytterhoeven <geert@linux-m68k.org> wrote:
> > On Wed, 28 May 2025 at 16:05, Prabhakar <prabhakar.csengg@gmail.com> wrote:
> > > From: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
> > >
> > > Enable USB2.0 support on the RZ/V2N EVK board, CN2 connector on the EVK
> > > supports host/function operation.
> > >
> > > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
> >
> > Thanks for your patch!
> >
> > > --- a/arch/arm64/boot/dts/renesas/r9a09g056n48-rzv2n-evk.dts
> > > +++ b/arch/arm64/boot/dts/renesas/r9a09g056n48-rzv2n-evk.dts
> > > @@ -302,6 +317,16 @@ sd1-dat-cmd {
> > >                         slew-rate = <0>;
> > >                 };
> > >         };
> > > +
> > > +       usb20_pins: usb20 {
> > > +               ovc {
> > > +                       pinmux =  <RZV2N_PORT_PINMUX(9, 6, 14)>; /* OVC */
> >
> > Any specific reason why OVC needs "bias-pull-up" on RZ/V2H EVK, but
> > not on RZ/V2N EVK?
> >
> On the RZ/V2N EVK for the USB20_OVRCUR pin we have R13110K0603 pullup
> resistor, this was missing on the earlier version of the RZ/V2H EVK
> due to which we saw false OC condition (as seen below). Said that the

Thanks, I missed following one branch on the schematics :-(

> actual EVKs for RZ/V2H for which support is being added do have this
> pullup resistor. After testing I will post a patch to drop the
> `bias-pull-up` property from the RZ/V2H DTS (thanks for reminding me
> :-)).

Great, thanks!

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds