[PATCH v2 0/2] Improve adv7511_mode_set()

Tommaso Merciai posted 2 patches 6 months, 3 weeks ago
drivers/gpu/drm/bridge/adv7511/adv7511.h     | 1 +
drivers/gpu/drm/bridge/adv7511/adv7511_drv.c | 4 ++++
drivers/gpu/drm/bridge/adv7511/adv7533.c     | 5 +----
3 files changed, 6 insertions(+), 4 deletions(-)
[PATCH v2 0/2] Improve adv7511_mode_set()
Posted by Tommaso Merciai 6 months, 3 weeks ago
Dear All,

Currently adv7511_bridge_atomic_enable() call adv7511_power_on(), then
adv7511_dsi_config_timing_gen() that is responsible to update h/v porch
params.

But during the adv7511_mode_set() adv7511->curr_mode change and this is
not reflected into the h/v ADV porch regs, then h/w porch regs are keeping
the old values.

This series fix this issue moving adv711_dsi_config_timing_gen() into
the adv7511_mode_set().

Thanks & Regards,
Tommaso

v1->v2:
 - Added cover letter

Tommaso Merciai (2):
  drm/bridge: adv7511: Move adv711_dsi_config_timing_gen() into
    adv7511_mode_set()
  drm/bridge: adv7511: Rename adv7511_dsi_config_timing_gen() into
    adv7533_dsi_config_timing_gen()

 drivers/gpu/drm/bridge/adv7511/adv7511.h     | 1 +
 drivers/gpu/drm/bridge/adv7511/adv7511_drv.c | 4 ++++
 drivers/gpu/drm/bridge/adv7511/adv7533.c     | 5 +----
 3 files changed, 6 insertions(+), 4 deletions(-)

-- 
2.43.0
Re: [PATCH v2 0/2] Improve adv7511_mode_set()
Posted by Dmitry Baryshkov 6 months, 3 weeks ago
On Wed, 28 May 2025 09:04:36 +0200, Tommaso Merciai wrote:
> Currently adv7511_bridge_atomic_enable() call adv7511_power_on(), then
> adv7511_dsi_config_timing_gen() that is responsible to update h/v porch
> params.
> 
> But during the adv7511_mode_set() adv7511->curr_mode change and this is
> not reflected into the h/v ADV porch regs, then h/w porch regs are keeping
> the old values.
> 
> [...]

Applied to drm-misc-next, thanks!

[1/2] drm/bridge: adv7511: Move adv711_dsi_config_timing_gen() into adv7511_mode_set()
      commit: 1f5090c4ae71d070aa9dac49b8ef3efe0da0fb36
[2/2] drm/bridge: adv7511: Rename adv7511_dsi_config_timing_gen() into adv7533_dsi_config_timing_gen()
      commit: 6e76b312a681224881c05835ed5a26e012ce80ea

Best regards,
-- 
Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Re: [PATCH v2 0/2] Improve adv7511_mode_set()
Posted by Dmitry Baryshkov 6 months, 3 weeks ago
On Wed, May 28, 2025 at 09:04:36AM +0200, Tommaso Merciai wrote:
> Dear All,
> 
> Currently adv7511_bridge_atomic_enable() call adv7511_power_on(), then
> adv7511_dsi_config_timing_gen() that is responsible to update h/v porch
> params.
> 
> But during the adv7511_mode_set() adv7511->curr_mode change and this is
> not reflected into the h/v ADV porch regs, then h/w porch regs are keeping
> the old values.
> 
> This series fix this issue moving adv711_dsi_config_timing_gen() into
> the adv7511_mode_set().
> 
> Thanks & Regards,
> Tommaso

For the series:


Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>


-- 
With best wishes
Dmitry