[PATCH v3 0/2] net: stmmac: prevent div by 0

Alexis Lothoré posted 2 patches 6 months, 3 weeks ago
There is a newer version of this series
drivers/net/ethernet/stmicro/stmmac/stmmac_est.c  | 5 +++++
drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 5 +++++
drivers/net/ethernet/stmicro/stmmac/stmmac_ptp.c  | 2 +-
3 files changed, 11 insertions(+), 1 deletion(-)
[PATCH v3 0/2] net: stmmac: prevent div by 0
Posted by Alexis Lothoré 6 months, 3 weeks ago
Hello,
this small series aims to fix a small splat I am observing on a STM32MP157
platform at boot (see commit 1) due to a division by 0. This new
revision add the same check in another code path possibly affected by
the same issue, as discussed in v2.

Signed-off-by: Alexis Lothoré <alexis.lothore@bootlin.com>
---
Changes in v3:
- remove now duplicate check
- add ptp_rate check in est_configure
- Link to v2: https://lore.kernel.org/r/20250527-stmmac_tstamp_div-v2-1-663251b3b542@bootlin.com

Changes in v2:
- Add Fixes tag
- Reword commit message to clarify the triggering cause of the issue
- Link to v1: https://lore.kernel.org/r/20250523-stmmac_tstamp_div-v1-1-bca8a5a3a477@bootlin.com

---
Alexis Lothoré (2):
      net: stmmac: make sure that ptp_rate is not 0 before configuring timestamping
      net: stmmac: make sure that ptp_rate is not 0 before configuring EST

 drivers/net/ethernet/stmicro/stmmac/stmmac_est.c  | 5 +++++
 drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 5 +++++
 drivers/net/ethernet/stmicro/stmmac/stmmac_ptp.c  | 2 +-
 3 files changed, 11 insertions(+), 1 deletion(-)
---
base-commit: e0e2f78243385e7188a57fcfceb6a19f723f1dff
change-id: 20250522-stmmac_tstamp_div-f55112f06029

Best regards,
-- 
Alexis Lothoré, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

Re: [PATCH v3 0/2] net: stmmac: prevent div by 0
Posted by Jakub Kicinski 6 months, 3 weeks ago
On Wed, 28 May 2025 10:29:49 +0200 Alexis Lothoré wrote:
> Hello,
> this small series aims to fix a small splat I am observing on a STM32MP157
> platform at boot (see commit 1) due to a division by 0. This new
> revision add the same check in another code path possibly affected by
> the same issue, as discussed in v2.

v3 doesnt apply cleanly. Could you rebase on latest net and repost?