TI TPS65214 & TPS65215: Update MFD Cell Structs

[PATCH 1/2] mfd: tps65219: Update TPS65214 MFD cell's GPIO compatible string

Posted by Shree Ramamoorthy 6 months, 3 weeks ago

This patch reflects the change made to move TPS65215 from 1 GPO and 1 GPIO
to 2 GPOs and 1 GPIO. TPS65215 and TPS65219 both have 2 GPOs and 1 GPIO.
TPS65214 has 1 GPO and 1 GPIO. TPS65215 will reuse the TPS65219 GPIO
compatible string.

TPS65214 TRM: https://www.ti.com/lit/pdf/slvud30
TPS65215 TRM: https://www.ti.com/lit/pdf/slvucw5/

Fixes: 7947219ab1a2 ("mfd: tps65219: Add support for TI TPS65214 PMIC")
Signed-off-by: Shree Ramamoorthy <s-ramamoorthy@ti.com>
---
 drivers/mfd/tps65219.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/mfd/tps65219.c b/drivers/mfd/tps65219.c
index fd390600fbf0..297511025dd4 100644
--- a/drivers/mfd/tps65219.c
+++ b/drivers/mfd/tps65219.c
@@ -190,7 +190,7 @@ static const struct resource tps65219_regulator_resources[] = {
 
 static const struct mfd_cell tps65214_cells[] = {
 	MFD_CELL_RES("tps65214-regulator", tps65214_regulator_resources),
-	MFD_CELL_NAME("tps65215-gpio"),
+	MFD_CELL_NAME("tps65214-gpio"),
 };
 
 static const struct mfd_cell tps65215_cells[] = {
-- 
2.43.0

Re: [PATCH 1/2] mfd: tps65219: Update TPS65214 MFD cell's GPIO compatible string

Posted by Lee Jones 6 months, 1 week ago

On Tue, 27 May 2025, Shree Ramamoorthy wrote:

> This patch reflects the change made to move TPS65215 from 1 GPO and 1 GPIO
> to 2 GPOs and 1 GPIO. TPS65215 and TPS65219 both have 2 GPOs and 1 GPIO.
> TPS65214 has 1 GPO and 1 GPIO. TPS65215 will reuse the TPS65219 GPIO
> compatible string.
> 
> TPS65214 TRM: https://www.ti.com/lit/pdf/slvud30
> TPS65215 TRM: https://www.ti.com/lit/pdf/slvucw5/
> 
> Fixes: 7947219ab1a2 ("mfd: tps65219: Add support for TI TPS65214 PMIC")
> Signed-off-by: Shree Ramamoorthy <s-ramamoorthy@ti.com>
> ---
>  drivers/mfd/tps65219.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/mfd/tps65219.c b/drivers/mfd/tps65219.c
> index fd390600fbf0..297511025dd4 100644
> --- a/drivers/mfd/tps65219.c
> +++ b/drivers/mfd/tps65219.c
> @@ -190,7 +190,7 @@ static const struct resource tps65219_regulator_resources[] = {
>  
>  static const struct mfd_cell tps65214_cells[] = {
>  	MFD_CELL_RES("tps65214-regulator", tps65214_regulator_resources),
> -	MFD_CELL_NAME("tps65215-gpio"),
> +	MFD_CELL_NAME("tps65214-gpio"),

Neither of these exist anywhere.

I'll assume they will be available soon.

>  };
>  
>  static const struct mfd_cell tps65215_cells[] = {
> -- 
> 2.43.0
> 

-- 
Lee Jones [李琼斯]

Re: [PATCH 1/2] mfd: tps65219: Update TPS65214 MFD cell's GPIO compatible string

Posted by Shree Ramamoorthy 6 months, 1 week ago

On 6/13/25 8:15 AM, Lee Jones wrote:
> On Tue, 27 May 2025, Shree Ramamoorthy wrote:
>
>> This patch reflects the change made to move TPS65215 from 1 GPO and 1 GPIO
>> to 2 GPOs and 1 GPIO. TPS65215 and TPS65219 both have 2 GPOs and 1 GPIO.
>> TPS65214 has 1 GPO and 1 GPIO. TPS65215 will reuse the TPS65219 GPIO
>> compatible string.
>>
>> TPS65214 TRM: https://www.ti.com/lit/pdf/slvud30
>> TPS65215 TRM: https://www.ti.com/lit/pdf/slvucw5/
>>
>> Fixes: 7947219ab1a2 ("mfd: tps65219: Add support for TI TPS65214 PMIC")
>> Signed-off-by: Shree Ramamoorthy <s-ramamoorthy@ti.com>
>> ---
>>   drivers/mfd/tps65219.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/mfd/tps65219.c b/drivers/mfd/tps65219.c
>> index fd390600fbf0..297511025dd4 100644
>> --- a/drivers/mfd/tps65219.c
>> +++ b/drivers/mfd/tps65219.c
>> @@ -190,7 +190,7 @@ static const struct resource tps65219_regulator_resources[] = {
>>   
>>   static const struct mfd_cell tps65214_cells[] = {
>>   	MFD_CELL_RES("tps65214-regulator", tps65214_regulator_resources),
>> -	MFD_CELL_NAME("tps65215-gpio"),
>> +	MFD_CELL_NAME("tps65214-gpio"),
> Neither of these exist anywhere.
>
> I'll assume they will be available soon.

I'll be upstreaming v5 of this gpio series [0] after I complete internal reviews!
[0]: https://lore.kernel.org/all/20250425203315.71497-1-s-ramamoorthy@ti.com/

>
>>   };
>>   
>>   static const struct mfd_cell tps65215_cells[] = {
>> -- 
>> 2.43.0
>>

-- 
Best,
Shree Ramamoorthy
PMIC Software Engineer

Re: (subset) [PATCH 1/2] mfd: tps65219: Update TPS65214 MFD cell's GPIO compatible string

Posted by Lee Jones 6 months, 1 week ago

On Tue, 27 May 2025 14:04:54 -0500, Shree Ramamoorthy wrote:
> This patch reflects the change made to move TPS65215 from 1 GPO and 1 GPIO
> to 2 GPOs and 1 GPIO. TPS65215 and TPS65219 both have 2 GPOs and 1 GPIO.
> TPS65214 has 1 GPO and 1 GPIO. TPS65215 will reuse the TPS65219 GPIO
> compatible string.
> 
> TPS65214 TRM: https://www.ti.com/lit/pdf/slvud30
> TPS65215 TRM: https://www.ti.com/lit/pdf/slvucw5/
> 
> [...]

Applied, thanks!

[1/2] mfd: tps65219: Update TPS65214 MFD cell's GPIO compatible string
      commit: 75213cd351ac2df3bb3e70d203cef0a1c7a5f4d4

--
Lee Jones [李琼斯]