[PATCH v1] ext4: remove unused EXT_STATS macro from ext4_extents.h

Baolin Liu posted 1 patch 6 months, 3 weeks ago
fs/ext4/ext4_extents.h | 7 -------
1 file changed, 7 deletions(-)
[PATCH v1] ext4: remove unused EXT_STATS macro from ext4_extents.h
Posted by Baolin Liu 6 months, 3 weeks ago
From: Baolin Liu <liubaolin@kylinos.cn>

The EXT_STATS macro in fs/ext4/ext4_extents.h has been defined
but never used in the codebase since its introduction. This patch
removes it.

Analysis:
1. No references found in fs/ext4/ or other kernel code.
2. No impact on compilation or functionality.
3. Git history shows it was never utilized.

Signed-off-by: Baolin Liu <liubaolin@kylinos.cn>
---
 fs/ext4/ext4_extents.h | 7 -------
 1 file changed, 7 deletions(-)

diff --git a/fs/ext4/ext4_extents.h b/fs/ext4/ext4_extents.h
index 26435f3a3094..c484125d963f 100644
--- a/fs/ext4/ext4_extents.h
+++ b/fs/ext4/ext4_extents.h
@@ -30,13 +30,6 @@
  */
 #define CHECK_BINSEARCH__
 
-/*
- * If EXT_STATS is defined then stats numbers are collected.
- * These number will be displayed at umount time.
- */
-#define EXT_STATS_
-
-
 /*
  * ext4_inode has i_block array (60 bytes total).
  * The first 12 bytes store ext4_extent_header;
-- 
2.39.2
Re: [PATCH v1] ext4: remove unused EXT_STATS macro from ext4_extents.h
Posted by Theodore Ts'o 5 months ago
On Tue, 27 May 2025 13:38:05 +0800, Baolin Liu wrote:
> The EXT_STATS macro in fs/ext4/ext4_extents.h has been defined
> but never used in the codebase since its introduction. This patch
> removes it.
> 
> Analysis:
> 1. No references found in fs/ext4/ or other kernel code.
> 2. No impact on compilation or functionality.
> 3. Git history shows it was never utilized.
> 
> [...]

Applied, thanks!

[1/1] ext4: remove unused EXT_STATS macro from ext4_extents.h
      commit: a073e8577f1816cfd2cff25d0a4ffbeb064b48ae

Best regards,
-- 
Theodore Ts'o <tytso@mit.edu>
Re: [PATCH v1] ext4: remove unused EXT_STATS macro from ext4_extents.h
Posted by Baokun Li 6 months, 3 weeks ago
On 2025/5/27 13:38, Baolin Liu wrote:
> From: Baolin Liu <liubaolin@kylinos.cn>
>
> The EXT_STATS macro in fs/ext4/ext4_extents.h has been defined
> but never used in the codebase since its introduction. This patch
> removes it.
>
> Analysis:
> 1. No references found in fs/ext4/ or other kernel code.
> 2. No impact on compilation or functionality.
> 3. Git history shows it was never utilized.
>
> Signed-off-by: Baolin Liu <liubaolin@kylinos.cn>
Good spotting! Feel free to add:

Reviewed-by: Baokun Li <libaokun1@huawei.com>
> ---
>   fs/ext4/ext4_extents.h | 7 -------
>   1 file changed, 7 deletions(-)
>
> diff --git a/fs/ext4/ext4_extents.h b/fs/ext4/ext4_extents.h
> index 26435f3a3094..c484125d963f 100644
> --- a/fs/ext4/ext4_extents.h
> +++ b/fs/ext4/ext4_extents.h
> @@ -30,13 +30,6 @@
>    */
>   #define CHECK_BINSEARCH__
>   
> -/*
> - * If EXT_STATS is defined then stats numbers are collected.
> - * These number will be displayed at umount time.
> - */
> -#define EXT_STATS_
> -
> -
>   /*
>    * ext4_inode has i_block array (60 bytes total).
>    * The first 12 bytes store ext4_extent_header;