1. Patchew
  2. linux
  3. View series

[PATCH v2] dt-bindings: iio: adc: adi,ad7606: fix dt_schema validation warning

Angelo Dureghello posted 1 patch 6 months, 3 weeks ago 
Documentation/devicetree/bindings/iio/adc/adi,ad7606.yaml | 6 ------
1 file changed, 6 deletions(-)
[PATCH v2] dt-bindings: iio: adc: adi,ad7606: fix dt_schema validation warning
Posted by Angelo Dureghello 6 months, 3 weeks ago 
From: Angelo Dureghello <adureghello@baylibre.com>

Fix following dt_schema warning when offload is used:

  DTC [C] arch/arm/boot/dts/xilinx/zynq-zed-adv7511-ad7606.dtb
/home/angelo/dev-baylibre/linux-iio/arch/arm/boot/dts/xilinx/zynq-zed-adv7511-ad7606.dtb: adc@0: 'oneOf' conditional failed, one must be fixed:
	'interrupts' is a required property
	'io-backends' is a required property
	from schema $id: http://devicetree.org/schemas/iio/adc/adi,ad7606.yaml#

There isn't any reason that we couldn't have interrupts wired up at the
same time we are using io-backends or SPI offload, so dropping off the
related "oneOf" block entirely.

Fixes: ccf8c3f106a2 ("dt-bindings: iio: adc: adi,ad7606: add SPI offload properties")
Signed-off-by: Angelo Dureghello <adureghello@baylibre.com>
---
Fix dt_schema validation warning.

Link: https://lore.kernel.org/linux-iio/20250408-wip-bl-ad3552r-fixes-v4-0-b33c0264bd78@baylibre.com
---
Changes in v2:
- Change removing the related oneOf block. 
- Link to v1: https://lore.kernel.org/r/20250523-wip-bl-ad7606-dtschema-fixes-v1-1-d9147fb2a199@baylibre.com
---
 Documentation/devicetree/bindings/iio/adc/adi,ad7606.yaml | 6 ------
 1 file changed, 6 deletions(-)

diff --git a/Documentation/devicetree/bindings/iio/adc/adi,ad7606.yaml b/Documentation/devicetree/bindings/iio/adc/adi,ad7606.yaml
index 29f12d650442b8ff2eb455306ce59a0e87867ddd..1a5209139e1338f803c66ad2b4d63ad53cc11d96 100644
--- a/Documentation/devicetree/bindings/iio/adc/adi,ad7606.yaml
+++ b/Documentation/devicetree/bindings/iio/adc/adi,ad7606.yaml
@@ -223,12 +223,6 @@ allOf:
       - required:
           - pwms
 
-  - oneOf:
-      - required:
-          - interrupts
-      - required:
-          - io-backends
-
   - if:
       properties:
         compatible:

---
base-commit: 3964c6e5877f054497ffccc7d00f8f7add307d0d
change-id: 20250523-wip-bl-ad7606-dtschema-fixes-5e6ab342e043

Best regards,
-- 
Angelo Dureghello <adureghello@baylibre.com>
Re: [PATCH v2] dt-bindings: iio: adc: adi,ad7606: fix dt_schema validation warning
Posted by Jonathan Cameron 6 months, 2 weeks ago 
On Mon, 26 May 2025 15:19:08 +0200
Angelo Dureghello <adureghello@baylibre.com> wrote:

> From: Angelo Dureghello <adureghello@baylibre.com>
> 
> Fix following dt_schema warning when offload is used:
> 
>   DTC [C] arch/arm/boot/dts/xilinx/zynq-zed-adv7511-ad7606.dtb
> /home/angelo/dev-baylibre/linux-iio/arch/arm/boot/dts/xilinx/zynq-zed-adv7511-ad7606.dtb: adc@0: 'oneOf' conditional failed, one must be fixed:
> 	'interrupts' is a required property
> 	'io-backends' is a required property
> 	from schema $id: http://devicetree.org/schemas/iio/adc/adi,ad7606.yaml#
> 
> There isn't any reason that we couldn't have interrupts wired up at the
> same time we are using io-backends or SPI offload, so dropping off the
> related "oneOf" block entirely.
> 
> Fixes: ccf8c3f106a2 ("dt-bindings: iio: adc: adi,ad7606: add SPI offload properties")
That ID seems to be wrong.   Probably down to the messy rebase I had to do pre pull
request.  Fixed up to be 81fe5529e812

Applied to the fixes-togreg-for-6.16 branch that will become fixes-togreg after rc1
is available to rebase on.

Thanks,

Jonathan

> Signed-off-by: Angelo Dureghello <adureghello@baylibre.com>
> ---
> Fix dt_schema validation warning.
> 
> Link: https://lore.kernel.org/linux-iio/20250408-wip-bl-ad3552r-fixes-v4-0-b33c0264bd78@baylibre.com
> ---
> Changes in v2:
> - Change removing the related oneOf block. 
> - Link to v1: https://lore.kernel.org/r/20250523-wip-bl-ad7606-dtschema-fixes-v1-1-d9147fb2a199@baylibre.com
> ---
>  Documentation/devicetree/bindings/iio/adc/adi,ad7606.yaml | 6 ------
>  1 file changed, 6 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/iio/adc/adi,ad7606.yaml b/Documentation/devicetree/bindings/iio/adc/adi,ad7606.yaml
> index 29f12d650442b8ff2eb455306ce59a0e87867ddd..1a5209139e1338f803c66ad2b4d63ad53cc11d96 100644
> --- a/Documentation/devicetree/bindings/iio/adc/adi,ad7606.yaml
> +++ b/Documentation/devicetree/bindings/iio/adc/adi,ad7606.yaml
> @@ -223,12 +223,6 @@ allOf:
>        - required:
>            - pwms
>  
> -  - oneOf:
> -      - required:
> -          - interrupts
> -      - required:
> -          - io-backends
> -
>    - if:
>        properties:
>          compatible:
> 
> ---
> base-commit: 3964c6e5877f054497ffccc7d00f8f7add307d0d
> change-id: 20250523-wip-bl-ad7606-dtschema-fixes-5e6ab342e043
> 
> Best regards,
Re: [PATCH v2] dt-bindings: iio: adc: adi,ad7606: fix dt_schema validation warning
Posted by Jonathan Cameron 5 months, 2 weeks ago 
On Sat, 31 May 2025 17:04:48 +0100
Jonathan Cameron <jic23@kernel.org> wrote:

> On Mon, 26 May 2025 15:19:08 +0200
> Angelo Dureghello <adureghello@baylibre.com> wrote:
> 
> > From: Angelo Dureghello <adureghello@baylibre.com>
> > 
> > Fix following dt_schema warning when offload is used:
> > 
> >   DTC [C] arch/arm/boot/dts/xilinx/zynq-zed-adv7511-ad7606.dtb
> > /home/angelo/dev-baylibre/linux-iio/arch/arm/boot/dts/xilinx/zynq-zed-adv7511-ad7606.dtb: adc@0: 'oneOf' conditional failed, one must be fixed:
> > 	'interrupts' is a required property
> > 	'io-backends' is a required property
> > 	from schema $id: http://devicetree.org/schemas/iio/adc/adi,ad7606.yaml#
> > 
> > There isn't any reason that we couldn't have interrupts wired up at the
> > same time we are using io-backends or SPI offload, so dropping off the
> > related "oneOf" block entirely.
> > 
> > Fixes: ccf8c3f106a2 ("dt-bindings: iio: adc: adi,ad7606: add SPI offload properties")  
> That ID seems to be wrong.   Probably down to the messy rebase I had to do pre pull
> request.  Fixed up to be 81fe5529e812
> 
> Applied to the fixes-togreg-for-6.16 branch that will become fixes-togreg after rc1
> is available to rebase on.
I guess something related to the rebase I had to do just before the last
merge window caused it, but that Fixes sha is wrong.


> 
> Thanks,
> 
> Jonathan
> 
> > Signed-off-by: Angelo Dureghello <adureghello@baylibre.com>
> > ---
> > Fix dt_schema validation warning.
> > 
> > Link: https://lore.kernel.org/linux-iio/20250408-wip-bl-ad3552r-fixes-v4-0-b33c0264bd78@baylibre.com
> > ---
> > Changes in v2:
> > - Change removing the related oneOf block. 
> > - Link to v1: https://lore.kernel.org/r/20250523-wip-bl-ad7606-dtschema-fixes-v1-1-d9147fb2a199@baylibre.com
> > ---
> >  Documentation/devicetree/bindings/iio/adc/adi,ad7606.yaml | 6 ------
> >  1 file changed, 6 deletions(-)
> > 
> > diff --git a/Documentation/devicetree/bindings/iio/adc/adi,ad7606.yaml b/Documentation/devicetree/bindings/iio/adc/adi,ad7606.yaml
> > index 29f12d650442b8ff2eb455306ce59a0e87867ddd..1a5209139e1338f803c66ad2b4d63ad53cc11d96 100644
> > --- a/Documentation/devicetree/bindings/iio/adc/adi,ad7606.yaml
> > +++ b/Documentation/devicetree/bindings/iio/adc/adi,ad7606.yaml
> > @@ -223,12 +223,6 @@ allOf:
> >        - required:
> >            - pwms
> >  
> > -  - oneOf:
> > -      - required:
> > -          - interrupts
> > -      - required:
> > -          - io-backends
> > -
> >    - if:
> >        properties:
> >          compatible:
> > 
> > ---
> > base-commit: 3964c6e5877f054497ffccc7d00f8f7add307d0d
> > change-id: 20250523-wip-bl-ad7606-dtschema-fixes-5e6ab342e043
> > 
> > Best regards,  
> 
>
Re: [PATCH v2] dt-bindings: iio: adc: adi,ad7606: fix dt_schema validation warning
Posted by Angelo Dureghello 5 months, 2 weeks ago 
Hi Jonathan,

sorry, could you merge this, or do you need the hash fix ? 

Regards,
angelo

On 29.06.2025 17:19, Jonathan Cameron wrote:
> On Sat, 31 May 2025 17:04:48 +0100
> Jonathan Cameron <jic23@kernel.org> wrote:
> 
> > On Mon, 26 May 2025 15:19:08 +0200
> > Angelo Dureghello <adureghello@baylibre.com> wrote:
> > 
> > > From: Angelo Dureghello <adureghello@baylibre.com>
> > > 
> > > Fix following dt_schema warning when offload is used:
> > > 
> > >   DTC [C] arch/arm/boot/dts/xilinx/zynq-zed-adv7511-ad7606.dtb
> > > /home/angelo/dev-baylibre/linux-iio/arch/arm/boot/dts/xilinx/zynq-zed-adv7511-ad7606.dtb: adc@0: 'oneOf' conditional failed, one must be fixed:
> > > 	'interrupts' is a required property
> > > 	'io-backends' is a required property
> > > 	from schema $id: http://devicetree.org/schemas/iio/adc/adi,ad7606.yaml#
> > > 
> > > There isn't any reason that we couldn't have interrupts wired up at the
> > > same time we are using io-backends or SPI offload, so dropping off the
> > > related "oneOf" block entirely.
> > > 
> > > Fixes: ccf8c3f106a2 ("dt-bindings: iio: adc: adi,ad7606: add SPI offload properties")  
> > That ID seems to be wrong.   Probably down to the messy rebase I had to do pre pull
> > request.  Fixed up to be 81fe5529e812
> > 
> > Applied to the fixes-togreg-for-6.16 branch that will become fixes-togreg after rc1
> > is available to rebase on.
> I guess something related to the rebase I had to do just before the last
> merge window caused it, but that Fixes sha is wrong.
> 
> 
> > 
> > Thanks,
> > 
> > Jonathan
> > 
> > > Signed-off-by: Angelo Dureghello <adureghello@baylibre.com>
> > > ---
> > > Fix dt_schema validation warning.
> > > 
> > > Link: https://lore.kernel.org/linux-iio/20250408-wip-bl-ad3552r-fixes-v4-0-b33c0264bd78@baylibre.com
> > > ---
> > > Changes in v2:
> > > - Change removing the related oneOf block. 
> > > - Link to v1: https://lore.kernel.org/r/20250523-wip-bl-ad7606-dtschema-fixes-v1-1-d9147fb2a199@baylibre.com
> > > ---
> > >  Documentation/devicetree/bindings/iio/adc/adi,ad7606.yaml | 6 ------
> > >  1 file changed, 6 deletions(-)
> > > 
> > > diff --git a/Documentation/devicetree/bindings/iio/adc/adi,ad7606.yaml b/Documentation/devicetree/bindings/iio/adc/adi,ad7606.yaml
> > > index 29f12d650442b8ff2eb455306ce59a0e87867ddd..1a5209139e1338f803c66ad2b4d63ad53cc11d96 100644
> > > --- a/Documentation/devicetree/bindings/iio/adc/adi,ad7606.yaml
> > > +++ b/Documentation/devicetree/bindings/iio/adc/adi,ad7606.yaml
> > > @@ -223,12 +223,6 @@ allOf:
> > >        - required:
> > >            - pwms
> > >  
> > > -  - oneOf:
> > > -      - required:
> > > -          - interrupts
> > > -      - required:
> > > -          - io-backends
> > > -
> > >    - if:
> > >        properties:
> > >          compatible:
> > > 
> > > ---
> > > base-commit: 3964c6e5877f054497ffccc7d00f8f7add307d0d
> > > change-id: 20250523-wip-bl-ad7606-dtschema-fixes-5e6ab342e043
> > > 
> > > Best regards,  
> > 
> > 
>
Re: [PATCH v2] dt-bindings: iio: adc: adi,ad7606: fix dt_schema validation warning
Posted by Jonathan Cameron 5 months, 2 weeks ago 
On Mon, 30 Jun 2025 11:09:02 +0200
Angelo Dureghello <adureghello@baylibre.com> wrote:

> Hi Jonathan,
> 
> sorry, could you merge this, or do you need the hash fix ? 
> 
I fixed it up.


J
Re: [PATCH v2] dt-bindings: iio: adc: adi,ad7606: fix dt_schema validation warning
Posted by Conor Dooley 6 months, 3 weeks ago 
On Mon, May 26, 2025 at 03:19:08PM +0200, Angelo Dureghello wrote:
> From: Angelo Dureghello <adureghello@baylibre.com>
> 
> Fix following dt_schema warning when offload is used:
> 
>   DTC [C] arch/arm/boot/dts/xilinx/zynq-zed-adv7511-ad7606.dtb
> /home/angelo/dev-baylibre/linux-iio/arch/arm/boot/dts/xilinx/zynq-zed-adv7511-ad7606.dtb: adc@0: 'oneOf' conditional failed, one must be fixed:
> 	'interrupts' is a required property
> 	'io-backends' is a required property
> 	from schema $id: http://devicetree.org/schemas/iio/adc/adi,ad7606.yaml#
> 
> There isn't any reason that we couldn't have interrupts wired up at the
> same time we are using io-backends or SPI offload, so dropping off the
> related "oneOf" block entirely.
> 
> Fixes: ccf8c3f106a2 ("dt-bindings: iio: adc: adi,ad7606: add SPI offload properties")
> Signed-off-by: Angelo Dureghello <adureghello@baylibre.com>

Acked-by: Conor Dooley <conor.dooley@microchip.com>

> ---
> Fix dt_schema validation warning.
> 
> Link: https://lore.kernel.org/linux-iio/20250408-wip-bl-ad3552r-fixes-v4-0-b33c0264bd78@baylibre.com
> ---
> Changes in v2:
> - Change removing the related oneOf block. 
> - Link to v1: https://lore.kernel.org/r/20250523-wip-bl-ad7606-dtschema-fixes-v1-1-d9147fb2a199@baylibre.com
> ---
>  Documentation/devicetree/bindings/iio/adc/adi,ad7606.yaml | 6 ------
>  1 file changed, 6 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/iio/adc/adi,ad7606.yaml b/Documentation/devicetree/bindings/iio/adc/adi,ad7606.yaml
> index 29f12d650442b8ff2eb455306ce59a0e87867ddd..1a5209139e1338f803c66ad2b4d63ad53cc11d96 100644
> --- a/Documentation/devicetree/bindings/iio/adc/adi,ad7606.yaml
> +++ b/Documentation/devicetree/bindings/iio/adc/adi,ad7606.yaml
> @@ -223,12 +223,6 @@ allOf:
>        - required:
>            - pwms
>  
> -  - oneOf:
> -      - required:
> -          - interrupts
> -      - required:
> -          - io-backends
> -
>    - if:
>        properties:
>          compatible:
> 
> ---
> base-commit: 3964c6e5877f054497ffccc7d00f8f7add307d0d
> change-id: 20250523-wip-bl-ad7606-dtschema-fixes-5e6ab342e043
> 
> Best regards,
> -- 
> Angelo Dureghello <adureghello@baylibre.com>
>

Patchew 2.1-devel-b67e4c2

© 2016 - 2025 Red Hat, Inc.