[PATCHv4 1/5] wifi: ath9k: ahb: reorder declarations

Rosen Penev posted 5 patches 6 months, 3 weeks ago
There is a newer version of this series
[PATCHv4 1/5] wifi: ath9k: ahb: reorder declarations
Posted by Rosen Penev 6 months, 3 weeks ago
Easier to look at. Follows netdev style.

Also remove ret assignment. Because of all of these devm conversions,
ret = 0 is a path that never gets hit. The first time it does it when
request_irq fails, but that ends up reassigning it.

Signed-off-by: Rosen Penev <rosenp@gmail.com>
---
 drivers/net/wireless/ath/ath9k/ahb.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/drivers/net/wireless/ath/ath9k/ahb.c b/drivers/net/wireless/ath/ath9k/ahb.c
index 49b7ab26c477..d2a97e74f451 100644
--- a/drivers/net/wireless/ath/ath9k/ahb.c
+++ b/drivers/net/wireless/ath/ath9k/ahb.c
@@ -71,14 +71,14 @@ static const struct ath_bus_ops ath_ahb_bus_ops  = {
 
 static int ath_ahb_probe(struct platform_device *pdev)
 {
-	void __iomem *mem;
-	struct ath_softc *sc;
-	struct ieee80211_hw *hw;
 	const struct platform_device_id *id = platform_get_device_id(pdev);
-	int irq;
-	int ret = 0;
+	struct ieee80211_hw *hw;
+	struct ath_softc *sc;
 	struct ath_hw *ah;
+	void __iomem *mem;
 	char hw_name[64];
+	int irq;
+	int ret;
 
 	if (!dev_get_platdata(&pdev->dev)) {
 		dev_err(&pdev->dev, "no platform data specified\n");
-- 
2.49.0
Re: [PATCHv4 1/5] wifi: ath9k: ahb: reorder declarations
Posted by Krzysztof Kozlowski 6 months, 3 weeks ago
On 25/05/2025 23:42, Rosen Penev wrote:
> Easier to look at. Follows netdev style.
> 
> Also remove ret assignment. Because of all of these devm conversions,
> ret = 0 is a path that never gets hit. The first time it does it when
> request_irq fails, but that ends up reassigning it.
> 
> Signed-off-by: Rosen Penev <rosenp@gmail.com>
> ---

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Best regards,
Krzysztof