[PATCH v2 0/2] iio: fix suspend and resume triggering for bmi160 and bmi270

Denis Benato posted 2 patches 6 months, 3 weeks ago
drivers/iio/imu/bmi160/bmi160.h      |  2 ++
drivers/iio/imu/bmi160/bmi160_core.c | 19 +++++++++++++++++++
drivers/iio/imu/bmi160/bmi160_i2c.c  |  2 ++
drivers/iio/imu/bmi160/bmi160_spi.c  |  2 ++
drivers/iio/imu/bmi270/bmi270.h      |  2 ++
drivers/iio/imu/bmi270/bmi270_core.c | 20 ++++++++++++++++++++
drivers/iio/imu/bmi270/bmi270_i2c.c  |  2 ++
drivers/iio/imu/bmi270/bmi270_spi.c  |  2 ++
8 files changed, 51 insertions(+)
[PATCH v2 0/2] iio: fix suspend and resume triggering for bmi160 and bmi270
Posted by Denis Benato 6 months, 3 weeks ago
Two imu devices bmi160 and bmi270 are similar to bmi323, with the same bug and
a common usecase: fix the aforementioned bug about triggering not resuming
after sleep in the same way it was solved for the bmi323 device driver.

The bmi270 patch has been tested on a device where the device irq pin
is connected to the CPU ensuring it doesn't cause harm to devices that
do not use hrtimer or other external triggers.

Changelog from v1 [1]
- include linux/pm.h where needed
- used "Closed" to reference the solved issue for each driver
- merged two lines into one (on both drivers)


[1] https://lore.kernel.org/all/20250509171526.7842-1-benato.denis96@gmail.com

Denis Benato (2):
  iio: bmi270: suspend and resume triggering on relevant pm operations
  iio: bmi160: suspend and resume triggering on relevant pm operations

 drivers/iio/imu/bmi160/bmi160.h      |  2 ++
 drivers/iio/imu/bmi160/bmi160_core.c | 19 +++++++++++++++++++
 drivers/iio/imu/bmi160/bmi160_i2c.c  |  2 ++
 drivers/iio/imu/bmi160/bmi160_spi.c  |  2 ++
 drivers/iio/imu/bmi270/bmi270.h      |  2 ++
 drivers/iio/imu/bmi270/bmi270_core.c | 20 ++++++++++++++++++++
 drivers/iio/imu/bmi270/bmi270_i2c.c  |  2 ++
 drivers/iio/imu/bmi270/bmi270_spi.c  |  2 ++
 8 files changed, 51 insertions(+)

-- 
2.49.0
Re: [PATCH v2 0/2] iio: fix suspend and resume triggering for bmi160 and bmi270
Posted by Andy Shevchenko 6 months, 3 weeks ago
On Sun, May 25, 2025 at 04:25:28PM +0200, Denis Benato wrote:
> Two imu devices bmi160 and bmi270 are similar to bmi323, with the same bug and
> a common usecase: fix the aforementioned bug about triggering not resuming
> after sleep in the same way it was solved for the bmi323 device driver.
> 
> The bmi270 patch has been tested on a device where the device irq pin
> is connected to the CPU ensuring it doesn't cause harm to devices that
> do not use hrtimer or other external triggers.
> 
> Changelog from v1 [1]
> - include linux/pm.h where needed
> - used "Closed" to reference the solved issue for each driver
> - merged two lines into one (on both drivers)

I got this series twice without any (?) difference in the versions. Care to
explain what's going on?


-- 
With Best Regards,
Andy Shevchenko
Re: [PATCH v2 0/2] iio: fix suspend and resume triggering for bmi160 and bmi270
Posted by Denis Benato 6 months, 3 weeks ago
On 5/26/25 21:58, Andy Shevchenko wrote:
> On Sun, May 25, 2025 at 04:25:28PM +0200, Denis Benato wrote:
>> Two imu devices bmi160 and bmi270 are similar to bmi323, with the same bug and
>> a common usecase: fix the aforementioned bug about triggering not resuming
>> after sleep in the same way it was solved for the bmi323 device driver.
>>
>> The bmi270 patch has been tested on a device where the device irq pin
>> is connected to the CPU ensuring it doesn't cause harm to devices that
>> do not use hrtimer or other external triggers.
>>
>> Changelog from v1 [1]
>> - include linux/pm.h where needed
>> - used "Closed" to reference the solved issue for each driver
>> - merged two lines into one (on both drivers)
> I got this series twice without any (?) difference in the versions. Care to
> explain what's going on?
>
>
I am sorry: mails were not being sent to the main lkml nor the iio mailing list and so
I resent to everybody, otherwise doing "answer to all" would have created a mess
where discussions would get lost.
Re: [PATCH v2 0/2] iio: fix suspend and resume triggering for bmi160 and bmi270
Posted by Andy Shevchenko 6 months, 3 weeks ago
On Mon, May 26, 2025 at 10:13:00PM +0200, Denis Benato wrote:
> On 5/26/25 21:58, Andy Shevchenko wrote:
> > On Sun, May 25, 2025 at 04:25:28PM +0200, Denis Benato wrote:
> >> Two imu devices bmi160 and bmi270 are similar to bmi323, with the same bug and
> >> a common usecase: fix the aforementioned bug about triggering not resuming
> >> after sleep in the same way it was solved for the bmi323 device driver.
> >>
> >> The bmi270 patch has been tested on a device where the device irq pin
> >> is connected to the CPU ensuring it doesn't cause harm to devices that
> >> do not use hrtimer or other external triggers.
> >>
> >> Changelog from v1 [1]
> >> - include linux/pm.h where needed
> >> - used "Closed" to reference the solved issue for each driver
> >> - merged two lines into one (on both drivers)
> > I got this series twice without any (?) difference in the versions. Care to
> > explain what's going on?
> >
> I am sorry: mails were not being sent to the main lkml nor the iio mailing list and so
> I resent to everybody, otherwise doing "answer to all" would have created a mess
> where discussions would get lost.

Always mention this kind of things in a cover letter when resending and
ideally add a word 'resend' to the Subject.

-- 
With Best Regards,
Andy Shevchenko
Re: [PATCH v2 0/2] iio: fix suspend and resume triggering for bmi160 and bmi270
Posted by Denis Benato 6 months, 3 weeks ago
On 5/26/25 22:18, Andy Shevchenko wrote:
> On Mon, May 26, 2025 at 10:13:00PM +0200, Denis Benato wrote:
>> On 5/26/25 21:58, Andy Shevchenko wrote:
>>> On Sun, May 25, 2025 at 04:25:28PM +0200, Denis Benato wrote:
>>>> Two imu devices bmi160 and bmi270 are similar to bmi323, with the same bug and
>>>> a common usecase: fix the aforementioned bug about triggering not resuming
>>>> after sleep in the same way it was solved for the bmi323 device driver.
>>>>
>>>> The bmi270 patch has been tested on a device where the device irq pin
>>>> is connected to the CPU ensuring it doesn't cause harm to devices that
>>>> do not use hrtimer or other external triggers.
>>>>
>>>> Changelog from v1 [1]
>>>> - include linux/pm.h where needed
>>>> - used "Closed" to reference the solved issue for each driver
>>>> - merged two lines into one (on both drivers)
>>> I got this series twice without any (?) difference in the versions. Care to
>>> explain what's going on?
>>>
>> I am sorry: mails were not being sent to the main lkml nor the iio mailing list and so
>> I resent to everybody, otherwise doing "answer to all" would have created a mess
>> where discussions would get lost.
> Always mention this kind of things in a cover letter when resending and
> ideally add a word 'resend' to the Subject.
>
Thank you. I wasn't sure if using RESEND was a good idea because I have only read about it being mentioned in
the context of the original being lost and was thinking about the mailing list receiving a RESEND without the original one.
I will keep this in mind for the future, hoping I won't do this silly mistake again.

Thanks for you patience.