This patch adds support for the MT8188 Image System's Local Arbiter
(LARB) in the device tree bindings. The LARB is a crucial component in
MediaTek's ImgSys architecture, responsible for managing memory access
and arbitration between various hardware modules.
Signed-off-by: Olivia Wen <olivia.wen@mediatek.com>
---
.../bindings/media/mediatek,imgsys-larbs.yaml | 75 +++++++++++++++++++
1 file changed, 75 insertions(+)
create mode 100644 Documentation/devicetree/bindings/media/mediatek,imgsys-larbs.yaml
diff --git a/Documentation/devicetree/bindings/media/mediatek,imgsys-larbs.yaml b/Documentation/devicetree/bindings/media/mediatek,imgsys-larbs.yaml
new file mode 100644
index 000000000000..d2966c64ddb6
--- /dev/null
+++ b/Documentation/devicetree/bindings/media/mediatek,imgsys-larbs.yaml
@@ -0,0 +1,75 @@
+# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/media/mediatek,imgsys-larbs.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: LARB Information for MediaTek Camera Image System Hardware
+
+maintainers:
+ - Olivia Wen <olivia.wen@mediatek.com>
+
+description:
+ Detailed configuration for MediaTek Camera Image System's Local Arbiter
+ (LARB) hardware integration.
+
+properties:
+ compatible:
+ enum:
+ - mediatek,mt8188-imgsys-larbs
+
+ iommus:
+ minItems: 1
+ maxItems: 30
+
+ '#address-cells':
+ const: 2
+
+ '#size-cells':
+ const: 2
+
+required:
+ - compatible
+ - iommus
+
+additionalProperties: false
+
+examples:
+ - |
+ #include <dt-bindings/memory/mediatek,mt8188-memory-port.h>
+
+ imgsys-l11b {
+ compatible = "mediatek,mt8188-imgsys-larb";
+ #address-cells = <2>;
+ #size-cells = <2>;
+ iommus = <&vpp_iommu M4U_PORT_L11B_WPE_RDMA_0>,
+ <&vpp_iommu M4U_PORT_L11B_WPE_RDMA_1>,
+ <&vpp_iommu M4U_PORT_L11B_WPE_RDMA_4P_0>,
+ <&vpp_iommu M4U_PORT_L11B_WPE_RDMA_4P_1>,
+ <&vpp_iommu M4U_PORT_L11B_WPE_CQ0>,
+ <&vpp_iommu M4U_PORT_L11B_WPE_CQ1>,
+ <&vpp_iommu M4U_PORT_L11B_PIMGI_P1>,
+ <&vpp_iommu M4U_PORT_L11B_PIMGBI_P1>,
+ <&vpp_iommu M4U_PORT_L11B_PIMGCI_P1>,
+ <&vpp_iommu M4U_PORT_L11B_IMGI_T1_C>,
+ <&vpp_iommu M4U_PORT_L11B_IMGBI_T1_C>,
+ <&vpp_iommu M4U_PORT_L11B_IMGCI_T1_C>,
+ <&vpp_iommu M4U_PORT_L11B_SMTI_T1_C>,
+ <&vpp_iommu M4U_PORT_L11B_SMTI_T4_C>,
+ <&vpp_iommu M4U_PORT_L11B_SMTI_T6_C>,
+ <&vpp_iommu M4U_PORT_L11B_YUVO_T1_C>,
+ <&vpp_iommu M4U_PORT_L11B_YUVBO_T1_C>,
+ <&vpp_iommu M4U_PORT_L11B_YUVCO_T1_C>,
+ <&vpp_iommu M4U_PORT_L11B_WPE_WDMA_0>,
+ <&vpp_iommu M4U_PORT_L11B_WPE_WDMA_4P_0>,
+ <&vpp_iommu M4U_PORT_L11B_WROT_P1>,
+ <&vpp_iommu M4U_PORT_L11B_TCCSO_P1>,
+ <&vpp_iommu M4U_PORT_L11B_TCCSI_P1>,
+ <&vpp_iommu M4U_PORT_L11B_TIMGO_T1_C>,
+ <&vpp_iommu M4U_PORT_L11B_YUVO_T2_C>,
+ <&vpp_iommu M4U_PORT_L11B_YUVO_T5_C>,
+ <&vpp_iommu M4U_PORT_L11B_SMTO_T1_C>,
+ <&vpp_iommu M4U_PORT_L11B_SMTO_T4_C>,
+ <&vpp_iommu M4U_PORT_L11B_SMTO_T6_C>,
+ <&vpp_iommu M4U_PORT_L11B_DBGO_T1_C>;
+ };
--
2.45.2On 24/05/2025 13:49, Olivia Wen wrote:
> This patch adds support for the MT8188 Image System's Local Arbiter
> (LARB) in the device tree bindings. The LARB is a crucial component in
> MediaTek's ImgSys architecture, responsible for managing memory access
> and arbitration between various hardware modules.
>
> Signed-off-by: Olivia Wen <olivia.wen@mediatek.com>
> ---
> .../bindings/media/mediatek,imgsys-larbs.yaml | 75 +++++++++++++++++++
Your patchset wasn't tested, so I won't do full review. Be sure you test
it prior sending. Few nits below:
Please use subject prefixes matching the subsystem. You can get them for
example with `git log --oneline -- DIRECTORY_OR_FILE` on the directory
your patch is touching. For bindings, the preferred subjects are
explained here:
https://www.kernel.org/doc/html/latest/devicetree/bindings/submitting-patches.html#i-for-patch-submitters
> 1 file changed, 75 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/media/mediatek,imgsys-larbs.yaml
>
> diff --git a/Documentation/devicetree/bindings/media/mediatek,imgsys-larbs.yaml b/Documentation/devicetree/bindings/media/mediatek,imgsys-larbs.yaml
> new file mode 100644
> index 000000000000..d2966c64ddb6
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/media/mediatek,imgsys-larbs.yaml
Filename equal to compatible.
> @@ -0,0 +1,75 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/media/mediatek,imgsys-larbs.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: LARB Information for MediaTek Camera Image System Hardware
> +
> +maintainers:
> + - Olivia Wen <olivia.wen@mediatek.com>
> +
> +description:
> + Detailed configuration for MediaTek Camera Image System's Local Arbiter
> + (LARB) hardware integration.
> +
> +properties:
> + compatible:
> + enum:
> + - mediatek,mt8188-imgsys-larbs
> +
> + iommus:
> + minItems: 1
> + maxItems: 30
This cannot be flexible. List the items, unless it is somehow obvious.
> +
> + '#address-cells':
> + const: 2
> +
> + '#size-cells':
> + const: 2
These are useless.
> +
> +required:
> + - compatible
> + - iommus
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + #include <dt-bindings/memory/mediatek,mt8188-memory-port.h>
> +
> + imgsys-l11b {
Node names should be generic. See also an explanation and list of
examples (not exhaustive) in DT specification:
https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation
> + compatible = "mediatek,mt8188-imgsys-larb";
> + #address-cells = <2>;
> + #size-cells = <2>;
Why?
> + iommus = <&vpp_iommu M4U_PORT_L11B_WPE_RDMA_0>,
> + <&vpp_iommu M4U_PORT_L11B_WPE_RDMA_1>,
Fix alignment.
Best regards,
Krzysztof
On Sat, 24 May 2025 19:49:54 +0800, Olivia Wen wrote: > This patch adds support for the MT8188 Image System's Local Arbiter > (LARB) in the device tree bindings. The LARB is a crucial component in > MediaTek's ImgSys architecture, responsible for managing memory access > and arbitration between various hardware modules. > > Signed-off-by: Olivia Wen <olivia.wen@mediatek.com> > --- > .../bindings/media/mediatek,imgsys-larbs.yaml | 75 +++++++++++++++++++ > 1 file changed, 75 insertions(+) > create mode 100644 Documentation/devicetree/bindings/media/mediatek,imgsys-larbs.yaml > My bot found errors running 'make dt_binding_check' on your patch: yamllint warnings/errors: dtschema/dtc warnings/errors: Documentation/devicetree/bindings/media/mediatek,imgsys-larbs.example.dtb: /example-0/imgsys-l11b: failed to match any schema with compatible: ['mediatek,mt8188-imgsys-larb'] doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20250524115144.3832748-3-olivia.wen@mediatek.com The base for the series is generally the latest rc1. A different dependency should be noted in *this* patch. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit after running the above command yourself. Note that DT_SCHEMA_FILES can be set to your schema file to speed up checking your schema. However, it must be unset to test all examples with your schema.
© 2016 - 2025 Red Hat, Inc.