[PATCH] soundwire: intel_ace2.x: Use str_read_write() helper

long.yunjian@zte.com.cn posted 1 patch 6 months, 3 weeks ago
drivers/soundwire/intel_ace2x.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
[PATCH] soundwire: intel_ace2.x: Use str_read_write() helper
Posted by long.yunjian@zte.com.cn 6 months, 3 weeks ago
From: Yumeng Fang <fang.yumeng@zte.com.cn>

Remove hard-coded strings by using the str_read_write() helper.

Signed-off-by: Yumeng Fang <fang.yumeng@zte.com.cn>
Signed-off-by: Yunjian Long <long.yunjian@zte.com.cn>
---
 drivers/soundwire/intel_ace2x.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/soundwire/intel_ace2x.c b/drivers/soundwire/intel_ace2x.c
index 5b31e1f69591..7e893e4f48d6 100644
--- a/drivers/soundwire/intel_ace2x.c
+++ b/drivers/soundwire/intel_ace2x.c
@@ -11,6 +11,7 @@
 #include <linux/soundwire/sdw_registers.h>
 #include <linux/soundwire/sdw.h>
 #include <linux/soundwire/sdw_intel.h>
+#include <linux/string_choices.h>
 #include <sound/hdaudio.h>
 #include <sound/hda-mlink.h>
 #include <sound/hda-sdw-bpt.h>
@@ -183,7 +184,7 @@ static int intel_ace2x_bpt_open_stream(struct sdw_intel *sdw, struct sdw_slave *
 		return 0;

 	dev_err(cdns->dev, "%s: sdw_prepare_%s_dma_buffer failed %d\n",
-		__func__, command ? "read" : "write", ret);
+		__func__, str_read_write(command), ret);

 	ret1 = hda_sdw_bpt_close(cdns->dev->parent, /* PCI device */
 				 sdw->bpt_ctx.bpt_tx_stream, &sdw->bpt_ctx.dmab_tx_bdl,
-- 
2.25.1
Re: [PATCH] soundwire: intel_ace2.x: Use str_read_write() helper
Posted by Vinod Koul 6 months, 1 week ago
On Fri, 23 May 2025 14:19:10 +0800, long.yunjian@zte.com.cn wrote:
> Remove hard-coded strings by using the str_read_write() helper.
> 
> 

Applied, thanks!

[1/1] soundwire: intel_ace2.x: Use str_read_write() helper
      commit: fdf5596103455c62ab84293ddd95d9bf16f6519a

Best regards,
-- 
~Vinod
Re: [PATCH] soundwire: intel_ace2.x: Use str_read_write() helper
Posted by Liao, Bard 6 months, 3 weeks ago

On 5/23/2025 2:19 PM, long.yunjian@zte.com.cn wrote:
> From: Yumeng Fang <fang.yumeng@zte.com.cn>
> 
> Remove hard-coded strings by using the str_read_write() helper.
> 
> Signed-off-by: Yumeng Fang <fang.yumeng@zte.com.cn>
> Signed-off-by: Yunjian Long <long.yunjian@zte.com.cn>
Reviewed-by: Bard Liao <yung-chuan.liao@linux.intel.com>