Add my self as maintainer of the allegrodvt Gen drivers
Signed-off-by: Yassine Ouaissa <yassine.ouaissa@allegrodvt.com>
---
MAINTAINERS | 1 +
1 file changed, 1 insertion(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index e59011a36e6b..9285bb2f43d9 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -802,6 +802,7 @@ F: drivers/platform/x86/dell/alienware-wmi*
ALLEGRO DVT VIDEO IP CORE DRIVER
M: Michael Tretter <m.tretter@pengutronix.de>
+M: Yassine OUAISSA <yassine.ouaissa@allegrodvt.com>
R: Pengutronix Kernel Team <kernel@pengutronix.de>
L: linux-media@vger.kernel.org
S: Maintained
--
2.30.2Hi Yassine, Le vendredi 23 mai 2025 à 15:41 +0200, Yassine Ouaissa a écrit : > Add my self as maintainer of the allegrodvt Gen drivers > > Signed-off-by: Yassine Ouaissa <yassine.ouaissa@allegrodvt.com> > --- > MAINTAINERS | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/MAINTAINERS b/MAINTAINERS > index e59011a36e6b..9285bb2f43d9 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -802,6 +802,7 @@ F: drivers/platform/x86/dell/alienware-wmi* > > ALLEGRO DVT VIDEO IP CORE DRIVER > M: Michael Tretter <m.tretter@pengutronix.de> > +M: Yassine OUAISSA <yassine.ouaissa@allegrodvt.com> > R: Pengutronix Kernel Team <kernel@pengutronix.de> > L: linux-media@vger.kernel.org > S: Maintained Be aware that I do not endorse Krzysztof style of communication, and this does not reflect Linux Media values. We strongly encourage both new comers and contributions coming from the hardware companies. Please, don't get discourage, simply focus on the facts and the way forward. DT maintainers don't usually deal with pre-silicon drivers, so we'll have to see what this means for bindings. But having drivers contributed before the hardware is a clear win for the Linux kernel, so we should all encourage this and find a way. In general, don't assume any of the above is known and document it. Its quite possible your reviewers so far have been thinking this driver is for existing hardware already running in a known SoC. They cannot guess, you have to make things really clear and transparent. Meanwhile, a better approach to maintenance, and the one I expected initially, is to place yourself under Michael in the hierarchy, and remove yourself from the bindings path. Bindings should really come from the SoC vendor in practice, so perhaps we should not provide a generic one. Hopefully we can get proper feedback from DT maintainers on that aspect. I'd like to see a focus move onto the driver code, which is at this stage much more important. In parallel, spend time to re-read the guidelines for submissions and check some automation tools. 'b4' is really my goto, and will help you avoid some of the common mistakes. regards, Nicolas
On 25.05.2025 17:50, Nicolas Dufresne wrote: >Hi Yassine, > >Le vendredi 23 mai 2025 à 15:41 +0200, Yassine Ouaissa a écrit : >> Add my self as maintainer of the allegrodvt Gen drivers >> >> Signed-off-by: Yassine Ouaissa <yassine.ouaissa@allegrodvt.com> >> --- >> MAINTAINERS | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/MAINTAINERS b/MAINTAINERS >> index e59011a36e6b..9285bb2f43d9 100644 >> --- a/MAINTAINERS >> +++ b/MAINTAINERS >> @@ -802,6 +802,7 @@ F: drivers/platform/x86/dell/alienware-wmi* >> >> ALLEGRO DVT VIDEO IP CORE DRIVER >> M: Michael Tretter <m.tretter@pengutronix.de> >> +M: Yassine OUAISSA <yassine.ouaissa@allegrodvt.com> >> R: Pengutronix Kernel Team <kernel@pengutronix.de> >> L: linux-media@vger.kernel.org >> S: Maintained > >Be aware that I do not endorse Krzysztof style of communication, and this >does not reflect Linux Media values. We strongly encourage both new comers and >contributions coming from the hardware companies. Please, don't get discourage, >simply focus on the facts and the way forward. DT maintainers don't usually deal >with pre-silicon drivers, so we'll have to see what this means for >bindings. But having drivers contributed before the hardware is a clear win >for the Linux kernel, so we should all encourage this and find a way. Hi Nicolas, Thank you for your support. I already informe Krzysztof by email, that i have not make a good approach with the previous patches, and i will send a new set of patches to start cleanly. And also i informed the linux-media community, and they was "OK" with that. > >In general, don't assume any of the above is known and document it. Its quite possible >your reviewers so far have been thinking this driver is for existing hardware already >running in a known SoC. They cannot guess, you have to make things really clear and >transparent. > >Meanwhile, a better approach to maintenance, and the one I expected initially, is to >place yourself under Michael in the hierarchy, and remove yourself from the bindings >path. Bindings should really come from the SoC vendor in practice, so perhaps we should >not provide a generic one. Hopefully we can get proper feedback from DT maintainers on >that aspect. right, the al300-vdec dt-bindings is a generic one that the soc vendors should follow for the specific driver. > >I'd like to see a focus move onto the driver code, which is at this stage much more >important. In parallel, spend time to re-read the guidelines for submissions and >check some automation tools. 'b4' is really my goto, and will help you avoid some >of the common mistakes. thank you for the tool, and also for the review. > >regards, >Nicolas > > > Best regards, Yassine OUAISSA
On 23/05/2025 15:41, Yassine Ouaissa wrote: > Add my self as maintainer of the allegrodvt Gen drivers > > Signed-off-by: Yassine Ouaissa <yassine.ouaissa@allegrodvt.com> > --- > MAINTAINERS | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/MAINTAINERS b/MAINTAINERS > index e59011a36e6b..9285bb2f43d9 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -802,6 +802,7 @@ F: drivers/platform/x86/dell/alienware-wmi* > > ALLEGRO DVT VIDEO IP CORE DRIVER > M: Michael Tretter <m.tretter@pengutronix.de> > +M: Yassine OUAISSA <yassine.ouaissa@allegrodvt.com> I already disagreed. I commented on this and nothing improved. I provided arguments that you do not know the process, thus you need to first read the docs. THEN you sent it again still not reading the docs and not learning anything here from previous comments. You sent four times the same version, ignoring review and not understanding basic versioning concept. You need to first understand how the process works, what is a bug report, what is the review process, what is the reviewer's statement of oversight. I suggest sending several patches and contributions prior asking to be maintainer. So still disagree, but this is now disappointing: NAK Best regards, Krzysztof
On 25.05.2025 06:40, Krzysztof Kozlowski wrote: >On 23/05/2025 15:41, Yassine Ouaissa wrote: >> Add my self as maintainer of the allegrodvt Gen drivers >> >> Signed-off-by: Yassine Ouaissa <yassine.ouaissa@allegrodvt.com> >> --- >> MAINTAINERS | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/MAINTAINERS b/MAINTAINERS >> index e59011a36e6b..9285bb2f43d9 100644 >> --- a/MAINTAINERS >> +++ b/MAINTAINERS >> @@ -802,6 +802,7 @@ F: drivers/platform/x86/dell/alienware-wmi* >> >> ALLEGRO DVT VIDEO IP CORE DRIVER >> M: Michael Tretter <m.tretter@pengutronix.de> >> +M: Yassine OUAISSA <yassine.ouaissa@allegrodvt.com> >I already disagreed. I commented on this and nothing improved. I >provided arguments that you do not know the process, thus you need to >first read the docs. > >THEN you sent it again still not reading the docs and not learning >anything here from previous comments. > >You sent four times the same version, ignoring review and not >understanding basic versioning concept. > Again, I do not ignore anyone reviews. This set of patches is to start cleanly, and to focus on creating the v1...vX patches. Your previous previews will be applied in the next version. Best regards, Yassine OUAISSA >You need to first understand how the process works, what is a bug >report, what is the review process, what is the reviewer's statement of >oversight. I suggest sending several patches and contributions prior >asking to be maintainer. > >So still disagree, but this is now disappointing: NAK > >Best regards, >Krzysztof
© 2016 - 2025 Red Hat, Inc.