[PATCH 6/7] phy: phy-snps-eusb2: drop unnecessary loop index declarations

Johan Hovold posted 7 patches 6 months, 3 weeks ago
[PATCH 6/7] phy: phy-snps-eusb2: drop unnecessary loop index declarations
Posted by Johan Hovold 6 months, 3 weeks ago
There is already a loop index variable declared at function scope so
drop the unnecessary overloaded loop declarations.

Signed-off-by: Johan Hovold <johan+linaro@kernel.org>
---
 drivers/phy/phy-snps-eusb2.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/phy/phy-snps-eusb2.c b/drivers/phy/phy-snps-eusb2.c
index 328e67ebfe03..c67712bd8bba 100644
--- a/drivers/phy/phy-snps-eusb2.c
+++ b/drivers/phy/phy-snps-eusb2.c
@@ -552,7 +552,7 @@ static int snps_eusb2_hsphy_probe(struct platform_device *pdev)
 	if (!phy->clks)
 		return -ENOMEM;
 
-	for (int i = 0; i < phy->data->num_clks; ++i)
+	for (i = 0; i < phy->data->num_clks; ++i)
 		phy->clks[i].id = phy->data->clk_names[i];
 
 	ret = devm_clk_bulk_get(dev, phy->data->num_clks, phy->clks);
@@ -561,7 +561,7 @@ static int snps_eusb2_hsphy_probe(struct platform_device *pdev)
 				     "failed to get phy clock(s)\n");
 
 	phy->ref_clk = NULL;
-	for (int i = 0; i < phy->data->num_clks; ++i) {
+	for (i = 0; i < phy->data->num_clks; ++i) {
 		if (!strcmp(phy->clks[i].id, "ref")) {
 			phy->ref_clk = phy->clks[i].clk;
 			break;
-- 
2.49.0
Re: [PATCH 6/7] phy: phy-snps-eusb2: drop unnecessary loop index declarations
Posted by neil.armstrong@linaro.org 6 months, 3 weeks ago
On 23/05/2025 10:48, Johan Hovold wrote:
> There is already a loop index variable declared at function scope so
> drop the unnecessary overloaded loop declarations.
> 
> Signed-off-by: Johan Hovold <johan+linaro@kernel.org>
> ---
>   drivers/phy/phy-snps-eusb2.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/phy/phy-snps-eusb2.c b/drivers/phy/phy-snps-eusb2.c
> index 328e67ebfe03..c67712bd8bba 100644
> --- a/drivers/phy/phy-snps-eusb2.c
> +++ b/drivers/phy/phy-snps-eusb2.c
> @@ -552,7 +552,7 @@ static int snps_eusb2_hsphy_probe(struct platform_device *pdev)
>   	if (!phy->clks)
>   		return -ENOMEM;
>   
> -	for (int i = 0; i < phy->data->num_clks; ++i)
> +	for (i = 0; i < phy->data->num_clks; ++i)
>   		phy->clks[i].id = phy->data->clk_names[i];
>   
>   	ret = devm_clk_bulk_get(dev, phy->data->num_clks, phy->clks);
> @@ -561,7 +561,7 @@ static int snps_eusb2_hsphy_probe(struct platform_device *pdev)
>   				     "failed to get phy clock(s)\n");
>   
>   	phy->ref_clk = NULL;
> -	for (int i = 0; i < phy->data->num_clks; ++i) {
> +	for (i = 0; i < phy->data->num_clks; ++i) {
>   		if (!strcmp(phy->clks[i].id, "ref")) {
>   			phy->ref_clk = phy->clks[i].clk;
>   			break;

Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>