[v4] i2c: lpi2c: implement master_xfer_atomic callback

[PATCH v4 0/2] i2c: lpi2c: implement master_xfer_atomic callback

Posted by Francesco Dolcini 6 months, 3 weeks ago

From: Francesco Dolcini <francesco.dolcini@toradex.com>

This series adds atomic operations support to the imx-lpi2c driver and split
the previous v3 patch into two separate patches.

The first patch replaces the open-coded polling loops with readl_poll_timeout.
This improves readability and consistency, and prepares the code for
integration of the second patch, while maintaining the same functionality.

The second patch implements the .master_xfer_atomic() callback, enabling
support for atomic I2C transfers.

Emanuele Ghidoli (2):
  i2c: lpi2c: use readl_poll_timeout() for register polling
  i2c: lpi2c: implement master_xfer_atomic callback

 drivers/i2c/busses/i2c-imx-lpi2c.c | 262 +++++++++++++++++++----------
 1 file changed, 176 insertions(+), 86 deletions(-)

-- 
2.39.5

Re: [PATCH v4 0/2] i2c: lpi2c: implement master_xfer_atomic callback

Posted by Francesco Dolcini 5 months, 2 weeks ago

Hello,

On Fri, May 23, 2025 at 10:29:29AM +0200, Francesco Dolcini wrote:
> From: Francesco Dolcini <francesco.dolcini@toradex.com>
> 
> This series adds atomic operations support to the imx-lpi2c driver and split
> the previous v3 patch into two separate patches.
> 
> The first patch replaces the open-coded polling loops with readl_poll_timeout.
> This improves readability and consistency, and prepares the code for
> integration of the second patch, while maintaining the same functionality.
> 
> The second patch implements the .master_xfer_atomic() callback, enabling
> support for atomic I2C transfers.

Just a gentle ping to not forget about this.

Francesco

Re: [PATCH v4 0/2] i2c: lpi2c: implement master_xfer_atomic callback

Posted by Primoz Fiser 5 months ago

On 26. 06. 25 09:58, Francesco Dolcini wrote:
> Hello,
>
> On Fri, May 23, 2025 at 10:29:29AM +0200, Francesco Dolcini wrote:
>> From: Francesco Dolcini <francesco.dolcini@toradex.com>
>>
>> This series adds atomic operations support to the imx-lpi2c driver and split
>> the previous v3 patch into two separate patches.
>>
>> The first patch replaces the open-coded polling loops with readl_poll_timeout.
>> This improves readability and consistency, and prepares the code for
>> integration of the second patch, while maintaining the same functionality.
>>
>> The second patch implements the .master_xfer_atomic() callback, enabling
>> support for atomic I2C transfers.
> Just a gentle ping to not forget about this.
>
> Francesco
>
Hi Francesco,

just a heads-up that this needs rebase on latest linux-next due to
commit 614b1c3cbfb0 ("i2c: use inclusive callbacks in struct
i2c_algorithm").

Afterwards, I was able to test functionality on PHYTEC
phyBOARD-Nash-i.MX93 and you can add my:

Tested-by: Primoz Fiser <primoz.fiser@norik.com>

for your v5 if you want.

BR,

Primoz

-- 
Primoz Fiser
phone: +386-41-390-545
email: primoz.fiser@norik.com
--
Norik systems d.o.o.
Your embedded software partner
Slovenia, EU
phone: +386-41-540-545
email: info@norik.com