[PATCH v2] kselftest: x86: Improve MOV SS test result message

Brigham Campbell posted 1 patch 6 months, 3 weeks ago
There is a newer version of this series
tools/testing/selftests/x86/mov_ss_trap.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
[PATCH v2] kselftest: x86: Improve MOV SS test result message
Posted by Brigham Campbell 6 months, 3 weeks ago
Apparently, this test completes successfully when it completes execution
without either causing a kernel panic or being killed by the kernel.
This new test result message is more descriptive and grammatically
correct.

There are no changes in v2. I'm resending this patch because I addressed
it to the wrong email for Shuah.

Signed-off-by: Brigham Campbell <me@brighamcampbell.com>
---
 tools/testing/selftests/x86/mov_ss_trap.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/testing/selftests/x86/mov_ss_trap.c b/tools/testing/selftests/x86/mov_ss_trap.c
index f22cb6b382f9..d80033c0d7eb 100644
--- a/tools/testing/selftests/x86/mov_ss_trap.c
+++ b/tools/testing/selftests/x86/mov_ss_trap.c
@@ -269,6 +269,6 @@ int main()
 			);
 	}
 
-	printf("[OK]\tI aten't dead\n");
+	printf("[OK]\tkernel handled MOV SS without crashing test\n");
 	return 0;
 }
-- 
2.49.0
Re: [PATCH v2] kselftest: x86: Improve MOV SS test result message
Posted by Shuah Khan 6 months, 3 weeks ago
On 5/23/25 01:32, Brigham Campbell wrote:
> Apparently, this test completes successfully when it completes execution
> without either causing a kernel panic or being killed by the kernel.
> This new test result message is more descriptive and grammatically
> correct.
> 

The change log description usually is in imperative - e.g:

"Change test result message to be more descriptive and grammatically
correct.."


> There are no changes in v2. I'm resending this patch because I addressed
> it to the wrong email for Shuah.

Version change information goes under the --- after the Signed-off-by

> 
> Signed-off-by: Brigham Campbell <me@brighamcampbell.com>
> ---
>   tools/testing/selftests/x86/mov_ss_trap.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/testing/selftests/x86/mov_ss_trap.c b/tools/testing/selftests/x86/mov_ss_trap.c
> index f22cb6b382f9..d80033c0d7eb 100644
> --- a/tools/testing/selftests/x86/mov_ss_trap.c
> +++ b/tools/testing/selftests/x86/mov_ss_trap.c
> @@ -269,6 +269,6 @@ int main()
>   			);
>   	}
>   
> -	printf("[OK]\tI aten't dead\n");
> +	printf("[OK]\tkernel handled MOV SS without crashing test\n");
>   	return 0;
>   }

thanks,
-- Shuah