These are for the wireless chips that come built in with various
Atheros/QCA SoCs. dts wise, the difference between pcie and the wmac is
AHB > PCIE > WIFI
AHB > WIFI
These will be used to replace the platform_device code with OF in the
following patch.
Signed-off-by: Rosen Penev <rosenp@gmail.com>
---
.../bindings/net/wireless/qca,ath9k.yaml | 20 ++++++++++++++++++-
1 file changed, 19 insertions(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/net/wireless/qca,ath9k.yaml b/Documentation/devicetree/bindings/net/wireless/qca,ath9k.yaml
index 0e5412cff2bc..af2d01d3df23 100644
--- a/Documentation/devicetree/bindings/net/wireless/qca,ath9k.yaml
+++ b/Documentation/devicetree/bindings/net/wireless/qca,ath9k.yaml
@@ -12,7 +12,7 @@ maintainers:
description: |
This node provides properties for configuring the ath9k wireless device.
The node is expected to be specified as a child node of the PCI controller
- to which the wireless chip is connected.
+ or AHB bus to which the wireless chip is connected.
allOf:
- $ref: ieee80211.yaml#
@@ -35,6 +35,12 @@ properties:
- pci168c,0034 # AR9462
- pci168c,0036 # AR9565
- pci168c,0037 # AR1111 and AR9485
+ - qcom,ar9130-wifi
+ - qcom,ar9330-wifi
+ - qcom,ar9340-wifi
+ - qcom,qca9530-wifi
+ - qcom,qca9550-wifi
+ - qcom,qca9560-wifi
reg:
maxItems: 1
@@ -88,3 +94,15 @@ examples:
nvmem-cell-names = "mac-address", "calibration";
};
};
+ - |
+ ahb {
+ compatible = "simple-bus";
+ ranges;
+
+ wifi@180c0000 {
+ compatible = "qca,ar9130-wifi";
+ reg = <0x180c0000 0x230000>;
+
+ interrupts = <2>;
+ };
+ };
--
2.49.0On Thu, 22 May 2025 23:32:05 -0700, Rosen Penev wrote: > These are for the wireless chips that come built in with various > Atheros/QCA SoCs. dts wise, the difference between pcie and the wmac is > > AHB > PCIE > WIFI > AHB > WIFI > > These will be used to replace the platform_device code with OF in the > following patch. > > Signed-off-by: Rosen Penev <rosenp@gmail.com> > --- > .../bindings/net/wireless/qca,ath9k.yaml | 20 ++++++++++++++++++- > 1 file changed, 19 insertions(+), 1 deletion(-) > My bot found errors running 'make dt_binding_check' on your patch: yamllint warnings/errors: dtschema/dtc warnings/errors: Documentation/devicetree/bindings/net/wireless/qca,ath9k.example.dts:90.13-41: Warning (reg_format): /example-2/ahb/wifi@180c0000:reg: property has invalid length (8 bytes) (#address-cells == 2, #size-cells == 1) Documentation/devicetree/bindings/net/wireless/qca,ath9k.example.dts:86.11-18: Warning (ranges_format): /example-2/ahb:ranges: empty "ranges" property but its #address-cells (2) differs from /example-2 (1) Documentation/devicetree/bindings/net/wireless/qca,ath9k.example.dtb: Warning (pci_device_reg): Failed prerequisite 'reg_format' Documentation/devicetree/bindings/net/wireless/qca,ath9k.example.dtb: Warning (pci_device_bus_num): Failed prerequisite 'reg_format' Documentation/devicetree/bindings/net/wireless/qca,ath9k.example.dtb: Warning (simple_bus_reg): Failed prerequisite 'reg_format' Documentation/devicetree/bindings/net/wireless/qca,ath9k.example.dtb: Warning (i2c_bus_reg): Failed prerequisite 'reg_format' Documentation/devicetree/bindings/net/wireless/qca,ath9k.example.dtb: Warning (spi_bus_reg): Failed prerequisite 'reg_format' Documentation/devicetree/bindings/net/wireless/qca,ath9k.example.dts:88.25-93.13: Warning (avoid_default_addr_size): /example-2/ahb/wifi@180c0000: Relying on default #address-cells value Documentation/devicetree/bindings/net/wireless/qca,ath9k.example.dts:88.25-93.13: Warning (avoid_default_addr_size): /example-2/ahb/wifi@180c0000: Relying on default #size-cells value Documentation/devicetree/bindings/net/wireless/qca,ath9k.example.dtb: Warning (unique_unit_address_if_enabled): Failed prerequisite 'avoid_default_addr_size' /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/net/wireless/qca,ath9k.example.dtb: ahb (simple-bus): '#address-cells' is a required property from schema $id: http://devicetree.org/schemas/simple-bus.yaml# /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/net/wireless/qca,ath9k.example.dtb: ahb (simple-bus): '#size-cells' is a required property from schema $id: http://devicetree.org/schemas/simple-bus.yaml# Documentation/devicetree/bindings/net/wireless/qca,ath9k.example.dtb: /example-2/ahb/wifi@180c0000: failed to match any schema with compatible: ['qca,ar9130-wifi'] doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20250523063207.10040-4-rosenp@gmail.com The base for the series is generally the latest rc1. A different dependency should be noted in *this* patch. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit after running the above command yourself. Note that DT_SCHEMA_FILES can be set to your schema file to speed up checking your schema. However, it must be unset to test all examples with your schema.
On 23/05/2025 08:32, Rosen Penev wrote:
> reg:
> maxItems: 1
> @@ -88,3 +94,15 @@ examples:
> nvmem-cell-names = "mac-address", "calibration";
> };
> };
> + - |
> + ahb {
> + compatible = "simple-bus";
> + ranges;
Not much improved... Code is now actually wrong. Remember to notice
where the comments appear. We are using here mailing list style of
communication.
In any case: 1 patchset per 24h.
Best regards,
Krzysztof
On Thu, May 22, 2025 at 11:43 PM Krzysztof Kozlowski <krzk@kernel.org> wrote:
>
> On 23/05/2025 08:32, Rosen Penev wrote:
> > reg:
> > maxItems: 1
> > @@ -88,3 +94,15 @@ examples:
> > nvmem-cell-names = "mac-address", "calibration";
> > };
> > };
> > + - |
> > + ahb {
> > + compatible = "simple-bus";
> > + ranges;
>
> Not much improved... Code is now actually wrong. Remember to notice
> where the comments appear. We are using here mailing list style of
> communication.
Will fix. I ran make dt_binding_check just to make sure. The example's
compatible is also wrong. Will fix as well.
>
> In any case: 1 patchset per 24h.
Ah right. Apologies.
>
>
>
> Best regards,
> Krzysztof
© 2016 - 2025 Red Hat, Inc.