[v1] f2fs: enable tuning of boost_zoned_gc_percent via sysfs

[PATCH] f2fs: enable tuning of boost_zoned_gc_percent via sysfs

Posted by yohan.joung 6 months, 3 weeks ago

to allow users to dynamically tune
the boost_zoned_gc_percent parameter

Signed-off-by: yohan.joung <yohan.joung@sk.com>
---
 fs/f2fs/gc.h | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/fs/f2fs/gc.h b/fs/f2fs/gc.h
index 5c1eaf55e127..f9ff68dc2bcc 100644
--- a/fs/f2fs/gc.h
+++ b/fs/f2fs/gc.h
@@ -194,6 +194,8 @@ static inline bool has_enough_invalid_blocks(struct f2fs_sb_info *sbi)
 static inline bool need_to_boost_gc(struct f2fs_sb_info *sbi)
 {
 	if (f2fs_sb_has_blkzoned(sbi))
-		return !has_enough_free_blocks(sbi, LIMIT_BOOST_ZONED_GC);
+		return !has_enough_free_blocks(sbi,
+			sbi->gc_thread->boost_zoned_gc_percent < 100
+			? sbi->gc_thread->boost_zoned_gc_percent : 100);
 	return has_enough_invalid_blocks(sbi);
 }
-- 
2.33.0

Re: [PATCH] f2fs: enable tuning of boost_zoned_gc_percent via sysfs

Posted by Chao Yu 6 months, 3 weeks ago

On 5/23/25 08:21, yohan.joung wrote:
> to allow users to dynamically tune
> the boost_zoned_gc_percent parameter
> 
> Signed-off-by: yohan.joung <yohan.joung@sk.com>
> ---
>  fs/f2fs/gc.h | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/fs/f2fs/gc.h b/fs/f2fs/gc.h
> index 5c1eaf55e127..f9ff68dc2bcc 100644
> --- a/fs/f2fs/gc.h
> +++ b/fs/f2fs/gc.h
> @@ -194,6 +194,8 @@ static inline bool has_enough_invalid_blocks(struct f2fs_sb_info *sbi)
>  static inline bool need_to_boost_gc(struct f2fs_sb_info *sbi)
>  {
>  	if (f2fs_sb_has_blkzoned(sbi))
> -		return !has_enough_free_blocks(sbi, LIMIT_BOOST_ZONED_GC);
> +		return !has_enough_free_blocks(sbi,
> +			sbi->gc_thread->boost_zoned_gc_percent < 100
> +			? sbi->gc_thread->boost_zoned_gc_percent : 100);

How about checking lower/upper boundary for boost_zoned_gc_percent
during setting its value via sysfs? Also update the manual page?

Then we can use sbi->gc_thread->boost_zoned_gc_percent directly here?

Thanks,

>  	return has_enough_invalid_blocks(sbi);
>  }