Grab IPA IMEM slice through DT, part 2

[PATCH 04/10] arm64: dts: qcom: sc7180: Explicitly describe the IPA IMEM slice

Posted by Konrad Dybcio 6 months, 3 weeks ago

From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>

As part of stepping away from crazy hardcoding in the driver, move
define the slice explicitly and pass it to the IPA node.

Signed-off-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
---
 arch/arm64/boot/dts/qcom/sc7180.dtsi | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/sc7180.dtsi b/arch/arm64/boot/dts/qcom/sc7180.dtsi
index 3afb69921be363bd35a996bc1d6f70ff007c6af8..84b032dc09d36e56eeaf182125cceb44e7333765 100644
--- a/arch/arm64/boot/dts/qcom/sc7180.dtsi
+++ b/arch/arm64/boot/dts/qcom/sc7180.dtsi
@@ -1640,6 +1640,8 @@ ipa: ipa@1e40000 {
 			qcom,smem-state-names = "ipa-clock-enabled-valid",
 						"ipa-clock-enabled";
 
+			sram = <&ipa_modem_tables>;
+
 			status = "disabled";
 		};
 
@@ -3535,6 +3537,10 @@ sram@14680000 {
 
 			ranges = <0 0 0x14680000 0x2e000>;
 
+			ipa_modem_tables: modem-tables@28000 {
+				reg = <0x28000 0x2000>;
+			};
+
 			pil-reloc@2a94c {
 				compatible = "qcom,pil-reloc-info";
 				reg = <0x2a94c 0xc8>;

-- 
2.49.0

Re: [PATCH 04/10] arm64: dts: qcom: sc7180: Explicitly describe the IPA IMEM slice

Posted by Bjorn Andersson 3 months, 2 weeks ago

On Fri, May 23, 2025 at 01:18:19AM +0200, Konrad Dybcio wrote:
> From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
> 
> As part of stepping away from crazy hardcoding in the driver, move
> define the slice explicitly and pass it to the IPA node.
> 
> Signed-off-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
> ---
>  arch/arm64/boot/dts/qcom/sc7180.dtsi | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/qcom/sc7180.dtsi b/arch/arm64/boot/dts/qcom/sc7180.dtsi
> index 3afb69921be363bd35a996bc1d6f70ff007c6af8..84b032dc09d36e56eeaf182125cceb44e7333765 100644
> --- a/arch/arm64/boot/dts/qcom/sc7180.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sc7180.dtsi
> @@ -1640,6 +1640,8 @@ ipa: ipa@1e40000 {
>  			qcom,smem-state-names = "ipa-clock-enabled-valid",
>  						"ipa-clock-enabled";
>  
> +			sram = <&ipa_modem_tables>;

Please resubmit the second half of this series, once sram is an accepted
property.

Thanks,
Bjorn

> +
>  			status = "disabled";
>  		};
>  
> @@ -3535,6 +3537,10 @@ sram@14680000 {
>  
>  			ranges = <0 0 0x14680000 0x2e000>;
>  
> +			ipa_modem_tables: modem-tables@28000 {
> +				reg = <0x28000 0x2000>;
> +			};
> +
>  			pil-reloc@2a94c {
>  				compatible = "qcom,pil-reloc-info";
>  				reg = <0x2a94c 0xc8>;
> 
> -- 
> 2.49.0
>

Re: [PATCH 04/10] arm64: dts: qcom: sc7180: Explicitly describe the IPA IMEM slice

Posted by Dmitry Baryshkov 6 months, 3 weeks ago

On Fri, May 23, 2025 at 01:18:19AM +0200, Konrad Dybcio wrote:
> From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
> 
> As part of stepping away from crazy hardcoding in the driver, move
> define the slice explicitly and pass it to the IPA node.
> 
> Signed-off-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
> ---
>  arch/arm64/boot/dts/qcom/sc7180.dtsi | 6 ++++++
>  1 file changed, 6 insertions(+)
> 

Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>

-- 
With best wishes
Dmitry