Grab IPA IMEM slice through DT, part 2

[PATCH 02/10] arm64: dts: qcom: sdm845: Expand IMEM region

Posted by Konrad Dybcio 6 months, 3 weeks ago

From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>

We need more than what is currently described, expand the region to its
actual boundaries.

Signed-off-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
---
 arch/arm64/boot/dts/qcom/sdm845.dtsi | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/arch/arm64/boot/dts/qcom/sdm845.dtsi b/arch/arm64/boot/dts/qcom/sdm845.dtsi
index 3bc8471c658bda987d6fcff3359d63b367148e89..6ee97cfecc705c317164fbba8df426f6be52e932 100644
--- a/arch/arm64/boot/dts/qcom/sdm845.dtsi
+++ b/arch/arm64/boot/dts/qcom/sdm845.dtsi
@@ -5081,18 +5081,18 @@ spmi_bus: spmi@c440000 {
 			#interrupt-cells = <4>;
 		};
 
-		sram@146bf000 {
+		sram@14680000 {
 			compatible = "qcom,sdm845-imem", "syscon", "simple-mfd";
-			reg = <0 0x146bf000 0 0x1000>;
+			reg = <0 0x14680000 0 0x40000>;
 
 			#address-cells = <1>;
 			#size-cells = <1>;
 
-			ranges = <0 0 0x146bf000 0x1000>;
+			ranges = <0 0 0x14680000 0x40000>;
 
-			pil-reloc@94c {
+			pil-reloc@3f94c {
 				compatible = "qcom,pil-reloc-info";
-				reg = <0x94c 0xc8>;
+				reg = <0x3f94c 0xc8>;
 			};
 		};
 

-- 
2.49.0

Re: [PATCH 02/10] arm64: dts: qcom: sdm845: Expand IMEM region

Posted by Dmitry Baryshkov 6 months, 3 weeks ago

On Fri, May 23, 2025 at 01:18:17AM +0200, Konrad Dybcio wrote:
> From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
> 
> We need more than what is currently described, expand the region to its
> actual boundaries.
> 
> Signed-off-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
> ---
>  arch/arm64/boot/dts/qcom/sdm845.dtsi | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)

Fixes: 948f6161c6ab ("arm64: dts: qcom: sdm845: Add IMEM and PIL info region")

BTW, are you sure about the address? msm-4.9 agrees with the current
one.

> diff --git a/arch/arm64/boot/dts/qcom/sdm845.dtsi b/arch/arm64/boot/dts/qcom/sdm845.dtsi
> index 3bc8471c658bda987d6fcff3359d63b367148e89..6ee97cfecc705c317164fbba8df426f6be52e932 100644
> --- a/arch/arm64/boot/dts/qcom/sdm845.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sdm845.dtsi
> @@ -5081,18 +5081,18 @@ spmi_bus: spmi@c440000 {
>  			#interrupt-cells = <4>;
>  		};
>  
> -		sram@146bf000 {
> +		sram@14680000 {
>  			compatible = "qcom,sdm845-imem", "syscon", "simple-mfd";
> -			reg = <0 0x146bf000 0 0x1000>;
> +			reg = <0 0x14680000 0 0x40000>;
>  
>  			#address-cells = <1>;
>  			#size-cells = <1>;
>  
> -			ranges = <0 0 0x146bf000 0x1000>;
> +			ranges = <0 0 0x14680000 0x40000>;
>  
> -			pil-reloc@94c {
> +			pil-reloc@3f94c {
>  				compatible = "qcom,pil-reloc-info";
> -				reg = <0x94c 0xc8>;
> +				reg = <0x3f94c 0xc8>;
>  			};
>  		};
>  
> 
> -- 
> 2.49.0
> 

-- 
With best wishes
Dmitry

Re: [PATCH 02/10] arm64: dts: qcom: sdm845: Expand IMEM region

Posted by Konrad Dybcio 6 months, 3 weeks ago

On 5/23/25 12:40 PM, Dmitry Baryshkov wrote:
> On Fri, May 23, 2025 at 01:18:17AM +0200, Konrad Dybcio wrote:
>> From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
>>
>> We need more than what is currently described, expand the region to its
>> actual boundaries.
>>
>> Signed-off-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
>> ---
>>  arch/arm64/boot/dts/qcom/sdm845.dtsi | 10 +++++-----
>>  1 file changed, 5 insertions(+), 5 deletions(-)
> 
> Fixes: 948f6161c6ab ("arm64: dts: qcom: sdm845: Add IMEM and PIL info region")
> 
> BTW, are you sure about the address? msm-4.9 agrees with the current
> one.

we talked offline, but for the record, it is intentional - parts of IMEM
are not accessible to the OS and were previously not described

Konrad

Re: [PATCH 02/10] arm64: dts: qcom: sdm845: Expand IMEM region

Posted by Dmitry Baryshkov 6 months, 3 weeks ago

On Fri, May 23, 2025 at 08:12:38PM +0200, Konrad Dybcio wrote:
> On 5/23/25 12:40 PM, Dmitry Baryshkov wrote:
> > On Fri, May 23, 2025 at 01:18:17AM +0200, Konrad Dybcio wrote:
> >> From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
> >>
> >> We need more than what is currently described, expand the region to its
> >> actual boundaries.
> >>
> >> Signed-off-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
> >> ---
> >>  arch/arm64/boot/dts/qcom/sdm845.dtsi | 10 +++++-----
> >>  1 file changed, 5 insertions(+), 5 deletions(-)
> > 
> > Fixes: 948f6161c6ab ("arm64: dts: qcom: sdm845: Add IMEM and PIL info region")
> > 
> > BTW, are you sure about the address? msm-4.9 agrees with the current
> > one.
> 
> we talked offline, but for the record, it is intentional - parts of IMEM
> are not accessible to the OS and were previously not described

Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>

-- 
With best wishes
Dmitry