drivers/net/wireless/ath/ath12k/core.h | 4 ++ drivers/net/wireless/ath/ath12k/mac.c | 80 ++++++++++++++++++++++++++++++---- drivers/net/wireless/ath/ath12k/wmi.h | 1 + 3 files changed, 76 insertions(+), 9 deletions(-)
We got report that WCN7850 is not working with IWD [1][2]. Debug
shows the reason is that IWD installs group key before pairwise
key, which goes against WCN7850's firmware.
Reorder key install to workaround this.
[1] https://bugzilla.kernel.org/show_bug.cgi?id=218733
[2] https://lore.kernel.org/all/AS8P190MB12051DDBD84CD88E71C40AD7873F2@AS8P190MB1205.EURP190.PROD.OUTLOOK.COM
Signed-off-by: Baochen Qiang <quic_bqiang@quicinc.com>
---
---
Baochen Qiang (2):
wifi: ath12k: avoid bit operation on key flags
wifi: ath12k: install pairwise key first
drivers/net/wireless/ath/ath12k/core.h | 4 ++
drivers/net/wireless/ath/ath12k/mac.c | 80 ++++++++++++++++++++++++++++++----
drivers/net/wireless/ath/ath12k/wmi.h | 1 +
3 files changed, 76 insertions(+), 9 deletions(-)
---
base-commit: 3d933084a072fd5fb5da54c06a017abc0412c86f
change-id: 20250422-ath12k-unicast-key-first-9ce48f797b15
Best regards,
--
Baochen Qiang <quic_bqiang@quicinc.com>
[ +CC: Gregoire ] On Fri, May 23, 2025 at 11:49:00AM +0800, Baochen Qiang wrote: > We got report that WCN7850 is not working with IWD [1][2]. Debug > shows the reason is that IWD installs group key before pairwise > key, which goes against WCN7850's firmware. > > Reorder key install to workaround this. > > [1] https://bugzilla.kernel.org/show_bug.cgi?id=218733 > [2] https://lore.kernel.org/all/AS8P190MB12051DDBD84CD88E71C40AD7873F2@AS8P190MB1205.EURP190.PROD.OUTLOOK.COM > > Signed-off-by: Baochen Qiang <quic_bqiang@quicinc.com> > --- > --- > Baochen Qiang (2): > wifi: ath12k: avoid bit operation on key flags > wifi: ath12k: install pairwise key first Thanks for fixing this, Baochen. I noticed the patches weren't clearly marked as fixes. Do you think we should ask the stable team to backport these once they are in mainline (e.g. after 6.17-rc1 is out)? Or do you think they are too intrusive and risky to backport or similar? [ Also please try to remember to CC any (public) reporters. I only found out today that this had been addressed in linux-next. ] Johan
On 6/25/2025 5:51 PM, Johan Hovold wrote: > [ +CC: Gregoire ] > > On Fri, May 23, 2025 at 11:49:00AM +0800, Baochen Qiang wrote: >> We got report that WCN7850 is not working with IWD [1][2]. Debug >> shows the reason is that IWD installs group key before pairwise >> key, which goes against WCN7850's firmware. >> >> Reorder key install to workaround this. >> >> [1] https://bugzilla.kernel.org/show_bug.cgi?id=218733 >> [2] https://lore.kernel.org/all/AS8P190MB12051DDBD84CD88E71C40AD7873F2@AS8P190MB1205.EURP190.PROD.OUTLOOK.COM >> >> Signed-off-by: Baochen Qiang <quic_bqiang@quicinc.com> >> --- >> --- >> Baochen Qiang (2): >> wifi: ath12k: avoid bit operation on key flags >> wifi: ath12k: install pairwise key first > > Thanks for fixing this, Baochen. > > I noticed the patches weren't clearly marked as fixes. Do you think we > should ask the stable team to backport these once they are in mainline > (e.g. after 6.17-rc1 is out)? Or do you think they are too intrusive and > risky to backport or similar? Yeah, I think they should be backported. > > [ Also please try to remember to CC any (public) reporters. I only found > out today that this had been addressed in linux-next. ] Thanks, will keep in mind. > > Johan
On 6/25/2025 3:15 AM, Baochen Qiang wrote: > > > On 6/25/2025 5:51 PM, Johan Hovold wrote: >> [ +CC: Gregoire ] >> >> On Fri, May 23, 2025 at 11:49:00AM +0800, Baochen Qiang wrote: >>> We got report that WCN7850 is not working with IWD [1][2]. Debug >>> shows the reason is that IWD installs group key before pairwise >>> key, which goes against WCN7850's firmware. >>> >>> Reorder key install to workaround this. >>> >>> [1] https://bugzilla.kernel.org/show_bug.cgi?id=218733 >>> [2] https://lore.kernel.org/all/AS8P190MB12051DDBD84CD88E71C40AD7873F2@AS8P190MB1205.EURP190.PROD.OUTLOOK.COM >>> >>> Signed-off-by: Baochen Qiang <quic_bqiang@quicinc.com> >>> --- >>> --- >>> Baochen Qiang (2): >>> wifi: ath12k: avoid bit operation on key flags >>> wifi: ath12k: install pairwise key first >> >> Thanks for fixing this, Baochen. >> >> I noticed the patches weren't clearly marked as fixes. Do you think we >> should ask the stable team to backport these once they are in mainline >> (e.g. after 6.17-rc1 is out)? Or do you think they are too intrusive and >> risky to backport or similar? > > Yeah, I think they should be backported. > >> >> [ Also please try to remember to CC any (public) reporters. I only found >> out today that this had been addressed in linux-next. ] > > Thanks, will keep in mind. +Stable team, Per the above discussion please backport the series: https://msgid.link/20250523-ath12k-unicast-key-first-v1-0-f53c3880e6d8@quicinc.com This is a 0-day issue so ideally this should be backported from 6.6+ /jeff
On Wed, Jun 25, 2025 at 07:48:54AM -0700, Jeff Johnson wrote:
> On 6/25/2025 3:15 AM, Baochen Qiang wrote:
> >
> >
> > On 6/25/2025 5:51 PM, Johan Hovold wrote:
> >> [ +CC: Gregoire ]
> >>
> >> On Fri, May 23, 2025 at 11:49:00AM +0800, Baochen Qiang wrote:
> >>> We got report that WCN7850 is not working with IWD [1][2]. Debug
> >>> shows the reason is that IWD installs group key before pairwise
> >>> key, which goes against WCN7850's firmware.
> >>>
> >>> Reorder key install to workaround this.
> >>>
> >>> [1] https://bugzilla.kernel.org/show_bug.cgi?id=218733
> >>> [2] https://lore.kernel.org/all/AS8P190MB12051DDBD84CD88E71C40AD7873F2@AS8P190MB1205.EURP190.PROD.OUTLOOK.COM
> >>>
> >>> Signed-off-by: Baochen Qiang <quic_bqiang@quicinc.com>
> >>> ---
> >>> ---
> >>> Baochen Qiang (2):
> >>> wifi: ath12k: avoid bit operation on key flags
> >>> wifi: ath12k: install pairwise key first
> >>
> >> Thanks for fixing this, Baochen.
> >>
> >> I noticed the patches weren't clearly marked as fixes. Do you think we
> >> should ask the stable team to backport these once they are in mainline
> >> (e.g. after 6.17-rc1 is out)? Or do you think they are too intrusive and
> >> risky to backport or similar?
> >
> > Yeah, I think they should be backported.
> >
> >>
> >> [ Also please try to remember to CC any (public) reporters. I only found
> >> out today that this had been addressed in linux-next. ]
> >
> > Thanks, will keep in mind.
>
> +Stable team,
> Per the above discussion please backport the series:
> https://msgid.link/20250523-ath12k-unicast-key-first-v1-0-f53c3880e6d8@quicinc.com
<formletter>
This is not the correct way to submit patches for inclusion in the
stable kernel tree. Please read:
https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html
for how to do this properly.
</formletter>
On Wed, Jun 25, 2025 at 07:48:54AM -0700, Jeff Johnson wrote: > On 6/25/2025 3:15 AM, Baochen Qiang wrote: > > On 6/25/2025 5:51 PM, Johan Hovold wrote: > >> On Fri, May 23, 2025 at 11:49:00AM +0800, Baochen Qiang wrote: > >>> We got report that WCN7850 is not working with IWD [1][2]. Debug > >>> shows the reason is that IWD installs group key before pairwise > >>> key, which goes against WCN7850's firmware. > >>> > >>> Reorder key install to workaround this. > >>> > >>> [1] https://bugzilla.kernel.org/show_bug.cgi?id=218733 > >>> [2] https://lore.kernel.org/all/AS8P190MB12051DDBD84CD88E71C40AD7873F2@AS8P190MB1205.EURP190.PROD.OUTLOOK.COM > >>> > >>> Signed-off-by: Baochen Qiang <quic_bqiang@quicinc.com> > >>> --- > >>> --- > >>> Baochen Qiang (2): > >>> wifi: ath12k: avoid bit operation on key flags > >>> wifi: ath12k: install pairwise key first > >> > >> Thanks for fixing this, Baochen. > >> > >> I noticed the patches weren't clearly marked as fixes. Do you think we > >> should ask the stable team to backport these once they are in mainline > >> (e.g. after 6.17-rc1 is out)? Or do you think they are too intrusive and > >> risky to backport or similar? > > > > Yeah, I think they should be backported. > +Stable team, > Per the above discussion please backport the series: > https://msgid.link/20250523-ath12k-unicast-key-first-v1-0-f53c3880e6d8@quicinc.com These are currently only in linux-next but would need to be in Linus's tree before they can be backported, so we'll need to send another requested once they are in mainline. > This is a 0-day issue so ideally this should be backported from 6.6+ By "0-day" you mean it has been there since the driver was added, right (and not that it's exploitable or similar)? Johan
On 6/25/2025 7:57 AM, Johan Hovold wrote: > On Wed, Jun 25, 2025 at 07:48:54AM -0700, Jeff Johnson wrote: >> This is a 0-day issue so ideally this should be backported from 6.6+ > > By "0-day" you mean it has been there since the driver was added, right > (and not that it's exploitable or similar)? correct
Stable team, Per https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html Option 2 (since the patch was merged before being identified for -stable) Please consider the following for -stable subject of the patch: wifi: ath12k: install pairwise key first commit ID: 66e865f9dc78d00e6d1c8c6624cb0c9004e5aafb why you think it should be applied: This issue impacts all products that use iwd (instead of wpa_supplicant) for WLAN driver management what kernel versions you wish it to be applied to: All LTS kernels from 6.6+ Thanks! /jeff
On Tue, Aug 12, 2025 at 08:58:52AM -0700, Jeff Johnson wrote: > Stable team, > > Per https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html > Option 2 (since the patch was merged before being identified for -stable) > Please consider the following for -stable > > subject of the patch: > wifi: ath12k: install pairwise key first > > commit ID: > 66e865f9dc78d00e6d1c8c6624cb0c9004e5aafb > > why you think it should be applied: > This issue impacts all products that use iwd (instead of wpa_supplicant) for > WLAN driver management > > what kernel versions you wish it to be applied to: > All LTS kernels from 6.6+ It only applied cleanly to 6.16.y, so if you want it backported to older kernels, please provide a working backport. thanks, greg k-h
On Fri, 23 May 2025 11:49:00 +0800, Baochen Qiang wrote:
> We got report that WCN7850 is not working with IWD [1][2]. Debug
> shows the reason is that IWD installs group key before pairwise
> key, which goes against WCN7850's firmware.
>
> Reorder key install to workaround this.
>
> [1] https://bugzilla.kernel.org/show_bug.cgi?id=218733
> [2] https://lore.kernel.org/all/AS8P190MB12051DDBD84CD88E71C40AD7873F2@AS8P190MB1205.EURP190.PROD.OUTLOOK.COM
>
> [...]
Applied, thanks!
[1/2] wifi: ath12k: avoid bit operation on key flags
commit: 49375e11819b0d0f59ba59726d8e0b47656f5406
[2/2] wifi: ath12k: install pairwise key first
commit: 66e865f9dc78d00e6d1c8c6624cb0c9004e5aafb
Best regards,
--
Jeff Johnson <jeff.johnson@oss.qualcomm.com>
On 5/23/2025 9:19 AM, Baochen Qiang wrote: > We got report that WCN7850 is not working with IWD [1][2]. Debug > shows the reason is that IWD installs group key before pairwise > key, which goes against WCN7850's firmware. > > Reorder key install to workaround this. > > [1] https://bugzilla.kernel.org/show_bug.cgi?id=218733 > [2] https://lore.kernel.org/all/AS8P190MB12051DDBD84CD88E71C40AD7873F2@AS8P190MB1205.EURP190.PROD.OUTLOOK.COM > > Signed-off-by: Baochen Qiang <quic_bqiang@quicinc.com> > --- > --- > Baochen Qiang (2): > wifi: ath12k: avoid bit operation on key flags > wifi: ath12k: install pairwise key first > > drivers/net/wireless/ath/ath12k/core.h | 4 ++ > drivers/net/wireless/ath/ath12k/mac.c | 80 ++++++++++++++++++++++++++++++---- > drivers/net/wireless/ath/ath12k/wmi.h | 1 + > 3 files changed, 76 insertions(+), 9 deletions(-) Reviewed-by: Vasanthakumar Thiagarajan <vasanthakumar.thiagarajan@oss.qualcomm.com>
© 2016 - 2025 Red Hat, Inc.