[PATCH v3] dt-bindings: iio: adc: st,spear600-adc: txt to yaml format conversion.

Rodrigo Gobbi posted 1 patch 6 months, 3 weeks ago
.../bindings/iio/adc/st,spear600-adc.yaml     | 69 +++++++++++++++++++
.../bindings/staging/iio/adc/spear-adc.txt    | 24 -------
MAINTAINERS                                   |  1 -
3 files changed, 69 insertions(+), 25 deletions(-)
create mode 100644 Documentation/devicetree/bindings/iio/adc/st,spear600-adc.yaml
delete mode 100644 Documentation/devicetree/bindings/staging/iio/adc/spear-adc.txt
[PATCH v3] dt-bindings: iio: adc: st,spear600-adc: txt to yaml format conversion.
Posted by Rodrigo Gobbi 6 months, 3 weeks ago
Straight forward conversion from spear-adc.txt into yaml format.

Signed-off-by: Rodrigo Gobbi <rodrigo.gobbi.7@gmail.com>
---
Changelog:
v3: some yaml style, constraints and units pointed at v2.
    also, remove duplicated ref at MAINTAINERS file
v2: https://lore.kernel.org/linux-devicetree/20250430020248.26639-1-rodrigo.gobbi.7@gmail.com/
v1: https://lore.kernel.org/linux-devicetree/20250423022956.31218-1-rodrigo.gobbi.7@gmail.com/
---
 .../bindings/iio/adc/st,spear600-adc.yaml     | 69 +++++++++++++++++++
 .../bindings/staging/iio/adc/spear-adc.txt    | 24 -------
 MAINTAINERS                                   |  1 -
 3 files changed, 69 insertions(+), 25 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/iio/adc/st,spear600-adc.yaml
 delete mode 100644 Documentation/devicetree/bindings/staging/iio/adc/spear-adc.txt

diff --git a/Documentation/devicetree/bindings/iio/adc/st,spear600-adc.yaml b/Documentation/devicetree/bindings/iio/adc/st,spear600-adc.yaml
new file mode 100644
index 000000000000..dd9ec3038703
--- /dev/null
+++ b/Documentation/devicetree/bindings/iio/adc/st,spear600-adc.yaml
@@ -0,0 +1,69 @@
+# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/iio/adc/st,spear600-adc.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: ST SPEAr ADC device driver
+
+maintainers:
+  - Jonathan Cameron <jic23@kernel.org>
+
+description: |
+  Integrated ADC inside the ST SPEAr SoC, SPEAr600, supporting
+  10-bit resolution. Datasheet can be found here:
+  https://www.st.com/resource/en/datasheet/spear600.pdf
+
+properties:
+  compatible:
+    enum:
+      - st,spear600-adc
+
+  reg:
+    maxItems: 1
+
+  interrupts:
+    maxItems: 1
+
+  sampling-frequency:
+    $ref: /schemas/types.yaml#/definitions/uint32
+    minimum: 2500000
+    maximum: 20000000
+    description:
+      Default sampling frequency of the ADC in Hz.
+
+  vref-external:
+    $ref: /schemas/types.yaml#/definitions/uint32
+    minimum: 1000
+    maximum: 2800
+    description:
+      External voltage reference in milli-volts. If omitted the internal voltage
+      reference will be used.
+
+  average-samples:
+    $ref: /schemas/types.yaml#/definitions/uint32
+    minimum: 0
+    maximum: 15
+    default: 0
+    description:
+      Number of samples to generate an average value. If omitted, single data
+      conversion will be used.
+
+required:
+  - compatible
+  - reg
+  - interrupts
+  - sampling-frequency
+
+additionalProperties: false
+
+examples:
+  - |
+    adc@d8200000 {
+        compatible = "st,spear600-adc";
+        reg = <0xd8200000 0x1000>;
+        interrupt-parent = <&vic1>;
+        interrupts = <6>;
+        sampling-frequency = <5000000>;
+        vref-external = <2500>;	/* 2.5V VRef */
+    };
diff --git a/Documentation/devicetree/bindings/staging/iio/adc/spear-adc.txt b/Documentation/devicetree/bindings/staging/iio/adc/spear-adc.txt
deleted file mode 100644
index 88bc94fe1f6d..000000000000
--- a/Documentation/devicetree/bindings/staging/iio/adc/spear-adc.txt
+++ /dev/null
@@ -1,24 +0,0 @@
-* ST SPEAr ADC device driver
-
-Required properties:
-- compatible: Should be "st,spear600-adc"
-- reg: Address and length of the register set for the device
-- interrupts: Should contain the ADC interrupt
-- sampling-frequency: Default sampling frequency
-
-Optional properties:
-- vref-external: External voltage reference in milli-volts. If omitted
-  the internal voltage reference will be used.
-- average-samples: Number of samples to generate an average value. If
-  omitted, single data conversion will be used.
-
-Examples:
-
-	adc: adc@d8200000 {
-		compatible = "st,spear600-adc";
-		reg = <0xd8200000 0x1000>;
-		interrupt-parent = <&vic1>;
-		interrupts = <6>;
-		sampling-frequency = <5000000>;
-		vref-external = <2500>;	/* 2.5V VRef */
-	};
diff --git a/MAINTAINERS b/MAINTAINERS
index 906881b6c5cb..96760a05a5c5 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -23213,7 +23213,6 @@ STAGING - INDUSTRIAL IO
 M:	Jonathan Cameron <jic23@kernel.org>
 L:	linux-iio@vger.kernel.org
 S:	Odd Fixes
-F:	Documentation/devicetree/bindings/staging/iio/
 F:	drivers/staging/iio/
 
 STAGING - NVIDIA COMPLIANT EMBEDDED CONTROLLER INTERFACE (nvec)
-- 
2.49.0
Re: [PATCH v3] dt-bindings: iio: adc: st,spear600-adc: txt to yaml format conversion.
Posted by Conor Dooley 6 months, 3 weeks ago
On Thu, May 22, 2025 at 05:37:16PM -0300, Rodrigo Gobbi wrote:
> Straight forward conversion from spear-adc.txt into yaml format.
> 
> Signed-off-by: Rodrigo Gobbi <rodrigo.gobbi.7@gmail.com>

Reviewed-by: Conor Dooley <conor.dooley@microchip.com>
Re: [PATCH v3] dt-bindings: iio: adc: st,spear600-adc: txt to yaml format conversion.
Posted by Rodrigo Gobbi 5 months, 2 weeks ago
Hi, all,

Just a gentle ping here since it was already been reviewed.
If there is any other concerns, let me know.
Tks and regards.
Re: [PATCH v3] dt-bindings: iio: adc: st,spear600-adc: txt to yaml format conversion.
Posted by Conor Dooley 5 months, 2 weeks ago
On Thu, Jun 26, 2025 at 05:54:01PM -0300, Rodrigo Gobbi wrote:
> Hi, all,
> 
> Just a gentle ping here since it was already been reviewed.
> If there is any other concerns, let me know.
> Tks and regards.

This is all I see here, a ping with no context is not very
helpful. I have to go look it up on lore to see who reviewed it
etc. In this case the reviewer in question is me, so you're looking for
Jonathan to apply it.
Re: [PATCH v3] dt-bindings: iio: adc: st,spear600-adc: txt to yaml format conversion.
Posted by Jonathan Cameron 5 months, 2 weeks ago
On Fri, 27 Jun 2025 16:53:24 +0100
Conor Dooley <conor@kernel.org> wrote:

> On Thu, Jun 26, 2025 at 05:54:01PM -0300, Rodrigo Gobbi wrote:
> > Hi, all,
> > 
> > Just a gentle ping here since it was already been reviewed.
> > If there is any other concerns, let me know.
> > Tks and regards.  
> 
> This is all I see here, a ping with no context is not very
> helpful. I have to go look it up on lore to see who reviewed it
> etc. In this case the reviewer in question is me, so you're looking for
> Jonathan to apply it.

Seems I failed to send out a message, but applied this back on 9th June.

Thanks,

Jonathan