From: Nancy Lin <nancy.lin@mediatek.com>
Add a device tree binding document for the MediaTek MT8196 VMM (Vcore
for MultiMedia) regulator controller. The VMM controller acts as the
main power supplier for multimedia power domains, such as those used
by display, video encode and decode subsystems. It provides virtual
regulators that serve as the power sources for various multimedia IPs,
and coordinates with the hardware common clock framework (hwccf) and
the Video Companion Processor (VCP) to manage the power domains of
these components. The regulator is controlled by the VCP firmware,
and the operating system signals its requirement through a voting
hardware block (hwccf).
Signed-off-by: Nancy Lin <nancy.lin@mediatek.com>
---
.../mediatek,mt8196-vmm-regulator.yaml | 70 +++++++++++++++++++
1 file changed, 70 insertions(+)
create mode 100644 Documentation/devicetree/bindings/regulator/mediatek,mt8196-vmm-regulator.yaml
diff --git a/Documentation/devicetree/bindings/regulator/mediatek,mt8196-vmm-regulator.yaml b/Documentation/devicetree/bindings/regulator/mediatek,mt8196-vmm-regulator.yaml
new file mode 100644
index 000000000000..a50e35c2e238
--- /dev/null
+++ b/Documentation/devicetree/bindings/regulator/mediatek,mt8196-vmm-regulator.yaml
@@ -0,0 +1,70 @@
+# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: "http://devicetree.org/schemas/regulator/mediatek,mt8196-vmm-regulator.yaml#"
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: MediaTek MT8196 VMM (Vcore for MultiMedia) Regulator Controller
+
+maintainers:
+ - Nancy Lin <nancy.lin@mediatek.com>
+
+description: |
+ The MediaTek MT8196 VMM (Vcore for Multi Media) controller acts as the
+ main power supplier for multimedia power domains, such as those used by
+ display, video encode and decode subsystems. The VMM hardware block
+ provides virtual regulators that serve as the power sources (suppliers)
+ for various multimedia IPs. It coordinates with the MediaTek hardware
+ common clock framework (HWCCF) and the Video Companion Processor (VCP)
+ to manage the power domains of these multimedia components.
+
+ Each child node under the VMM node represents a virtual regulator
+ (e.g., vdisp, vdec-vcore) and must specify a 'regulator-name'.
+
+properties:
+ compatible:
+ const: "mediatek,mt8196-vmm"
+
+ mediatek,hw-ccf:
+ $ref: /schemas/types.yaml#/definitions/phandle
+ description: Phandle to the hardware common clock framework syscon controller.
+
+ mediatek,vcp:
+ $ref: /schemas/types.yaml#/definitions/phandle
+ description: Phandle to the Video Co-Processor (VCP) node.
+
+patternProperties:
+ "^(vdisp|vdec-vcore)$":
+ type: object
+ description: |
+ Virtual regulator for a specific multimedia domain.
+ The node name should match the supported regulator (e.g., vdisp, vdec-vcore).
+ properties:
+ regulator-name:
+ type: string
+ description: The name of the virtual regulator.
+ required:
+ - regulator-name
+ additionalProperties: false
+
+required:
+ - compatible
+ - mediatek,hw-ccf
+ - mediatek,vcp
+
+additionalProperties: false
+
+examples:
+ - |
+ vmm: vmm {
+ compatible = "mediatek,mt8196-vmm";
+ mediatek,hw-ccf = <&mm_hwv>;
+ mediatek,vcp = <&vcp>;
+
+ vdisp: vdisp {
+ regulator-name = "vdisp";
+ };
+ vdec_vcore: vdec-vcore {
+ regulator-name = "vdec-vcore";
+ };
+ };
--
2.45.2On Thu, 2025-05-22 at 23:03 +0800, Nancy.Lin wrote:
> From: Nancy Lin <nancy.lin@mediatek.com>
>
> Add a device tree binding document for the MediaTek MT8196 VMM (Vcore
> for MultiMedia) regulator controller. The VMM controller acts as the
> main power supplier for multimedia power domains, such as those used
> by display, video encode and decode subsystems. It provides virtual
> regulators that serve as the power sources for various multimedia IPs,
> and coordinates with the hardware common clock framework (hwccf) and
> the Video Companion Processor (VCP) to manage the power domains of
> these components. The regulator is controlled by the VCP firmware,
> and the operating system signals its requirement through a voting
> hardware block (hwccf).
>
> Signed-off-by: Nancy Lin <nancy.lin@mediatek.com>
> ---
> .../mediatek,mt8196-vmm-regulator.yaml | 70 +++++++++++++++++++
> 1 file changed, 70 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/regulator/mediatek,mt8196-vmm-regulator.yaml
>
> diff --git a/Documentation/devicetree/bindings/regulator/mediatek,mt8196-vmm-regulator.yaml b/Documentation/devicetree/bindings/regulator/mediatek,mt8196-vmm-regulator.yaml
> new file mode 100644
> index 000000000000..a50e35c2e238
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/regulator/mediatek,mt8196-vmm-regulator.yaml
> @@ -0,0 +1,70 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: "https://urldefense.com/v3/__http://devicetree.org/schemas/regulator/mediatek,mt8196-vmm-regulator.yaml*__;Iw!!CTRNKA9wMg0ARbw!gawATNOT3u6UBtTwtgnoZggwdwVL3VBuFZQyf-baV8j1wUMIV1sIaqBvhcqtfnZSlmXFesengtZaYxCWtDo$ "
> +$schema: https://urldefense.com/v3/__http://devicetree.org/meta-schemas/core.yaml*__;Iw!!CTRNKA9wMg0ARbw!gawATNOT3u6UBtTwtgnoZggwdwVL3VBuFZQyf-baV8j1wUMIV1sIaqBvhcqtfnZSlmXFesengtZaLcnGLmw$
> +
> +title: MediaTek MT8196 VMM (Vcore for MultiMedia) Regulator Controller
> +
> +maintainers:
> + - Nancy Lin <nancy.lin@mediatek.com>
> +
> +description: |
> + The MediaTek MT8196 VMM (Vcore for Multi Media) controller acts as the
> + main power supplier for multimedia power domains, such as those used by
> + display, video encode and decode subsystems. The VMM hardware block
> + provides virtual regulators that serve as the power sources (suppliers)
> + for various multimedia IPs. It coordinates with the MediaTek hardware
> + common clock framework (HWCCF) and the Video Companion Processor (VCP)
> + to manage the power domains of these multimedia components.
> +
> + Each child node under the VMM node represents a virtual regulator
> + (e.g., vdisp, vdec-vcore) and must specify a 'regulator-name'.
> +
> +properties:
> + compatible:
> + const: "mediatek,mt8196-vmm"
> +
> + mediatek,hw-ccf:
> + $ref: /schemas/types.yaml#/definitions/phandle
> + description: Phandle to the hardware common clock framework syscon controller.
> +
> + mediatek,vcp:
> + $ref: /schemas/types.yaml#/definitions/phandle
> + description: Phandle to the Video Co-Processor (VCP) node.
> +
> +patternProperties:
> + "^(vdisp|vdec-vcore)$":
> + type: object
> + description: |
> + Virtual regulator for a specific multimedia domain.
> + The node name should match the supported regulator (e.g., vdisp, vdec-vcore).
> + properties:
> + regulator-name:
> + type: string
> + description: The name of the virtual regulator.
> + required:
> + - regulator-name
> + additionalProperties: false
> +
> +required:
> + - compatible
> + - mediatek,hw-ccf
> + - mediatek,vcp
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + vmm: vmm {
> + compatible = "mediatek,mt8196-vmm";
> + mediatek,hw-ccf = <&mm_hwv>;
> + mediatek,vcp = <&vcp>;
> +
> + vdisp: vdisp {
> + regulator-name = "vdisp";
> + };
> + vdec_vcore: vdec-vcore {
> + regulator-name = "vdec-vcore";
> + };
> + };
device tree is used to describe real hardware.
vmm is a virtual device which is used for software to integrate the related driver,
so it should not have this virtual device.
According to your description, vcp is the master to control regulator,
so I think the device tree would be
vcp {
regulator-name = "vdisp", "vdec-vcore";
};
And vcp driver control these regulator.
I'm not sure what does hw-ccf do, if it's also controlled by vcp, the node should be
vcp {
mediatek,hw-ccf = <&mm_hwv>;
regulator-name = "vdisp", "vdec-vcore";
};
Regards,
CK
On Thu, 22 May 2025 23:03:33 +0800, Nancy.Lin wrote: > From: Nancy Lin <nancy.lin@mediatek.com> > > Add a device tree binding document for the MediaTek MT8196 VMM (Vcore > for MultiMedia) regulator controller. The VMM controller acts as the > main power supplier for multimedia power domains, such as those used > by display, video encode and decode subsystems. It provides virtual > regulators that serve as the power sources for various multimedia IPs, > and coordinates with the hardware common clock framework (hwccf) and > the Video Companion Processor (VCP) to manage the power domains of > these components. The regulator is controlled by the VCP firmware, > and the operating system signals its requirement through a voting > hardware block (hwccf). > > Signed-off-by: Nancy Lin <nancy.lin@mediatek.com> > --- > .../mediatek,mt8196-vmm-regulator.yaml | 70 +++++++++++++++++++ > 1 file changed, 70 insertions(+) > create mode 100644 Documentation/devicetree/bindings/regulator/mediatek,mt8196-vmm-regulator.yaml > My bot found errors running 'make dt_binding_check' on your patch: yamllint warnings/errors: dtschema/dtc warnings/errors: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/regulator/mediatek,mt8196-vmm-regulator.yaml: patternProperties:^(vdisp|vdec-vcore)$:properties:regulator-name:type: 'string' is not one of ['boolean', 'object'] from schema $id: http://devicetree.org/meta-schemas/core.yaml# /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/regulator/mediatek,mt8196-vmm-regulator.example.dtb: vmm (mediatek,mt8196-vmm): vdisp:regulator-name: ['vdisp'] is not of type 'string' from schema $id: http://devicetree.org/schemas/regulator/mediatek,mt8196-vmm-regulator.yaml# /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/regulator/mediatek,mt8196-vmm-regulator.example.dtb: vmm (mediatek,mt8196-vmm): vdec-vcore:regulator-name: ['vdec-vcore'] is not of type 'string' from schema $id: http://devicetree.org/schemas/regulator/mediatek,mt8196-vmm-regulator.yaml# doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20250522150426.3418225-2-nancy.lin@mediatek.com The base for the series is generally the latest rc1. A different dependency should be noted in *this* patch. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit after running the above command yourself. Note that DT_SCHEMA_FILES can be set to your schema file to speed up checking your schema. However, it must be unset to test all examples with your schema.
On 22/05/2025 17:03, Nancy.Lin wrote: > From: Nancy Lin <nancy.lin@mediatek.com> > > Add a device tree binding document for the MediaTek MT8196 VMM (Vcore > for MultiMedia) regulator controller. The VMM controller acts as the > main power supplier for multimedia power domains, such as those used > by display, video encode and decode subsystems. It provides virtual > regulators that serve as the power sources for various multimedia IPs, Virtual regulators do not sound real, so feels like you want some sort of power domains? A nit, subject: drop second/last, redundant "bindings". The "dt-bindings" prefix is already stating that these are bindings. See also: https://elixir.bootlin.com/linux/v6.7-rc8/source/Documentation/devicetree/bindings/submitting-patches.rst#L18 > and coordinates with the hardware common clock framework (hwccf) and > the Video Companion Processor (VCP) to manage the power domains of > these components. The regulator is controlled by the VCP firmware, > and the operating system signals its requirement through a voting > hardware block (hwccf). > > Signed-off-by: Nancy Lin <nancy.lin@mediatek.com> > --- > .../mediatek,mt8196-vmm-regulator.yaml | 70 +++++++++++++++++++ > 1 file changed, 70 insertions(+) > create mode 100644 Documentation/devicetree/bindings/regulator/mediatek,mt8196-vmm-regulator.yaml > > diff --git a/Documentation/devicetree/bindings/regulator/mediatek,mt8196-vmm-regulator.yaml b/Documentation/devicetree/bindings/regulator/mediatek,mt8196-vmm-regulator.yaml > new file mode 100644 > index 000000000000..a50e35c2e238 > --- /dev/null > +++ b/Documentation/devicetree/bindings/regulator/mediatek,mt8196-vmm-regulator.yaml > @@ -0,0 +1,70 @@ > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: "http://devicetree.org/schemas/regulator/mediatek,mt8196-vmm-regulator.yaml#" > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: MediaTek MT8196 VMM (Vcore for MultiMedia) Regulator Controller > + > +maintainers: > + - Nancy Lin <nancy.lin@mediatek.com> > + > +description: | > + The MediaTek MT8196 VMM (Vcore for Multi Media) controller acts as the > + main power supplier for multimedia power domains, such as those used by > + display, video encode and decode subsystems. The VMM hardware block > + provides virtual regulators that serve as the power sources (suppliers) > + for various multimedia IPs. It coordinates with the MediaTek hardware > + common clock framework (HWCCF) and the Video Companion Processor (VCP) > + to manage the power domains of these multimedia components. > + > + Each child node under the VMM node represents a virtual regulator > + (e.g., vdisp, vdec-vcore) and must specify a 'regulator-name'. > + > +properties: > + compatible: > + const: "mediatek,mt8196-vmm" Not tested... > + > + mediatek,hw-ccf: > + $ref: /schemas/types.yaml#/definitions/phandle > + description: Phandle to the hardware common clock framework syscon controller. No, you cannot express clocks with syscon. > + > + mediatek,vcp: > + $ref: /schemas/types.yaml#/definitions/phandle > + description: Phandle to the Video Co-Processor (VCP) node. For what purpose? > + > +patternProperties: > + "^(vdisp|vdec-vcore)$": Redundant nodes, useless. Drop these completely. > + type: object > + description: | > + Virtual regulator for a specific multimedia domain. > + The node name should match the supported regulator (e.g., vdisp, vdec-vcore). > + properties: > + regulator-name: No, you cannot start redefining properties. This binding is nowhere close to hardware description. Looks like some copy-paste downstream driver, so binding to fulfill driver needs. Please rework to match hardware. I suggest reaching internally to get some help how upstream drivers and bindings look like *prior* sending downstream code. Best regards, Krzysztof
Hi Krzysztof, Thanks for your review. On Thu, 2025-05-22 at 17:09 +0200, Krzysztof Kozlowski wrote: > > External email : Please do not click links or open attachments until > you have verified the sender or the content. > > > On 22/05/2025 17:03, Nancy.Lin wrote: > > From: Nancy Lin <nancy.lin@mediatek.com> > > > > Add a device tree binding document for the MediaTek MT8196 VMM > > (Vcore > > for MultiMedia) regulator controller. The VMM controller acts as > > the > > main power supplier for multimedia power domains, such as those > > used > > by display, video encode and decode subsystems. It provides virtual > > regulators that serve as the power sources for various multimedia > > IPs, > > Virtual regulators do not sound real, so feels like you want some > sort > of power domains? > This regulator supplies power to the power domain. Before the power domain can be powered up, the MediaTek PM driver first enables the regulator that the power domain relies on, and then powers up the domain. While "virtual" might not be the best term, it accurately describes a regulator used to control the power switch. Ultimately, the VCP (uP) handles the on/off control of the regulator. Therefore, we encapsulate it as a standard regulator in the kernel. The internal control of the VMM regulator is as follows: kernel HWCCF VCP (uP) |--------------| |--------------| irq |---------------------| | VMM reglator | ---> | hardware | -----> | get buck on/off irq | | | | voter | | and then turn on/off| | | | | | buck | |--------------| |--------------| |---------------------| When the regulator needs to be turned on or off, it uses the voter provided by hwccf to cast a vote for on/off. The VCP then receives the corresponding IRQ for the regulator and performs the buck on/off accordingly. > A nit, subject: drop second/last, redundant "bindings". The > "dt-bindings" prefix is already stating that these are bindings. > See also: > https://urldefense.com/v3/__https://elixir.bootlin.com/linux/v6.7-rc8/source/Documentation/devicetree/bindings/submitting-patches.rst*L18__;Iw!!CTRNKA9wMg0ARbw!lBqtzZ8DmC6f2kNnLXRCpHsof7XOYvrIMG4o_DXuvjYbg1SyFRrXrtEMLjIxS31cq82hqQowrczWRg$ > OK, I will remove the binding/document word in commit message body. And change title to regulator: dt-bindings: Add MT8196 vmm controller > > and coordinates with the hardware common clock framework (hwccf) > > and > > the Video Companion Processor (VCP) to manage the power domains of > > these components. The regulator is controlled by the VCP firmware, > > and the operating system signals its requirement through a voting > > hardware block (hwccf). > > > > Signed-off-by: Nancy Lin <nancy.lin@mediatek.com> > > --- > > .../mediatek,mt8196-vmm-regulator.yaml | 70 > > +++++++++++++++++++ > > 1 file changed, 70 insertions(+) > > create mode 100644 > > Documentation/devicetree/bindings/regulator/mediatek,mt8196-vmm- > > regulator.yaml > > > > diff --git > > a/Documentation/devicetree/bindings/regulator/mediatek,mt8196-vmm- > > regulator.yaml > > b/Documentation/devicetree/bindings/regulator/mediatek,mt8196-vmm- > > regulator.yaml > > new file mode 100644 > > index 000000000000..a50e35c2e238 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/regulator/mediatek,mt8196- > > vmm-regulator.yaml > > @@ -0,0 +1,70 @@ > > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > > +%YAML 1.2 > > +--- > > +$id: > > "https://urldefense.com/v3/__http://devicetree.org/schemas/regulato > > r/mediatek,mt8196-vmm- > > regulator.yaml*__;Iw!!CTRNKA9wMg0ARbw!lBqtzZ8DmC6f2kNnLXRCpHsof7XOY > > vrIMG4o_DXuvjYbg1SyFRrXrtEMLjIxS31cq82hqQrOgUATjA$ " > > +$schema: > > https://urldefense.com/v3/__http://devicetree.org/meta-schemas/core.yaml*__;Iw!!CTRNKA9wMg0ARbw!lBqtzZ8DmC6f2kNnLXRCpHsof7XOYvrIMG4o_DXuvjYbg1SyFRrXrtEMLjIxS31cq82hqQr4UitgLg$ > > + > > +title: MediaTek MT8196 VMM (Vcore for MultiMedia) Regulator > > Controller > > + > > +maintainers: > > + - Nancy Lin <nancy.lin@mediatek.com> > > + > > +description: | > > + The MediaTek MT8196 VMM (Vcore for Multi Media) controller acts > > as the > > + main power supplier for multimedia power domains, such as those > > used by > > + display, video encode and decode subsystems. The VMM hardware > > block > > + provides virtual regulators that serve as the power sources > > (suppliers) > > + for various multimedia IPs. It coordinates with the MediaTek > > hardware > > + common clock framework (HWCCF) and the Video Companion Processor > > (VCP) > > + to manage the power domains of these multimedia components. > > + > > + Each child node under the VMM node represents a virtual > > regulator > > + (e.g., vdisp, vdec-vcore) and must specify a 'regulator-name'. > > + > > +properties: > > + compatible: > > + const: "mediatek,mt8196-vmm" > > Not tested... > My bad, I accidentally added extra quotation marks, but I ran dt_binding_check and didn't see this error being detected. > > + > > + mediatek,hw-ccf: > > + $ref: /schemas/types.yaml#/definitions/phandle > > + description: Phandle to the hardware common clock framework > > syscon controller. > > No, you cannot express clocks with syscon. > HWCCF is MediaTek's internal naming; the functionality of the hardware IP is voter. We use the IP to vote for buck on/off, and the VCP will get the voting result to perform buck on/off. I will refine the naming/description to "voter." > > + > > + mediatek,vcp: > > + $ref: /schemas/types.yaml#/definitions/phandle > > + description: Phandle to the Video Co-Processor (VCP) node. > > For what purpose? > This is used to ensure that the VCP uP is ready to receive the hwccf IRQ and handle the corresponding buck on/off operations. > > + > > +patternProperties: > > + "^(vdisp|vdec-vcore)$": > > Redundant nodes, useless. Drop these completely. > OK. > > > + type: object > > + description: | > > + Virtual regulator for a specific multimedia domain. > > + The node name should match the supported regulator (e.g., > > vdisp, vdec-vcore). > > + properties: > > + regulator-name: > > No, you cannot start redefining properties. This binding is nowhere > close to hardware description. Looks like some copy-paste downstream > driver, so binding to fulfill driver needs. > > Please rework to match hardware. I suggest reaching internally to get > some help how upstream drivers and bindings look like *prior* sending > downstream code. > I will review and refine the binding internally before submitting it. Thanks! Best regards, Nancy > Best regards, > Krzysztof
On 28/05/2025 06:01, Nancy Lin (林欣螢) wrote: >> >> Virtual regulators do not sound real, so feels like you want some >> sort >> of power domains? >> > This regulator supplies power to the power domain. Before the power > domain can be powered up, the MediaTek PM driver first enables the > regulator that the power domain relies on, and then powers up the > domain. While "virtual" might not be the best term, it accurately > describes a regulator used to control the power switch. > > Ultimately, the VCP (uP) handles the on/off control of the regulator. > Therefore, we encapsulate it as a standard regulator in the kernel. > > The internal control of the VMM regulator is as follows: > kernel HWCCF VCP (uP) > |--------------| |--------------| irq |---------------------| > | VMM reglator | ---> | hardware | -----> | get buck on/off irq | > | | | voter | | and then turn on/off| > | | | | | buck | > |--------------| |--------------| |---------------------| > > When the regulator needs to be turned on or off, it uses the voter > provided by hwccf to cast a vote for on/off. The VCP then receives the > corresponding IRQ for the regulator and performs the buck on/off > accordingly. OK, thanks for explanation. > ... > >>> + >>> + mediatek,hw-ccf: >>> + $ref: /schemas/types.yaml#/definitions/phandle >>> + description: Phandle to the hardware common clock framework >>> syscon controller. >> >> No, you cannot express clocks with syscon. >> > HWCCF is MediaTek's internal naming; the functionality of the hardware > IP is voter. We use the IP to vote for buck on/off, and the VCP will > get the voting result to perform buck on/off. I will refine the > naming/description to "voter." OK, that was a bit confusing, but now I have more questions: Why isn't this a child of the HWCCF? You do not have here any resources, so this looks just to instantiate device for Linux. Looking at your diagram earlier (maybe include it in binding description if this stays as is at the end) I would imagine phandle only to hwccf. But you have two phandles - HWCCF and VCP. So maybe this is part of VCP device, not HWCCF? I don't know. I am afraid the moment I will suggest you something someone from Collabora will be pointing out that my advice us wrong and I don't know this hardware. Yeah, I don't know it. You should know it. > >>> + >>> + mediatek,vcp: >>> + $ref: /schemas/types.yaml#/definitions/phandle >>> + description: Phandle to the Video Co-Processor (VCP) node. >> >> For what purpose? >> > This is used to ensure that the VCP uP is ready to receive the hwccf > IRQ and handle the corresponding buck on/off operations. > >>> + >>> +patternProperties: >>> + "^(vdisp|vdec-vcore)$": >> >> Redundant nodes, useless. Drop these completely. >> > OK. Best regards, Krzysztof
On 22/05/2025 17:09, Krzysztof Kozlowski wrote: > On 22/05/2025 17:03, Nancy.Lin wrote: >> From: Nancy Lin <nancy.lin@mediatek.com> >> >> Add a device tree binding document for the MediaTek MT8196 VMM (Vcore >> for MultiMedia) regulator controller. The VMM controller acts as the >> main power supplier for multimedia power domains, such as those used >> by display, video encode and decode subsystems. It provides virtual >> regulators that serve as the power sources for various multimedia IPs, > > Virtual regulators do not sound real, so feels like you want some sort > of power domains? > > A nit, subject: drop second/last, redundant "bindings". The > "dt-bindings" prefix is already stating that these are bindings. > See also: > https://elixir.bootlin.com/linux/v6.7-rc8/source/Documentation/devicetree/bindings/submitting-patches.rst#L18 Wrong keyword... Please fix the subject prefixes: For bindings, the preferred subjects are explained here: https://www.kernel.org/doc/html/latest/devicetree/bindings/submitting-patches.html#i-for-patch-submitters Best regards, Krzysztof
© 2016 - 2026 Red Hat, Inc.