The MT9M114 supports the different slew rates (0 to 7) on the output pads.
At the moment, this is hardcoded to 7 (the fastest rate).
The user might want to change this values due to EMC requirements.

Add the 'slew-rate' property to the MT9M114 DT-bindings for selecting
the desired slew rate.

Signed-off-by: Mathis Foerst <mathis.foerst@mt.com>
---
 .../devicetree/bindings/media/i2c/onnn,mt9m114.yaml      | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/Documentation/devicetree/bindings/media/i2c/onnn,mt9m114.yaml b/Documentation/devicetree/bindings/media/i2c/onnn,mt9m114.yaml
index f6b87892068a..a89f740214f7 100644
--- a/Documentation/devicetree/bindings/media/i2c/onnn,mt9m114.yaml
+++ b/Documentation/devicetree/bindings/media/i2c/onnn,mt9m114.yaml
@@ -70,6 +70,15 @@ properties:
           - bus-type
           - link-frequencies
 
+  slew-rate:
+    $ref: /schemas/types.yaml#/definitions/uint32
+    description:
+      Slew rate ot the output pads DOUT[7:0], LINE_VALID, FRAME_VALID and
+      PIXCLK. Higher values imply steeper voltage-flanks on the pads.
+    minimum: 0
+    maximum: 7
+    default: 7
+
 required:
   - compatible
   - reg
-- 
2.34.1

On 22/05/2025 16:06, Mathis Foerst wrote:
> The MT9M114 supports the different slew rates (0 to 7) on the output pads.
> At the moment, this is hardcoded to 7 (the fastest rate).
> The user might want to change this values due to EMC requirements.
> 
> Add the 'slew-rate' property to the MT9M114 DT-bindings for selecting
> the desired slew rate.
> 
> Signed-off-by: Mathis Foerst <mathis.foerst@mt.com>
> ---

<form letter>
This is a friendly reminder during the review process.

It looks like you received a tag and forgot to add it.

If you do not know the process, here is a short explanation:
Please add Acked-by/Reviewed-by/Tested-by tags when posting new versions
of patchset, under or above your Signed-off-by tag, unless patch changed
significantly (e.g. new properties added to the DT bindings). Tag is
"received", when provided in a message replied to you on the mailing
list. Tools like b4 can help here. However, there's no need to repost
patches *only* to add the tags. The upstream maintainer will do that for
tags received on the version they apply.

Please read:
https://elixir.bootlin.com/linux/v6.12-rc3/source/Documentation/process/submitting-patches.rst#L577

If a tag was not added on purpose, please state why and what changed.
</form letter>

Best regards,
Krzysztof

On 22/05/2025 16:08, Krzysztof Kozlowski wrote:
> On 22/05/2025 16:06, Mathis Foerst wrote:
>> The MT9M114 supports the different slew rates (0 to 7) on the output pads.
>> At the moment, this is hardcoded to 7 (the fastest rate).
>> The user might want to change this values due to EMC requirements.
>>
>> Add the 'slew-rate' property to the MT9M114 DT-bindings for selecting
>> the desired slew rate.
>>
>> Signed-off-by: Mathis Foerst <mathis.foerst@mt.com>
>> ---
> 
> <form letter>
> This is a friendly reminder during the review process.
> 
> It looks like you received a tag and forgot to add it.
> 
Crap, you actually received review almost three months ago at v2! Then
on v3 Rob did job second time and me on v4 did third time.

How many times this has to be reviewed?

Best regards,
Krzysztof

Hi Krzysztof,

On Thu, May 22, 2025 at 04:11:52PM +0200, Krzysztof Kozlowski wrote:
> On 22/05/2025 16:08, Krzysztof Kozlowski wrote:
> > On 22/05/2025 16:06, Mathis Foerst wrote:
> >> The MT9M114 supports the different slew rates (0 to 7) on the output pads.
> >> At the moment, this is hardcoded to 7 (the fastest rate).
> >> The user might want to change this values due to EMC requirements.
> >>
> >> Add the 'slew-rate' property to the MT9M114 DT-bindings for selecting
> >> the desired slew rate.
> >>
> >> Signed-off-by: Mathis Foerst <mathis.foerst@mt.com>
> >> ---
> > 
> > <form letter>
> > This is a friendly reminder during the review process.
> > 
> > It looks like you received a tag and forgot to add it.
> > 
> Crap, you actually received review almost three months ago at v2! Then
> on v3 Rob did job second time and me on v4 did third time.
> 
> How many times this has to be reviewed?

I'm very sorry to not include the "Reviewed-By"-tags in the updated versions
of my patch series. There is no more review required, I'm just not familiar 
with the process. 
Thank you for pointing to the relevant documentation.
I added the tags in the latest version.

Sorry again for wasting your time and thank you for your patience.

> 
> Best regards,
> Krzysztof

Best regards,
Mathis