On 22/05/2025 19:40, Alexey Klimov wrote:
> Document compatibles for Qualcomm SM6115 SoC digital RX and
> VA (voice activation) macro codecs and their clocks.
>
> Cc: Srinivas Kandagatla <srini@kernel.org>
> Signed-off-by: Alexey Klimov <alexey.klimov@linaro.org>
> ---
> .../bindings/sound/qcom,lpass-rx-macro.yaml | 19 +++++++++++++++++++
> .../bindings/sound/qcom,lpass-va-macro.yaml | 22 ++++++++++++++++------
> 2 files changed, 35 insertions(+), 6 deletions(-)
>
You did not respond to my comments, I don't see any changelog. I also do
not understand the changes done later
> diff --git a/Documentation/devicetree/bindings/sound/qcom,lpass-rx-macro.yaml b/Documentation/devicetree/bindings/sound/qcom,lpass-rx-macro.yaml
> index 92f95eb74b1928fde11ad86ab6344f274bdf7790..697c5591ae7cb82633ff0159fb31d08b57c11b97 100644
> --- a/Documentation/devicetree/bindings/sound/qcom,lpass-rx-macro.yaml
> +++ b/Documentation/devicetree/bindings/sound/qcom,lpass-rx-macro.yaml
> @@ -14,6 +14,7 @@ properties:
> oneOf:
> - enum:
> - qcom,sc7280-lpass-rx-macro
> + - qcom,sm6115-lpass-rx-macro
> - qcom,sm8250-lpass-rx-macro
> - qcom,sm8450-lpass-rx-macro
> - qcom,sm8550-lpass-rx-macro
> @@ -80,6 +81,24 @@ allOf:
> - const: npl
> - const: fsgen
>
> + - if:
> + properties:
> + compatible:
> + contains:
> + enum:
> + - qcom,sm6115-lpass-rx-macro
> + then:
> + properties:
> + clocks:
> + minItems: 4
> + maxItems: 4
> + clock-names:
> + items:
> + - const: mclk
> + - const: npl
> + - const: dcodec
> + - const: fsgen
> +
> - if:
> properties:
> compatible:
> diff --git a/Documentation/devicetree/bindings/sound/qcom,lpass-va-macro.yaml b/Documentation/devicetree/bindings/sound/qcom,lpass-va-macro.yaml
> index f41deaa6f4df57c8186acf4cd7bb99e38dbf89f0..a70c0f36389269756b724889c335c1b0bae157d2 100644
> --- a/Documentation/devicetree/bindings/sound/qcom,lpass-va-macro.yaml
> +++ b/Documentation/devicetree/bindings/sound/qcom,lpass-va-macro.yaml
> @@ -14,10 +14,15 @@ properties:
> oneOf:
> - enum:
> - qcom,sc7280-lpass-va-macro
> + - qcom,sm6115-lpass-va-macro
> - qcom,sm8250-lpass-va-macro
> - qcom,sm8450-lpass-va-macro
> - qcom,sm8550-lpass-va-macro
> - qcom,sc8280xp-lpass-va-macro
> + - items:
> + - enum:
> + - qcom,sm6115-lpass-va-macro
> + - const: qcom,sm8450-lpass-va-macro
> - items:
> - enum:
> - qcom,sm8650-lpass-va-macro
> @@ -109,14 +114,19 @@ allOf:
> then:
> properties:
> clocks:
> - minItems: 4
> + minItems: 3
Why? Nothing in commit msg explains why existing devices changed.
Best regards,
Krzysztof