iio: dac: adi-axi-dac: fix bus free check

[PATCH] iio: dac: adi-axi-dac: fix bus free check

Posted by Angelo Dureghello 7 months ago

From: Angelo Dureghello <adureghello@baylibre.com>

This patch is intended to fix [1] that looks not yet accepted in any
upstream branch.

Poll function must check for a value equal to 0 (bus free condition).

[1] https://lore.kernel.org/linux-iio/l6vu54ltxd7pydkzl6xbbq55gedumzbsllfxnljyngwcg4c6zd@w6qxgn2vby75/

Signed-off-by: Angelo Dureghello <adureghello@baylibre.com>
---
 drivers/iio/dac/adi-axi-dac.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/iio/dac/adi-axi-dac.c b/drivers/iio/dac/adi-axi-dac.c
index b6cfe07701d47440df478f7b9b4c579434b99a25..a0e546dba3680371e00dc4c8973d4f450c18cf2d 100644
--- a/drivers/iio/dac/adi-axi-dac.c
+++ b/drivers/iio/dac/adi-axi-dac.c
@@ -641,7 +641,7 @@ static int axi_dac_wait_bus_free(struct axi_dac_state *st)
 	int ret;
 
 	ret = regmap_read_poll_timeout(st->regmap, AXI_DAC_UI_STATUS_REG, val,
-		FIELD_GET(AXI_DAC_UI_STATUS_IF_BUSY, val) == -1, 10,
+		FIELD_GET(AXI_DAC_UI_STATUS_IF_BUSY, val) == 0, 10,
 		100 * KILO);
 	if (ret == -ETIMEDOUT)
 		dev_err(st->dev, "AXI bus timeout\n");

---
base-commit: 50b8b618e598468e35551003d7e5cc5db14ee113
change-id: 20250522-iio-dac-adi-axi-dac-fix-bus-read-244fbc07313c

Best regards,
-- 
Angelo Dureghello <adureghello@baylibre.com>

Re: [PATCH] iio: dac: adi-axi-dac: fix bus free check

Posted by Andy Shevchenko 6 months, 4 weeks ago

On Thu, May 22, 2025 at 06:47:31PM +0200, Angelo Dureghello wrote:
> From: Angelo Dureghello <adureghello@baylibre.com>
> 
> This patch is intended to fix [1] that looks not yet accepted in any
> upstream branch.
> 
> Poll function must check for a value equal to 0 (bus free condition).

> [1] https://lore.kernel.org/linux-iio/l6vu54ltxd7pydkzl6xbbq55gedumzbsllfxnljyngwcg4c6zd@w6qxgn2vby75/
> 

Make these two lines to be a Link tag

Link: https://... [1]

> Signed-off-by: Angelo Dureghello <adureghello@baylibre.com>

-- 
With Best Regards,
Andy Shevchenko

Re: [PATCH] iio: dac: adi-axi-dac: fix bus free check

Posted by Jonathan Cameron 7 months ago

On Thu, 22 May 2025 18:47:31 +0200
Angelo Dureghello <adureghello@baylibre.com> wrote:

> From: Angelo Dureghello <adureghello@baylibre.com>
> 
> This patch is intended to fix [1] that looks not yet accepted in any
> upstream branch.
> 
> Poll function must check for a value equal to 0 (bus free condition).
> 
> [1] https://lore.kernel.org/linux-iio/l6vu54ltxd7pydkzl6xbbq55gedumzbsllfxnljyngwcg4c6zd@w6qxgn2vby75/
> 
> Signed-off-by: Angelo Dureghello <adureghello@baylibre.com>
Hi Angelo.

That was stalled due to tree shuffling.  Given as you
observed it hasn't made it on to any tree yet, would you mind
squashing this in and posting a new version of that patch?
That will probably end up cleaner than me trying to remember to squash the two.

Thanks!

Jonathan

> ---
>  drivers/iio/dac/adi-axi-dac.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/iio/dac/adi-axi-dac.c b/drivers/iio/dac/adi-axi-dac.c
> index b6cfe07701d47440df478f7b9b4c579434b99a25..a0e546dba3680371e00dc4c8973d4f450c18cf2d 100644
> --- a/drivers/iio/dac/adi-axi-dac.c
> +++ b/drivers/iio/dac/adi-axi-dac.c
> @@ -641,7 +641,7 @@ static int axi_dac_wait_bus_free(struct axi_dac_state *st)
>  	int ret;
>  
>  	ret = regmap_read_poll_timeout(st->regmap, AXI_DAC_UI_STATUS_REG, val,
> -		FIELD_GET(AXI_DAC_UI_STATUS_IF_BUSY, val) == -1, 10,
> +		FIELD_GET(AXI_DAC_UI_STATUS_IF_BUSY, val) == 0, 10,
>  		100 * KILO);
>  	if (ret == -ETIMEDOUT)
>  		dev_err(st->dev, "AXI bus timeout\n");
> 
> ---
> base-commit: 50b8b618e598468e35551003d7e5cc5db14ee113
> change-id: 20250522-iio-dac-adi-axi-dac-fix-bus-read-244fbc07313c
> 
> Best regards,