dmaengine: idxd: Fix warning for deadcode.deadstore

[PATCH] dmaengine: idxd: Fix warning for deadcode.deadstore

Posted by Anil S Keshavamurthy 6 months, 3 weeks ago

Deletes the  second initialization as the value stored to 'dev' during
its initialization (struct device *dev = &idxd->pdev->dev;) is
sufficient.

../drivers/dma/idxd/init.c:988:17: warning: Value stored to 'dev' during
its initialization is never read [deadcode.DeadStores]
  988 |         struct device *dev = &idxd->pdev->dev;
      |                        ^~~   ~~~~~~~~~~~~~~~~

Signed-off-by: Anil S Keshavamurthy <anil.s.keshavamurthy@intel.com>
---
 drivers/dma/idxd/init.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/dma/idxd/init.c b/drivers/dma/idxd/init.c
index fca1d2924999..b7664136fc67 100644
--- a/drivers/dma/idxd/init.c
+++ b/drivers/dma/idxd/init.c
@@ -989,7 +989,6 @@ static void idxd_reset_prepare(struct pci_dev *pdev)
 	const char *idxd_name;
 	int rc;
 
-	dev = &idxd->pdev->dev;
 	idxd_name = dev_name(idxd_confdev(idxd));
 
 	struct idxd_saved_states *idxd_saved __free(kfree) =
-- 
2.47.1

Re: [PATCH] dmaengine: idxd: Fix warning for deadcode.deadstore

Posted by Vinod Koul 5 months, 2 weeks ago

On Wed, 21 May 2025 19:13:31 -0400, Anil S Keshavamurthy wrote:
> Deletes the  second initialization as the value stored to 'dev' during
> its initialization (struct device *dev = &idxd->pdev->dev;) is
> sufficient.
> 
> ../drivers/dma/idxd/init.c:988:17: warning: Value stored to 'dev' during
> its initialization is never read [deadcode.DeadStores]
>   988 |         struct device *dev = &idxd->pdev->dev;
>       |                        ^~~   ~~~~~~~~~~~~~~~~
> 
> [...]

Applied, thanks!

[1/1] dmaengine: idxd: Fix warning for deadcode.deadstore
      commit: 8c2442663f683f4fabadb3c491821169da6c89a8

Best regards,
-- 
~Vinod

Re: [PATCH] dmaengine: idxd: Fix warning for deadcode.deadstore

Posted by Dave Jiang 6 months, 3 weeks ago


On 5/21/25 4:13 PM, Anil S Keshavamurthy wrote:
> Deletes the  second initialization as the value stored to 'dev' during
> its initialization (struct device *dev = &idxd->pdev->dev;) is
> sufficient.
> 
> ../drivers/dma/idxd/init.c:988:17: warning: Value stored to 'dev' during
> its initialization is never read [deadcode.DeadStores]
>   988 |         struct device *dev = &idxd->pdev->dev;
>       |                        ^~~   ~~~~~~~~~~~~~~~~
> 
> Signed-off-by: Anil S Keshavamurthy <anil.s.keshavamurthy@intel.com>

Reviewed-by: Dave Jiang <dave.jiang@intel.com>
> ---
>  drivers/dma/idxd/init.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/dma/idxd/init.c b/drivers/dma/idxd/init.c
> index fca1d2924999..b7664136fc67 100644
> --- a/drivers/dma/idxd/init.c
> +++ b/drivers/dma/idxd/init.c
> @@ -989,7 +989,6 @@ static void idxd_reset_prepare(struct pci_dev *pdev)
>  	const char *idxd_name;
>  	int rc;
>  
> -	dev = &idxd->pdev->dev;
>  	idxd_name = dev_name(idxd_confdev(idxd));
>  
>  	struct idxd_saved_states *idxd_saved __free(kfree) =