[v2] mux: mmio: Fix missing CONFIG_REGMAP_MMIO

[PATCH v2] mux: mmio: Fix missing CONFIG_REGMAP_MMIO

Posted by Krzysztof Kozlowski 6 months, 3 weeks ago

MMIO mux uses now regmap_init_mmio(), so one way or another
CONFIG_REGMAP_MMIO should be enabled, because there are no stubs for
!REGMAP_MMIO case:

  ERROR: modpost: "__regmap_init_mmio_clk" [drivers/mux/mux-mmio.ko] undefined!

Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202505150312.dYbBqUhG-lkp@intel.com/
Fixes: 61de83fd8256 ("mux: mmio: Do not use syscon helper to build regmap")
Acked-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---

Dependency
==========
Patch exposes Kconfig-circular-dependency, which is being fixed by:
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/regmap.git/commit/?h=for-6.16&id=c5a219395b4e6312102a505bfe73aac8f8bada8c
Therefore this should be merged after above change reaches mainline.

Changes in v2
=============
1. Drop drivers/net/ethernet/arc/Kconfig change.
2. Add Arnd Ack (although do not add Jakub's ack because netdev part
   changed/dropped).
3. Update commit msg because there is no circular dependency anymore.

Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Samuel Holland <samuel@sholland.org>
Cc: Arnd Bergmann <arnd@arndb.de>
---
 drivers/mux/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/mux/Kconfig b/drivers/mux/Kconfig
index 80f015cf6e54..c68132e38138 100644
--- a/drivers/mux/Kconfig
+++ b/drivers/mux/Kconfig
@@ -48,6 +48,7 @@ config MUX_GPIO
 config MUX_MMIO
 	tristate "MMIO/Regmap register bitfield-controlled Multiplexer"
 	depends on OF
+	select REGMAP_MMIO
 	help
 	  MMIO/Regmap register bitfield-controlled Multiplexer controller.
 
-- 
2.45.2

Re: [PATCH v2] mux: mmio: Fix missing CONFIG_REGMAP_MMIO

Posted by Krzysztof Kozlowski 6 months, 1 week ago

On Wed, 21 May 2025 17:23:55 +0200, Krzysztof Kozlowski wrote:
> MMIO mux uses now regmap_init_mmio(), so one way or another
> CONFIG_REGMAP_MMIO should be enabled, because there are no stubs for
> !REGMAP_MMIO case:
> 
>   ERROR: modpost: "__regmap_init_mmio_clk" [drivers/mux/mux-mmio.ko] undefined!
> 
> 
> [...]

Applied, thanks!

[1/1] mux: mmio: Fix missing CONFIG_REGMAP_MMIO
      https://git.kernel.org/krzk/linux/c/5cac59c59bbc81c3cd081ee575c41c917123d11a

Best regards,
-- 
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>