From: Sayali Lokhande <quic_sayalil@quicinc.com>

Add UFS support for qcs9075 IQ-9075-EVK board.

Signed-off-by: Sayali Lokhande <quic_sayalil@quicinc.com>
Signed-off-by: Wasim Nazir <quic_wasimn@quicinc.com>
---
 .../arm64/boot/dts/qcom/qcs9075-iq-9075-evk.dts | 17 +++++++++++++++++
 1 file changed, 17 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/qcs9075-iq-9075-evk.dts b/arch/arm64/boot/dts/qcom/qcs9075-iq-9075-evk.dts
index 30a36ffa40be..ba8a359d8fee 100644
--- a/arch/arm64/boot/dts/qcom/qcs9075-iq-9075-evk.dts
+++ b/arch/arm64/boot/dts/qcom/qcs9075-iq-9075-evk.dts
@@ -276,3 +276,20 @@ &uart10 {
 &xo_board_clk {
 	clock-frequency = <38400000>;
 };
+
+&ufs_mem_hc {
+	reset-gpios = <&tlmm 149 GPIO_ACTIVE_LOW>;
+	vcc-supply = <&vreg_l8a>;
+	vcc-max-microamp = <1100000>;
+	vccq-supply = <&vreg_l4c>;
+	vccq-max-microamp = <1200000>;
+
+	status = "okay";
+};
+
+&ufs_mem_phy {
+	vdda-phy-supply = <&vreg_l4a>;
+	vdda-pll-supply = <&vreg_l1c>;
+
+	status = "okay";
+};
--
2.49.0

On 21/05/2025 17:08, Wasim Nazir wrote:
> From: Sayali Lokhande <quic_sayalil@quicinc.com>
> 
> Add UFS support for qcs9075 IQ-9075-EVK board.
> 
> Signed-off-by: Sayali Lokhande <quic_sayalil@quicinc.com>
> Signed-off-by: Wasim Nazir <quic_wasimn@quicinc.com>

Squash two last patches into the previous one. Use Co-developed-by+SoB 
to denote all contributors.

-- 
With best wishes
Dmitry

On Wed, May 21, 2025 at 05:33:52PM +0300, Dmitry Baryshkov wrote:
> On 21/05/2025 17:08, Wasim Nazir wrote:
> > From: Sayali Lokhande <quic_sayalil@quicinc.com>
> > 
> > Add UFS support for qcs9075 IQ-9075-EVK board.
> > 
> > Signed-off-by: Sayali Lokhande <quic_sayalil@quicinc.com>
> > Signed-off-by: Wasim Nazir <quic_wasimn@quicinc.com>
> 
> Squash two last patches into the previous one. Use Co-developed-by+SoB to
> denote all contributors.

Thanks Dmitry for the clarity, will push another series accordingly.

> 
> -- 
> With best wishes
> Dmitry

Regards,
Wasim

On 21/05/2025 16:08, Wasim Nazir wrote:
> From: Sayali Lokhande <quic_sayalil@quicinc.com>
> 
> Add UFS support for qcs9075 IQ-9075-EVK board.
> 
> Signed-off-by: Sayali Lokhande <quic_sayalil@quicinc.com>
> Signed-off-by: Wasim Nazir <quic_wasimn@quicinc.com>
> ---
>  .../arm64/boot/dts/qcom/qcs9075-iq-9075-evk.dts | 17 +++++++++++++++++
>  1 file changed, 17 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/qcom/qcs9075-iq-9075-evk.dts b/arch/arm64/boot/dts/qcom/qcs9075-iq-9075-evk.dts
> index 30a36ffa40be..ba8a359d8fee 100644
> --- a/arch/arm64/boot/dts/qcom/qcs9075-iq-9075-evk.dts
> +++ b/arch/arm64/boot/dts/qcom/qcs9075-iq-9075-evk.dts
> @@ -276,3 +276,20 @@ &uart10 {
>  &xo_board_clk {
>  	clock-frequency = <38400000>;
>  };
> +
> +&ufs_mem_hc {

Please follow DTS coding style.

Best regards,
Krzysztof

On 21/05/2025 16:21, Krzysztof Kozlowski wrote:
> On 21/05/2025 16:08, Wasim Nazir wrote:
>> From: Sayali Lokhande <quic_sayalil@quicinc.com>
>>
>> Add UFS support for qcs9075 IQ-9075-EVK board.
>>
>> Signed-off-by: Sayali Lokhande <quic_sayalil@quicinc.com>
>> Signed-off-by: Wasim Nazir <quic_wasimn@quicinc.com>
>> ---
>>  .../arm64/boot/dts/qcom/qcs9075-iq-9075-evk.dts | 17 +++++++++++++++++
>>  1 file changed, 17 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/qcs9075-iq-9075-evk.dts b/arch/arm64/boot/dts/qcom/qcs9075-iq-9075-evk.dts
>> index 30a36ffa40be..ba8a359d8fee 100644
>> --- a/arch/arm64/boot/dts/qcom/qcs9075-iq-9075-evk.dts
>> +++ b/arch/arm64/boot/dts/qcom/qcs9075-iq-9075-evk.dts
>> @@ -276,3 +276,20 @@ &uart10 {
>>  &xo_board_clk {
>>  	clock-frequency = <38400000>;
>>  };
>> +
>> +&ufs_mem_hc {
> 
> Please follow DTS coding style.

And you just added this file. Squash the patches so you will see the
mishap in ordering.

Best regards,
Krzysztof

On Wed, May 21, 2025 at 04:23:02PM +0200, Krzysztof Kozlowski wrote:
> On 21/05/2025 16:21, Krzysztof Kozlowski wrote:
> > On 21/05/2025 16:08, Wasim Nazir wrote:
> >> From: Sayali Lokhande <quic_sayalil@quicinc.com>
> >>
> >> Add UFS support for qcs9075 IQ-9075-EVK board.
> >>
> >> Signed-off-by: Sayali Lokhande <quic_sayalil@quicinc.com>
> >> Signed-off-by: Wasim Nazir <quic_wasimn@quicinc.com>
> >> ---
> >>  .../arm64/boot/dts/qcom/qcs9075-iq-9075-evk.dts | 17 +++++++++++++++++
> >>  1 file changed, 17 insertions(+)
> >>
> >> diff --git a/arch/arm64/boot/dts/qcom/qcs9075-iq-9075-evk.dts b/arch/arm64/boot/dts/qcom/qcs9075-iq-9075-evk.dts
> >> index 30a36ffa40be..ba8a359d8fee 100644
> >> --- a/arch/arm64/boot/dts/qcom/qcs9075-iq-9075-evk.dts
> >> +++ b/arch/arm64/boot/dts/qcom/qcs9075-iq-9075-evk.dts
> >> @@ -276,3 +276,20 @@ &uart10 {
> >>  &xo_board_clk {
> >>  	clock-frequency = <38400000>;
> >>  };
> >> +
> >> +&ufs_mem_hc {
> > 
> > Please follow DTS coding style.

Thanks for pointing it out. This will help other contributors to
understand the issue.

> 
> And you just added this file. Squash the patches so you will see the
> mishap in ordering.

Sure will do that in next series.

> 
> Best regards,
> Krzysztof

Regards,
Wasim