[PATCH] gpio: davinci: select GPIOLIB_IRQCHIP

Peng Fan (OSS) posted 1 patch 6 months, 3 weeks ago
There is a newer version of this series
drivers/gpio/Kconfig | 1 +
1 file changed, 1 insertion(+)
[PATCH] gpio: davinci: select GPIOLIB_IRQCHIP
Posted by Peng Fan (OSS) 6 months, 3 weeks ago
From: Peng Fan <peng.fan@nxp.com>

This driver uses gpiochip_irq_reqres() and gpiochip_irq_relres() which
are only built with GPIOLIB_IRQCHIP=y. Add the missing Kconfig select.

Fixes: 3f50bb3124d7 ("gpio: davinci: Make irq_chip immutable")
Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202505210606.PudPm5pC-lkp@intel.com/
Signed-off-by: Peng Fan <peng.fan@nxp.com>
---

Hi Bartosz,

 I follow same approach as you did.
 My last build using multi defconfig was not enough.
 I tried build all arch/arm/configs/*, no errors with this patch applied.

Thanks,
Peng

 drivers/gpio/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig
index a559d5bb8249..c3465fd82b08 100644
--- a/drivers/gpio/Kconfig
+++ b/drivers/gpio/Kconfig
@@ -253,6 +253,7 @@ config GPIO_DAVINCI
 	tristate "TI Davinci/Keystone GPIO support"
 	default y if ARCH_DAVINCI
 	depends on ((ARM || ARM64) && (ARCH_DAVINCI || ARCH_KEYSTONE || ARCH_K3)) || COMPILE_TEST
+	select GPIOLIB_IRQCHIP
 	help
 	  Say yes here to enable GPIO support for TI Davinci/Keystone SoCs.
 
-- 
2.37.1
Re: [PATCH] gpio: davinci: select GPIOLIB_IRQCHIP
Posted by Bartosz Golaszewski 6 months, 3 weeks ago
From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>


On Wed, 21 May 2025 15:20:48 +0800, Peng Fan (OSS) wrote:
> This driver uses gpiochip_irq_reqres() and gpiochip_irq_relres() which
> are only built with GPIOLIB_IRQCHIP=y. Add the missing Kconfig select.
> 
> 

Applied, thanks!

[1/1] gpio: davinci: select GPIOLIB_IRQCHIP
      https://git.kernel.org/brgl/linux/c/4347566404a0f01e9dc654a0b806a582ee63f68b

Best regards,
-- 
Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
Re: [PATCH] gpio: davinci: select GPIOLIB_IRQCHIP
Posted by Bartosz Golaszewski 6 months, 3 weeks ago
On Wed, May 21, 2025 at 9:22 AM Peng Fan (OSS) <peng.fan@oss.nxp.com> wrote:
>
> From: Peng Fan <peng.fan@nxp.com>
>
> This driver uses gpiochip_irq_reqres() and gpiochip_irq_relres() which
> are only built with GPIOLIB_IRQCHIP=y. Add the missing Kconfig select.
>
> Fixes: 3f50bb3124d7 ("gpio: davinci: Make irq_chip immutable")
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202505210606.PudPm5pC-lkp@intel.com/
> Signed-off-by: Peng Fan <peng.fan@nxp.com>
> ---
>
> Hi Bartosz,
>
>  I follow same approach as you did.
>  My last build using multi defconfig was not enough.
>  I tried build all arch/arm/configs/*, no errors with this patch applied.
>
> Thanks,
> Peng
>
>  drivers/gpio/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig
> index a559d5bb8249..c3465fd82b08 100644
> --- a/drivers/gpio/Kconfig
> +++ b/drivers/gpio/Kconfig
> @@ -253,6 +253,7 @@ config GPIO_DAVINCI
>         tristate "TI Davinci/Keystone GPIO support"
>         default y if ARCH_DAVINCI
>         depends on ((ARM || ARM64) && (ARCH_DAVINCI || ARCH_KEYSTONE || ARCH_K3)) || COMPILE_TEST
> +       select GPIOLIB_IRQCHIP
>         help
>           Say yes here to enable GPIO support for TI Davinci/Keystone SoCs.
>
> --
> 2.37.1
>

Ah, you beat me to it by 2 minutes.

Bart