DAMON_{VADDR,PADDR,SYSFS} are de-facto essential parts of DAMON for
normal usages. Because those need to be enabled one by one, however,
and there are other test-purpose or non-essential configurations, it is
easy to be confused and make mistakes at setup. Make the essential
configurations default to CONFIG_DAMON, so that those can be enabled by
default with a single change.
Signed-off-by: SeongJae Park <sj@kernel.org>
---
mm/damon/Kconfig | 3 +++
1 file changed, 3 insertions(+)
diff --git a/mm/damon/Kconfig b/mm/damon/Kconfig
index c213cf8b5638..c93d0c56b963 100644
--- a/mm/damon/Kconfig
+++ b/mm/damon/Kconfig
@@ -28,6 +28,7 @@ config DAMON_VADDR
bool "Data access monitoring operations for virtual address spaces"
depends on DAMON && MMU
select PAGE_IDLE_FLAG
+ default DAMON
help
This builds the default data access monitoring operations for DAMON
that work for virtual address spaces.
@@ -36,6 +37,7 @@ config DAMON_PADDR
bool "Data access monitoring operations for the physical address space"
depends on DAMON && MMU
select PAGE_IDLE_FLAG
+ default DAMON
help
This builds the default data access monitoring operations for DAMON
that works for the physical address space.
@@ -55,6 +57,7 @@ config DAMON_VADDR_KUNIT_TEST
config DAMON_SYSFS
bool "DAMON sysfs interface"
depends on DAMON && SYSFS
+ default DAMON
help
This builds the sysfs interface for DAMON. The user space can use
the interface for arbitrary data access monitoring.
--
2.39.5
Hi SeongJae,
This is the patch I was waiting for. Since enabling DAMON build doesn't
directly impact the kernel behaviors as it is disabled by default.
On 5/21/2025 1:27 PM, SeongJae Park wrote:
> DAMON_{VADDR,PADDR,SYSFS} are de-facto essential parts of DAMON for
> normal usages. Because those need to be enabled one by one, however,
> and there are other test-purpose or non-essential configurations, it is
> easy to be confused and make mistakes at setup. Make the essential
> configurations default to CONFIG_DAMON, so that those can be enabled by
> default with a single change.
>
> Signed-off-by: SeongJae Park <sj@kernel.org>
> ---
> mm/damon/Kconfig | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/mm/damon/Kconfig b/mm/damon/Kconfig
> index c213cf8b5638..c93d0c56b963 100644
> --- a/mm/damon/Kconfig
> +++ b/mm/damon/Kconfig
> @@ -28,6 +28,7 @@ config DAMON_VADDR
> bool "Data access monitoring operations for virtual address spaces"
> depends on DAMON && MMU
> select PAGE_IDLE_FLAG
> + default DAMON
> help
> This builds the default data access monitoring operations for DAMON
> that work for virtual address spaces.
> @@ -36,6 +37,7 @@ config DAMON_PADDR
> bool "Data access monitoring operations for the physical address space"
> depends on DAMON && MMU
> select PAGE_IDLE_FLAG
> + default DAMON
> help
> This builds the default data access monitoring operations for DAMON
> that works for the physical address space.
> @@ -55,6 +57,7 @@ config DAMON_VADDR_KUNIT_TEST
> config DAMON_SYSFS
> bool "DAMON sysfs interface"
> depends on DAMON && SYSFS
> + default DAMON
> help
> This builds the sysfs interface for DAMON. The user space can use
> the interface for arbitrary data access monitoring.
I'm not sure if I'm elighble to ack your patch, but I would like to add
Acked-by: Honggyu Kim <honggyu.kim@sk.com>
Thanks,
Honggyu
On Thu, 22 May 2025 14:54:33 +0900 Honggyu Kim <honggyu.kim@sk.com> wrote: > Hi SeongJae, > > This is the patch I was waiting for. I'm more than glad to hear this :) Also appreciate/apology for your wait. [...] > I'm not sure if I'm elighble to ack your patch, but I pretty sure you're eligible. > I would like to add > > Acked-by: Honggyu Kim <honggyu.kim@sk.com> Thank you, this means a lot to me! Thanks, SJ [...]
© 2016 - 2025 Red Hat, Inc.