1. Patchew
  2. linux
  3. View series

[PATCH] staging: rtl8723bs: Fix typo in variable name 'ips_deffer_ms'

Donny-Dev posted 1 patch 7 months ago
There is a newer version of this series
drivers/staging/rtl8723bs/core/rtw_pwrctrl.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
[PATCH] staging: rtl8723bs: Fix typo in variable name 'ips_deffer_ms'
Posted by Donny-Dev 7 months ago 
The variable 'ips_deffer_ms' had
 a spelling mistake ('deffer'
 instead of 'defer').
This patch rename it to
'ips_defer_ms' to correct the
typo and improve code clarity.

Signed-off-by: Donny-Dev <donnyturizo13@gmail.com>
---
 drivers/staging/rtl8723bs/core/rtw_pwrctrl.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/staging/rtl8723bs/core/rtw_pwrctrl.c b/drivers/staging/rtl8723bs/core/rtw_pwrctrl.c
index c60e179bb..90e50bb9c 100644
--- a/drivers/staging/rtl8723bs/core/rtw_pwrctrl.c
+++ b/drivers/staging/rtl8723bs/core/rtw_pwrctrl.c
@@ -1010,18 +1010,18 @@ inline void rtw_set_ips_deny(struct adapter *padapter, u32 ms)
 /*
 * rtw_pwr_wakeup - Wake the NIC up from: 1)IPS. 2)USB autosuspend
 * @adapter: pointer to struct adapter structure
-* @ips_deffer_ms: the ms will prevent from falling into IPS after wakeup
+* @ips_defer_ms: the ms will prevent from falling into IPS after wakeup
 * Return _SUCCESS or _FAIL
 */
 
-int _rtw_pwr_wakeup(struct adapter *padapter, u32 ips_deffer_ms, const char *caller)
+int _rtw_pwr_wakeup(struct adapter *padapter, u32 ips_defer_ms, const char *caller)
 {
 	struct dvobj_priv *dvobj = adapter_to_dvobj(padapter);
 	struct pwrctrl_priv *pwrpriv = dvobj_to_pwrctl(dvobj);
 	struct mlme_priv *pmlmepriv;
 	int ret = _SUCCESS;
 	unsigned long start = jiffies;
-	unsigned long deny_time = jiffies + msecs_to_jiffies(ips_deffer_ms);
+	unsigned long deny_time = jiffies + msecs_to_jiffies(ips_defer_ms);
 
 	/* for LPS */
 	LeaveAllPowerSaveMode(padapter);
-- 
2.43.0
Re: [PATCH] staging: rtl8723bs: Fix typo in variable name 'ips_deffer_ms'
Posted by kernel test robot 7 months ago 
Hi Donny-Dev,

kernel test robot noticed the following build errors:

[auto build test ERROR on staging/staging-testing]

url:    https://github.com/intel-lab-lkp/linux/commits/Donny-Dev/staging-rtl8723bs-Fix-typo-in-variable-name-ips_deffer_ms/20250521-091609
base:   staging/staging-testing
patch link:    https://lore.kernel.org/r/20250521011358.12910-1-donnyturizo13%40gmail.com
patch subject: [PATCH] staging: rtl8723bs: Fix typo in variable name 'ips_deffer_ms'
config: sparc-allmodconfig (https://download.01.org/0day-ci/archive/20250521/202505212120.fuBu3jP5-lkp@intel.com/config)
compiler: sparc64-linux-gcc (GCC) 14.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250521/202505212120.fuBu3jP5-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202505212120.fuBu3jP5-lkp@intel.com/

All errors (new ones prefixed by >>):

   drivers/staging/rtl8723bs/core/rtw_pwrctrl.c: In function '_rtw_pwr_wakeup':
>> drivers/staging/rtl8723bs/core/rtw_pwrctrl.c:1078:48: error: 'ips_deffer_ms' undeclared (first use in this function); did you mean 'ips_defer_ms'?
    1078 |         deny_time = jiffies + msecs_to_jiffies(ips_deffer_ms);
         |                                                ^~~~~~~~~~~~~
         |                                                ips_defer_ms
   drivers/staging/rtl8723bs/core/rtw_pwrctrl.c:1078:48: note: each undeclared identifier is reported only once for each function it appears in


vim +1078 drivers/staging/rtl8723bs/core/rtw_pwrctrl.c

554c0a3abf216c9 Hans de Goede          2017-03-29  1014  
fccab3afea6e474 Donny-Dev              2025-05-21  1015  int _rtw_pwr_wakeup(struct adapter *padapter, u32 ips_defer_ms, const char *caller)
554c0a3abf216c9 Hans de Goede          2017-03-29  1016  {
554c0a3abf216c9 Hans de Goede          2017-03-29  1017  	struct dvobj_priv *dvobj = adapter_to_dvobj(padapter);
554c0a3abf216c9 Hans de Goede          2017-03-29  1018  	struct pwrctrl_priv *pwrpriv = dvobj_to_pwrctl(dvobj);
554c0a3abf216c9 Hans de Goede          2017-03-29  1019  	struct mlme_priv *pmlmepriv;
554c0a3abf216c9 Hans de Goede          2017-03-29  1020  	int ret = _SUCCESS;
554c0a3abf216c9 Hans de Goede          2017-03-29  1021  	unsigned long start = jiffies;
fccab3afea6e474 Donny-Dev              2025-05-21  1022  	unsigned long deny_time = jiffies + msecs_to_jiffies(ips_defer_ms);
554c0a3abf216c9 Hans de Goede          2017-03-29  1023  
554c0a3abf216c9 Hans de Goede          2017-03-29  1024  	/* for LPS */
554c0a3abf216c9 Hans de Goede          2017-03-29  1025  	LeaveAllPowerSaveMode(padapter);
554c0a3abf216c9 Hans de Goede          2017-03-29  1026  
554c0a3abf216c9 Hans de Goede          2017-03-29  1027  	/* IPS still bound with primary adapter */
554c0a3abf216c9 Hans de Goede          2017-03-29  1028  	padapter = GET_PRIMARY_ADAPTER(padapter);
554c0a3abf216c9 Hans de Goede          2017-03-29  1029  	pmlmepriv = &padapter->mlmepriv;
554c0a3abf216c9 Hans de Goede          2017-03-29  1030  
554c0a3abf216c9 Hans de Goede          2017-03-29  1031  	if (time_before(pwrpriv->ips_deny_time, deny_time))
554c0a3abf216c9 Hans de Goede          2017-03-29  1032  		pwrpriv->ips_deny_time = deny_time;
554c0a3abf216c9 Hans de Goede          2017-03-29  1033  
554c0a3abf216c9 Hans de Goede          2017-03-29  1034  
709c8e49b51c370 Fabio Aiuto            2021-04-07  1035  	if (pwrpriv->ps_processing)
554c0a3abf216c9 Hans de Goede          2017-03-29  1036  		while (pwrpriv->ps_processing && jiffies_to_msecs(jiffies - start) <= 3000)
8204b61a775879a Jia-Ju Bai             2018-09-15  1037  			mdelay(10);
554c0a3abf216c9 Hans de Goede          2017-03-29  1038  
709c8e49b51c370 Fabio Aiuto            2021-04-07  1039  	if (!(pwrpriv->bInternalAutoSuspend) && pwrpriv->bInSuspend)
8ec06b9ff8a4f5e Ross Schmidt           2020-11-09  1040  		while (pwrpriv->bInSuspend && jiffies_to_msecs(jiffies - start) <= 3000
709c8e49b51c370 Fabio Aiuto            2021-04-07  1041  		)
8204b61a775879a Jia-Ju Bai             2018-09-15  1042  			mdelay(10);
554c0a3abf216c9 Hans de Goede          2017-03-29  1043  
554c0a3abf216c9 Hans de Goede          2017-03-29  1044  	/* System suspend is not allowed to wakeup */
2e20a5ac67f8a58 Nishka Dasgupta        2019-07-25  1045  	if (!(pwrpriv->bInternalAutoSuspend) && pwrpriv->bInSuspend) {
554c0a3abf216c9 Hans de Goede          2017-03-29  1046  		ret = _FAIL;
554c0a3abf216c9 Hans de Goede          2017-03-29  1047  		goto exit;
554c0a3abf216c9 Hans de Goede          2017-03-29  1048  	}
554c0a3abf216c9 Hans de Goede          2017-03-29  1049  
554c0a3abf216c9 Hans de Goede          2017-03-29  1050  	/* block??? */
2e20a5ac67f8a58 Nishka Dasgupta        2019-07-25  1051  	if (pwrpriv->bInternalAutoSuspend  && padapter->net_closed) {
554c0a3abf216c9 Hans de Goede          2017-03-29  1052  		ret = _FAIL;
554c0a3abf216c9 Hans de Goede          2017-03-29  1053  		goto exit;
554c0a3abf216c9 Hans de Goede          2017-03-29  1054  	}
554c0a3abf216c9 Hans de Goede          2017-03-29  1055  
554c0a3abf216c9 Hans de Goede          2017-03-29  1056  	/* I think this should be check in IPS, LPS, autosuspend functions... */
2e20a5ac67f8a58 Nishka Dasgupta        2019-07-25  1057  	if (check_fwstate(pmlmepriv, _FW_LINKED)) {
554c0a3abf216c9 Hans de Goede          2017-03-29  1058  		ret = _SUCCESS;
554c0a3abf216c9 Hans de Goede          2017-03-29  1059  		goto exit;
554c0a3abf216c9 Hans de Goede          2017-03-29  1060  	}
554c0a3abf216c9 Hans de Goede          2017-03-29  1061  
554c0a3abf216c9 Hans de Goede          2017-03-29  1062  	if (rf_off == pwrpriv->rf_pwrstate) {
554c0a3abf216c9 Hans de Goede          2017-03-29  1063  		{
bc21df678b4d5da Zhansaya Bagdauletkyzy 2021-04-06  1064  			if (ips_leave(padapter) == _FAIL) {
554c0a3abf216c9 Hans de Goede          2017-03-29  1065  				ret = _FAIL;
554c0a3abf216c9 Hans de Goede          2017-03-29  1066  				goto exit;
554c0a3abf216c9 Hans de Goede          2017-03-29  1067  			}
554c0a3abf216c9 Hans de Goede          2017-03-29  1068  		}
554c0a3abf216c9 Hans de Goede          2017-03-29  1069  	}
554c0a3abf216c9 Hans de Goede          2017-03-29  1070  
554c0a3abf216c9 Hans de Goede          2017-03-29  1071  	/* TODO: the following checking need to be merged... */
8ec06b9ff8a4f5e Ross Schmidt           2020-11-09  1072  	if (padapter->bDriverStopped || !padapter->bup || !padapter->hw_init_completed) {
554c0a3abf216c9 Hans de Goede          2017-03-29  1073  		ret = false;
554c0a3abf216c9 Hans de Goede          2017-03-29  1074  		goto exit;
554c0a3abf216c9 Hans de Goede          2017-03-29  1075  	}
554c0a3abf216c9 Hans de Goede          2017-03-29  1076  
554c0a3abf216c9 Hans de Goede          2017-03-29  1077  exit:
554c0a3abf216c9 Hans de Goede          2017-03-29 @1078  	deny_time = jiffies + msecs_to_jiffies(ips_deffer_ms);
554c0a3abf216c9 Hans de Goede          2017-03-29  1079  	if (time_before(pwrpriv->ips_deny_time, deny_time))
554c0a3abf216c9 Hans de Goede          2017-03-29  1080  		pwrpriv->ips_deny_time = deny_time;
554c0a3abf216c9 Hans de Goede          2017-03-29  1081  	return ret;
554c0a3abf216c9 Hans de Goede          2017-03-29  1082  

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
Re: [PATCH] staging: rtl8723bs: Fix typo in variable name 'ips_deffer_ms'
Posted by Greg KH 7 months ago 
On Wed, May 21, 2025 at 01:13:57AM +0000, Donny-Dev wrote:
> The variable 'ips_deffer_ms' had
>  a spelling mistake ('deffer'
>  instead of 'defer').
> This patch rename it to
> 'ips_defer_ms' to correct the
> typo and improve code clarity.

You have 72 columns to use, please use them :)

> Signed-off-by: Donny-Dev <donnyturizo13@gmail.com>

Please use your real name.

thanks,

greg k-h

Patchew 2.1-devel-b67e4c2

© 2016 - 2025 Red Hat, Inc.