1. Patchew
  2. linux
  3. View series

[PATCH] drivers/staging/rtl8723bs: Fix camelCase to snake_case style in core files

Donny-Dev posted 1 patch 7 months ago
There is a newer version of this series
drivers/staging/rtl8723bs/core/rtw_cmd.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
[PATCH] drivers/staging/rtl8723bs: Fix camelCase to snake_case style in core files
Posted by Donny-Dev 7 months ago 
Signed-off-by: Donny-Dev <donnyturizo13@gmail.com>
---
 drivers/staging/rtl8723bs/core/rtw_cmd.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/rtl8723bs/core/rtw_cmd.c b/drivers/staging/rtl8723bs/core/rtw_cmd.c
index 557bfdf09..81f795a82 100644
--- a/drivers/staging/rtl8723bs/core/rtw_cmd.c
+++ b/drivers/staging/rtl8723bs/core/rtw_cmd.c
@@ -9,8 +9,8 @@
 #include <linux/jiffies.h>
 
 static struct _cmd_callback rtw_cmd_callback[] = {
-	{GEN_CMD_CODE(_Read_MACREG), NULL}, /*0*/
-	{GEN_CMD_CODE(_Write_MACREG), NULL},
+	{GEN_CMD_CODE(_read_macreg), NULL}, /*0*/
+	{GEN_CMD_CODE(_write_macreg), NULL},
 	{GEN_CMD_CODE(_Read_BBREG), &rtw_getbbrfreg_cmdrsp_callback},
 	{GEN_CMD_CODE(_Write_BBREG), NULL},
 	{GEN_CMD_CODE(_Read_RFREG), &rtw_getbbrfreg_cmdrsp_callback},
-- 
2.43.0
Re: [PATCH] drivers/staging/rtl8723bs: Fix camelCase to snake_case style in core files
Posted by kernel test robot 7 months ago 
Hi Donny-Dev,

kernel test robot noticed the following build errors:

[auto build test ERROR on staging/staging-testing]
[also build test ERROR on staging/staging-next staging/staging-linus linus/master v6.15-rc7 next-20250521]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Donny-Dev/drivers-staging-rtl8723bs-Fix-camelCase-to-snake_case-style-in-core-files/20250521-080425
base:   staging/staging-testing
patch link:    https://lore.kernel.org/r/20250521000150.11659-1-donnyturizo13%40gmail.com
patch subject: [PATCH] drivers/staging/rtl8723bs: Fix camelCase to snake_case style in core files
config: sparc-allmodconfig (https://download.01.org/0day-ci/archive/20250522/202505220306.OiXLGnOS-lkp@intel.com/config)
compiler: sparc64-linux-gcc (GCC) 14.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250522/202505220306.OiXLGnOS-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202505220306.OiXLGnOS-lkp@intel.com/

All errors (new ones prefixed by >>):

   In file included from drivers/staging/rtl8723bs/include/drv_types.h:29,
                    from drivers/staging/rtl8723bs/core/rtw_cmd.c:7:
>> drivers/staging/rtl8723bs/core/rtw_cmd.c:12:23: error: '_read_macreg_CMD_' undeclared here (not in a function); did you mean '_Read_MACREG_CMD_'?
      12 |         {GEN_CMD_CODE(_read_macreg), NULL}, /*0*/
         |                       ^~~~~~~~~~~~
   drivers/staging/rtl8723bs/include/rtw_cmd.h:554:33: note: in definition of macro 'GEN_CMD_CODE'
     554 | #define GEN_CMD_CODE(cmd)       cmd ## _CMD_
         |                                 ^~~
>> drivers/staging/rtl8723bs/core/rtw_cmd.c:13:23: error: '_write_macreg_CMD_' undeclared here (not in a function); did you mean '_Write_MACREG_CMD_'?
      13 |         {GEN_CMD_CODE(_write_macreg), NULL},
         |                       ^~~~~~~~~~~~~
   drivers/staging/rtl8723bs/include/rtw_cmd.h:554:33: note: in definition of macro 'GEN_CMD_CODE'
     554 | #define GEN_CMD_CODE(cmd)       cmd ## _CMD_
         |                                 ^~~


vim +12 drivers/staging/rtl8723bs/core/rtw_cmd.c

    10	
    11	static struct _cmd_callback rtw_cmd_callback[] = {
  > 12		{GEN_CMD_CODE(_read_macreg), NULL}, /*0*/
  > 13		{GEN_CMD_CODE(_write_macreg), NULL},
    14		{GEN_CMD_CODE(_Read_BBREG), &rtw_getbbrfreg_cmdrsp_callback},
    15		{GEN_CMD_CODE(_Write_BBREG), NULL},
    16		{GEN_CMD_CODE(_Read_RFREG), &rtw_getbbrfreg_cmdrsp_callback},
    17		{GEN_CMD_CODE(_Write_RFREG), NULL}, /*5*/
    18		{GEN_CMD_CODE(_Read_EEPROM), NULL},
    19		{GEN_CMD_CODE(_Write_EEPROM), NULL},
    20		{GEN_CMD_CODE(_Read_EFUSE), NULL},
    21		{GEN_CMD_CODE(_Write_EFUSE), NULL},
    22	
    23		{GEN_CMD_CODE(_Read_CAM),	NULL},	/*10*/
    24		{GEN_CMD_CODE(_Write_CAM),	 NULL},
    25		{GEN_CMD_CODE(_setBCNITV), NULL},
    26		{GEN_CMD_CODE(_setMBIDCFG), NULL},
    27		{GEN_CMD_CODE(_JoinBss), &rtw_joinbss_cmd_callback},  /*14*/
    28		{GEN_CMD_CODE(_DisConnect), &rtw_disassoc_cmd_callback}, /*15*/
    29		{GEN_CMD_CODE(_CreateBss), &rtw_createbss_cmd_callback},
    30		{GEN_CMD_CODE(_SetOpMode), NULL},
    31		{GEN_CMD_CODE(_SiteSurvey), &rtw_survey_cmd_callback}, /*18*/
    32		{GEN_CMD_CODE(_SetAuth), NULL},
    33	
    34		{GEN_CMD_CODE(_SetKey), NULL},	/*20*/
    35		{GEN_CMD_CODE(_SetStaKey), &rtw_setstaKey_cmdrsp_callback},
    36		{GEN_CMD_CODE(_SetAssocSta), &rtw_setassocsta_cmdrsp_callback},
    37		{GEN_CMD_CODE(_DelAssocSta), NULL},
    38		{GEN_CMD_CODE(_SetStaPwrState), NULL},
    39		{GEN_CMD_CODE(_SetBasicRate), NULL}, /*25*/
    40		{GEN_CMD_CODE(_GetBasicRate), NULL},
    41		{GEN_CMD_CODE(_SetDataRate), NULL},
    42		{GEN_CMD_CODE(_GetDataRate), NULL},
    43		{GEN_CMD_CODE(_SetPhyInfo), NULL},
    44	
    45		{GEN_CMD_CODE(_GetPhyInfo), NULL}, /*30*/
    46		{GEN_CMD_CODE(_SetPhy), NULL},
    47		{GEN_CMD_CODE(_GetPhy), NULL},
    48		{GEN_CMD_CODE(_readRssi), NULL},
    49		{GEN_CMD_CODE(_readGain), NULL},
    50		{GEN_CMD_CODE(_SetAtim), NULL}, /*35*/
    51		{GEN_CMD_CODE(_SetPwrMode), NULL},
    52		{GEN_CMD_CODE(_JoinbssRpt), NULL},
    53		{GEN_CMD_CODE(_SetRaTable), NULL},
    54		{GEN_CMD_CODE(_GetRaTable), NULL},
    55	
    56		{GEN_CMD_CODE(_GetCCXReport), NULL}, /*40*/
    57		{GEN_CMD_CODE(_GetDTMReport),	NULL},
    58		{GEN_CMD_CODE(_GetTXRateStatistics), NULL},
    59		{GEN_CMD_CODE(_SetUsbSuspend), NULL},
    60		{GEN_CMD_CODE(_SetH2cLbk), NULL},
    61		{GEN_CMD_CODE(_AddBAReq), NULL}, /*45*/
    62		{GEN_CMD_CODE(_SetChannel), NULL},		/*46*/
    63		{GEN_CMD_CODE(_SetTxPower), NULL},
    64		{GEN_CMD_CODE(_SwitchAntenna), NULL},
    65		{GEN_CMD_CODE(_SetCrystalCap), NULL},
    66		{GEN_CMD_CODE(_SetSingleCarrierTx), NULL},	/*50*/
    67	
    68		{GEN_CMD_CODE(_SetSingleToneTx), NULL}, /*51*/
    69		{GEN_CMD_CODE(_SetCarrierSuppressionTx), NULL},
    70		{GEN_CMD_CODE(_SetContinuousTx), NULL},
    71		{GEN_CMD_CODE(_SwitchBandwidth), NULL},		/*54*/
    72		{GEN_CMD_CODE(_TX_Beacon), NULL},/*55*/
    73	
    74		{GEN_CMD_CODE(_Set_MLME_EVT), NULL},/*56*/
    75		{GEN_CMD_CODE(_Set_Drv_Extra), NULL},/*57*/
    76		{GEN_CMD_CODE(_Set_H2C_MSG), NULL},/*58*/
    77		{GEN_CMD_CODE(_SetChannelPlan), NULL},/*59*/
    78	
    79		{GEN_CMD_CODE(_SetChannelSwitch), NULL},/*60*/
    80		{GEN_CMD_CODE(_TDLS), NULL},/*61*/
    81		{GEN_CMD_CODE(_ChkBMCSleepq), NULL}, /*62*/
    82	
    83		{GEN_CMD_CODE(_RunInThreadCMD), NULL},/*63*/
    84	};
    85	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
Re: [PATCH] drivers/staging/rtl8723bs: Fix camelCase to snake_case style in core files
Posted by Greg KH 7 months ago 
On Wed, May 21, 2025 at 12:01:50AM +0000, Donny-Dev wrote:
> Signed-off-by: Donny-Dev <donnyturizo13@gmail.com>
> ---
>  drivers/staging/rtl8723bs/core/rtw_cmd.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/rtl8723bs/core/rtw_cmd.c b/drivers/staging/rtl8723bs/core/rtw_cmd.c
> index 557bfdf09..81f795a82 100644
> --- a/drivers/staging/rtl8723bs/core/rtw_cmd.c
> +++ b/drivers/staging/rtl8723bs/core/rtw_cmd.c
> @@ -9,8 +9,8 @@
>  #include <linux/jiffies.h>
>  
>  static struct _cmd_callback rtw_cmd_callback[] = {
> -	{GEN_CMD_CODE(_Read_MACREG), NULL}, /*0*/
> -	{GEN_CMD_CODE(_Write_MACREG), NULL},
> +	{GEN_CMD_CODE(_read_macreg), NULL}, /*0*/
> +	{GEN_CMD_CODE(_write_macreg), NULL},
>  	{GEN_CMD_CODE(_Read_BBREG), &rtw_getbbrfreg_cmdrsp_callback},
>  	{GEN_CMD_CODE(_Write_BBREG), NULL},
>  	{GEN_CMD_CODE(_Read_RFREG), &rtw_getbbrfreg_cmdrsp_callback},
> -- 
> 2.43.0
> 
> 

Hi,

This is the friendly patch-bot of Greg Kroah-Hartman.  You have sent him
a patch that has triggered this response.  He used to manually respond
to these common problems, but in order to save his sanity (he kept
writing the same thing over and over, yet to different people), I was
created.  Hopefully you will not take offence and will fix the problem
in your patch and resubmit it so that it can be accepted into the Linux
kernel tree.

You are receiving this message because of the following common error(s)
as indicated below:

- You did not specify a description of why the patch is needed, or
  possibly, any description at all, in the email body.  Please read the
  section entitled "The canonical patch format" in the kernel file,
  Documentation/process/submitting-patches.rst for what is needed in
  order to properly describe the change.

- You did not write a descriptive Subject: for the patch, allowing Greg,
  and everyone else, to know what this patch is all about.  Please read
  the section entitled "The canonical patch format" in the kernel file,
  Documentation/process/submitting-patches.rst for what a proper
  Subject: line should look like.

- It looks like you did not use your "real" name for the patch on either
  the Signed-off-by: line, or the From: line (both of which have to
  match).  Please read the kernel file,
  Documentation/process/submitting-patches.rst for how to do this
  correctly.

If you wish to discuss this problem further, or you have questions about
how to resolve this issue, please feel free to respond to this email and
Greg will reply once he has dug out from the pending patches received
from other developers.

thanks,

greg k-h's patch email bot

Patchew 2.1-devel-b67e4c2

© 2016 - 2025 Red Hat, Inc.