Hi André,
Thank you for the patch.
On Wed, May 21, 2025 at 09:34:28PM +0200, André Apitzsch via B4 Relay wrote:
> From: André Apitzsch <git@apitzsch.eu>
>
> Instead rely on the rate set on the clock (using assigned-clock-rates
> etc.)
>
> Signed-off-by: André Apitzsch <git@apitzsch.eu>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> ---
> drivers/media/i2c/imx214.c | 6 ------
> 1 file changed, 6 deletions(-)
>
> diff --git a/drivers/media/i2c/imx214.c b/drivers/media/i2c/imx214.c
> index 19b494c08ece9894de67a4ee34c6f8e6e2708e41..264e897ec6e8e3d2fcd9d58db82090c7dd85d526 100644
> --- a/drivers/media/i2c/imx214.c
> +++ b/drivers/media/i2c/imx214.c
> @@ -32,7 +32,6 @@
>
> #define IMX214_REG_FAST_STANDBY_CTRL CCI_REG8(0x0106)
>
> -#define IMX214_DEFAULT_CLK_FREQ 24000000
> #define IMX214_DEFAULT_LINK_FREQ 600000000
> /* Keep wrong link frequency for backward compatibility */
> #define IMX214_DEFAULT_LINK_FREQ_LEGACY 480000000
> @@ -1402,11 +1401,6 @@ static int imx214_probe(struct i2c_client *client)
> return dev_err_probe(dev, PTR_ERR(imx214->xclk),
> "failed to get xclk\n");
>
> - ret = clk_set_rate(imx214->xclk, IMX214_DEFAULT_CLK_FREQ);
> - if (ret)
> - return dev_err_probe(dev, ret,
> - "failed to set xclk frequency\n");
> -
> ret = imx214_get_regulators(dev, imx214);
> if (ret < 0)
> return dev_err_probe(dev, ret, "failed to get regulators\n");
--
Regards,
Laurent Pinchart