Add compatible strings "nxp,imx95-jpgdec" and "nxp,imx95-jpgenc", which
are backward compatible with "nxp,imx8qxp-jpgdec" and
"nxp,imx8qxp-jpegenc". i.MX95 just need one power domain which combine
wrap and all slots together. Reduce minItems of power-domains to 1 for
i.MX95 and keep the same restriction for others.
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Signed-off-by: Frank Li <Frank.Li@nxp.com>
---
.../bindings/media/nxp,imx8-jpeg.yaml | 28 +++++++++++++++++--
1 file changed, 25 insertions(+), 3 deletions(-)
diff --git a/Documentation/devicetree/bindings/media/nxp,imx8-jpeg.yaml b/Documentation/devicetree/bindings/media/nxp,imx8-jpeg.yaml
index 2be30c5fdc839..4cba42ba7cf72 100644
--- a/Documentation/devicetree/bindings/media/nxp,imx8-jpeg.yaml
+++ b/Documentation/devicetree/bindings/media/nxp,imx8-jpeg.yaml
@@ -22,10 +22,14 @@ properties:
- nxp,imx8qxp-jpgdec
- nxp,imx8qxp-jpgenc
- items:
- - const: nxp,imx8qm-jpgdec
+ - enum:
+ - nxp,imx8qm-jpgdec
+ - nxp,imx95-jpgdec
- const: nxp,imx8qxp-jpgdec
- items:
- - const: nxp,imx8qm-jpgenc
+ - enum:
+ - nxp,imx8qm-jpgenc
+ - nxp,imx95-jpgenc
- const: nxp,imx8qxp-jpgenc
reg:
@@ -48,7 +52,7 @@ properties:
description:
List of phandle and PM domain specifier as documented in
Documentation/devicetree/bindings/power/power_domain.txt
- minItems: 2 # Wrapper and 1 slot
+ minItems: 1 # Wrapper and all slots
maxItems: 5 # Wrapper and 4 slots
required:
@@ -58,6 +62,24 @@ required:
- interrupts
- power-domains
+allOf:
+ - if:
+ properties:
+ compatible:
+ contains:
+ enum:
+ - nxp,imx95-jpgenc
+ - nxp,imx95-jpgdec
+ then:
+ properties:
+ power-domains:
+ maxItems: 1
+ else:
+ properties:
+ power-domains:
+ minItems: 2 # Wrapper and 1 slot
+
+
additionalProperties: false
examples:
--
2.34.1Hi, Le mercredi 21 mai 2025 à 13:34 -0400, Frank Li a écrit : > Add compatible strings "nxp,imx95-jpgdec" and "nxp,imx95-jpgenc", which > are backward compatible with "nxp,imx8qxp-jpgdec" and > "nxp,imx8qxp-jpegenc". i.MX95 just need one power domain which combine > wrap and all slots together. Reduce minItems of power-domains to 1 for > i.MX95 and keep the same restriction for others. > > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > Signed-off-by: Frank Li <Frank.Li@nxp.com> Acked-by: Nicolas Dufresne <nicolas.dufresne@collabora.com> Krzysztof, will you take this one once the DTS part is ready ? regards, Nicolas > --- > .../bindings/media/nxp,imx8-jpeg.yaml | 28 +++++++++++++++++-- > 1 file changed, 25 insertions(+), 3 deletions(-) > > diff --git a/Documentation/devicetree/bindings/media/nxp,imx8-jpeg.yaml > b/Documentation/devicetree/bindings/media/nxp,imx8-jpeg.yaml > index 2be30c5fdc839..4cba42ba7cf72 100644 > --- a/Documentation/devicetree/bindings/media/nxp,imx8-jpeg.yaml > +++ b/Documentation/devicetree/bindings/media/nxp,imx8-jpeg.yaml > @@ -22,10 +22,14 @@ properties: > - nxp,imx8qxp-jpgdec > - nxp,imx8qxp-jpgenc > - items: > - - const: nxp,imx8qm-jpgdec > + - enum: > + - nxp,imx8qm-jpgdec > + - nxp,imx95-jpgdec > - const: nxp,imx8qxp-jpgdec > - items: > - - const: nxp,imx8qm-jpgenc > + - enum: > + - nxp,imx8qm-jpgenc > + - nxp,imx95-jpgenc > - const: nxp,imx8qxp-jpgenc > > reg: > @@ -48,7 +52,7 @@ properties: > description: > List of phandle and PM domain specifier as documented in > Documentation/devicetree/bindings/power/power_domain.txt > - minItems: 2 # Wrapper and 1 slot > + minItems: 1 # Wrapper and all slots > maxItems: 5 # Wrapper and 4 slots > > required: > @@ -58,6 +62,24 @@ required: > - interrupts > - power-domains > > +allOf: > + - if: > + properties: > + compatible: > + contains: > + enum: > + - nxp,imx95-jpgenc > + - nxp,imx95-jpgdec > + then: > + properties: > + power-domains: > + maxItems: 1 > + else: > + properties: > + power-domains: > + minItems: 2 # Wrapper and 1 slot > + > + > additionalProperties: false > > examples:
On Fri, May 23, 2025 at 07:22:04PM -0400, Nicolas Dufresne wrote: > Hi, > > Le mercredi 21 mai 2025 à 13:34 -0400, Frank Li a écrit : > > Add compatible strings "nxp,imx95-jpgdec" and "nxp,imx95-jpgenc", which > > are backward compatible with "nxp,imx8qxp-jpgdec" and > > "nxp,imx8qxp-jpegenc". i.MX95 just need one power domain which combine > > wrap and all slots together. Reduce minItems of power-domains to 1 for > > i.MX95 and keep the same restriction for others. > > > > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > > Signed-off-by: Frank Li <Frank.Li@nxp.com> > > Acked-by: Nicolas Dufresne <nicolas.dufresne@collabora.com> > > Krzysztof, will you take this one once the DTS part is ready ? dt-bindings is the prerequisite of DTS. DTS patch looks good to me and I'm waiting for dt-bindings part to be applied first. Shawn
Le jeudi 19 juin 2025 à 12:27 +0800, Shawn Guo a écrit : > On Fri, May 23, 2025 at 07:22:04PM -0400, Nicolas Dufresne wrote: > > Hi, > > > > Le mercredi 21 mai 2025 à 13:34 -0400, Frank Li a écrit : > > > Add compatible strings "nxp,imx95-jpgdec" and "nxp,imx95-jpgenc", which > > > are backward compatible with "nxp,imx8qxp-jpgdec" and > > > "nxp,imx8qxp-jpegenc". i.MX95 just need one power domain which combine > > > wrap and all slots together. Reduce minItems of power-domains to 1 for > > > i.MX95 and keep the same restriction for others. > > > > > > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > > > Signed-off-by: Frank Li <Frank.Li@nxp.com> > > > > Acked-by: Nicolas Dufresne <nicolas.dufresne@collabora.com> > > > > Krzysztof, will you take this one once the DTS part is ready ? > > dt-bindings is the prerequisite of DTS. DTS patch looks good to me > and I'm waiting for dt-bindings part to be applied first. I was waiting for sign of life on the DTS part, we usually get some ack, which is good sign we can take the bindings. Nicolas
On 19/06/2025 19:16, Nicolas Dufresne wrote: > Le jeudi 19 juin 2025 à 12:27 +0800, Shawn Guo a écrit : >> On Fri, May 23, 2025 at 07:22:04PM -0400, Nicolas Dufresne wrote: >>> Hi, >>> >>> Le mercredi 21 mai 2025 à 13:34 -0400, Frank Li a écrit : >>>> Add compatible strings "nxp,imx95-jpgdec" and "nxp,imx95-jpgenc", which >>>> are backward compatible with "nxp,imx8qxp-jpgdec" and >>>> "nxp,imx8qxp-jpegenc". i.MX95 just need one power domain which combine >>>> wrap and all slots together. Reduce minItems of power-domains to 1 for >>>> i.MX95 and keep the same restriction for others. >>>> >>>> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> >>>> Signed-off-by: Frank Li <Frank.Li@nxp.com> >>> >>> Acked-by: Nicolas Dufresne <nicolas.dufresne@collabora.com> >>> >>> Krzysztof, will you take this one once the DTS part is ready ? >> >> dt-bindings is the prerequisite of DTS. DTS patch looks good to me >> and I'm waiting for dt-bindings part to be applied first. > > I was waiting for sign of life on the DTS part, we usually get some ack, > which is good sign we can take the bindings. Such process never happens. DT bindings are the prerequisite here and platform maintainers wait for bindings to be accepted before taking DTS or even sometimes reviewing DTS. Why even bother to review DTS if it follows entirely incorrect binding? Best regards, Krzysztof
Le vendredi 20 juin 2025 à 07:54 +0200, Krzysztof Kozlowski a écrit : > On 19/06/2025 19:16, Nicolas Dufresne wrote: > > Le jeudi 19 juin 2025 à 12:27 +0800, Shawn Guo a écrit : > > > On Fri, May 23, 2025 at 07:22:04PM -0400, Nicolas Dufresne wrote: > > > > Hi, > > > > > > > > Le mercredi 21 mai 2025 à 13:34 -0400, Frank Li a écrit : > > > > > Add compatible strings "nxp,imx95-jpgdec" and "nxp,imx95-jpgenc", which > > > > > are backward compatible with "nxp,imx8qxp-jpgdec" and > > > > > "nxp,imx8qxp-jpegenc". i.MX95 just need one power domain which combine > > > > > wrap and all slots together. Reduce minItems of power-domains to 1 for > > > > > i.MX95 and keep the same restriction for others. > > > > > > > > > > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > > > > > Signed-off-by: Frank Li <Frank.Li@nxp.com> > > > > > > > > Acked-by: Nicolas Dufresne <nicolas.dufresne@collabora.com> > > > > > > > > Krzysztof, will you take this one once the DTS part is ready ? > > > > > > dt-bindings is the prerequisite of DTS. DTS patch looks good to me > > > and I'm waiting for dt-bindings part to be applied first. > > > > I was waiting for sign of life on the DTS part, we usually get some ack, > > which is good sign we can take the bindings. > > Such process never happens. DT bindings are the prerequisite here and > platform maintainers wait for bindings to be accepted before taking DTS > or even sometimes reviewing DTS. Why even bother to review DTS if it > follows entirely incorrect binding? You are the one requesting DTS with DT bindings for review purpose. You've done so regularly this year. As for review process, Ack are a workaround to a black whole in our review process. Patches without any reply can either be un-reviewed due to lack of time, or accepted. You do whatever you like, I'm just saying that clarity can help to coordinate. regards, Nicolas > > Best regards, > Krzysztof
On 20/06/2025 17:06, Nicolas Dufresne wrote: > Le vendredi 20 juin 2025 à 07:54 +0200, Krzysztof Kozlowski a écrit : >> On 19/06/2025 19:16, Nicolas Dufresne wrote: >>> Le jeudi 19 juin 2025 à 12:27 +0800, Shawn Guo a écrit : >>>> On Fri, May 23, 2025 at 07:22:04PM -0400, Nicolas Dufresne wrote: >>>>> Hi, >>>>> >>>>> Le mercredi 21 mai 2025 à 13:34 -0400, Frank Li a écrit : >>>>>> Add compatible strings "nxp,imx95-jpgdec" and "nxp,imx95-jpgenc", which >>>>>> are backward compatible with "nxp,imx8qxp-jpgdec" and >>>>>> "nxp,imx8qxp-jpegenc". i.MX95 just need one power domain which combine >>>>>> wrap and all slots together. Reduce minItems of power-domains to 1 for >>>>>> i.MX95 and keep the same restriction for others. >>>>>> >>>>>> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> >>>>>> Signed-off-by: Frank Li <Frank.Li@nxp.com> >>>>> >>>>> Acked-by: Nicolas Dufresne <nicolas.dufresne@collabora.com> >>>>> >>>>> Krzysztof, will you take this one once the DTS part is ready ? >>>> >>>> dt-bindings is the prerequisite of DTS. DTS patch looks good to me >>>> and I'm waiting for dt-bindings part to be applied first. >>> >>> I was waiting for sign of life on the DTS part, we usually get some ack, >>> which is good sign we can take the bindings. >> >> Such process never happens. DT bindings are the prerequisite here and >> platform maintainers wait for bindings to be accepted before taking DTS >> or even sometimes reviewing DTS. Why even bother to review DTS if it >> follows entirely incorrect binding? > > You are the one requesting DTS with DT bindings for review purpose. You've > done so regularly this year. Yes, I asked for DTS for before/while reviewing very questionable bindings and drivers. Was this reviewed already? Yes, it was. Therefore after my review, how is this relevant? Best regards, Krzysztof
On 24/05/2025 01:22, Nicolas Dufresne wrote: > Hi, > > Le mercredi 21 mai 2025 à 13:34 -0400, Frank Li a écrit : >> Add compatible strings "nxp,imx95-jpgdec" and "nxp,imx95-jpgenc", which >> are backward compatible with "nxp,imx8qxp-jpgdec" and >> "nxp,imx8qxp-jpegenc". i.MX95 just need one power domain which combine >> wrap and all slots together. Reduce minItems of power-domains to 1 for >> i.MX95 and keep the same restriction for others. >> >> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> >> Signed-off-by: Frank Li <Frank.Li@nxp.com> > > Acked-by: Nicolas Dufresne <nicolas.dufresne@collabora.com> > > Krzysztof, will you take this one once the DTS part is ready ? > No, that's a media patch, not a Samsung or any other subsystem I maintain. I do not have write access to media tree. Best regards, Krzysztof
© 2016 - 2025 Red Hat, Inc.