drm/panel-simple: fix the warnings for the Evervision VGG644804

[PATCH] drm/panel-simple: fix the warnings for the Evervision VGG644804

Posted by Michael Walle 8 months, 3 weeks ago

The panel lacked the connector type which causes a warning. Adding the
connector type reveals wrong bus_flags and bits per pixel. Fix all of
it.

Fixes: 1319f2178bdf ("drm/panel-simple: add Evervision VGG644804 panel entry")
Signed-off-by: Michael Walle <mwalle@kernel.org>
---
 drivers/gpu/drm/panel/panel-simple.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c
index 82ee2f12b8d2..0a3b26bb4d73 100644
--- a/drivers/gpu/drm/panel/panel-simple.c
+++ b/drivers/gpu/drm/panel/panel-simple.c
@@ -2198,13 +2198,14 @@ static const struct display_timing evervision_vgg644804_timing = {
 static const struct panel_desc evervision_vgg644804 = {
 	.timings = &evervision_vgg644804_timing,
 	.num_timings = 1,
-	.bpc = 8,
+	.bpc = 6,
 	.size = {
 		.width = 115,
 		.height = 86,
 	},
 	.bus_format = MEDIA_BUS_FMT_RGB666_1X7X3_SPWG,
-	.bus_flags = DRM_BUS_FLAG_DE_HIGH | DRM_BUS_FLAG_PIXDATA_SAMPLE_NEGEDGE,
+	.bus_flags = DRM_BUS_FLAG_DE_HIGH,
+	.connector_type = DRM_MODE_CONNECTOR_LVDS,
 };
 
 static const struct display_timing evervision_vgg804821_timing = {
-- 
2.39.5

Re: [PATCH] drm/panel-simple: fix the warnings for the Evervision VGG644804

Posted by Neil Armstrong 8 months, 1 week ago

Hi,

On Tue, 20 May 2025 09:41:10 +0200, Michael Walle wrote:
> The panel lacked the connector type which causes a warning. Adding the
> connector type reveals wrong bus_flags and bits per pixel. Fix all of
> it.
> 
> 

Thanks, Applied to https://gitlab.freedesktop.org/drm/misc/kernel.git (drm-misc-fixes)

[1/1] drm/panel-simple: fix the warnings for the Evervision VGG644804
      https://gitlab.freedesktop.org/drm/misc/kernel/-/commit/5dc1ea903588a73fb03b3a3e5a041a7c63a4bccd

-- 
Neil

Re: [PATCH] drm/panel-simple: fix the warnings for the Evervision VGG644804

Posted by Neil Armstrong 8 months, 3 weeks ago

On 20/05/2025 09:41, Michael Walle wrote:
> The panel lacked the connector type which causes a warning. Adding the
> connector type reveals wrong bus_flags and bits per pixel. Fix all of
> it.
> 
> Fixes: 1319f2178bdf ("drm/panel-simple: add Evervision VGG644804 panel entry")
> Signed-off-by: Michael Walle <mwalle@kernel.org>
> ---
>   drivers/gpu/drm/panel/panel-simple.c | 5 +++--
>   1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c
> index 82ee2f12b8d2..0a3b26bb4d73 100644
> --- a/drivers/gpu/drm/panel/panel-simple.c
> +++ b/drivers/gpu/drm/panel/panel-simple.c
> @@ -2198,13 +2198,14 @@ static const struct display_timing evervision_vgg644804_timing = {
>   static const struct panel_desc evervision_vgg644804 = {
>   	.timings = &evervision_vgg644804_timing,
>   	.num_timings = 1,
> -	.bpc = 8,
> +	.bpc = 6,
>   	.size = {
>   		.width = 115,
>   		.height = 86,
>   	},
>   	.bus_format = MEDIA_BUS_FMT_RGB666_1X7X3_SPWG,
> -	.bus_flags = DRM_BUS_FLAG_DE_HIGH | DRM_BUS_FLAG_PIXDATA_SAMPLE_NEGEDGE,
> +	.bus_flags = DRM_BUS_FLAG_DE_HIGH,
> +	.connector_type = DRM_MODE_CONNECTOR_LVDS,
>   };
>   
>   static const struct display_timing evervision_vgg804821_timing = {

Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>