This change enables camera driver for QCS615 ADP AIR board.
Signed-off-by: Wenmeng Liu <quic_wenmliu@quicinc.com>
---
arch/arm64/boot/dts/qcom/qcs615-ride.dts | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/qcs615-ride.dts b/arch/arm64/boot/dts/qcom/qcs615-ride.dts
index 2b5aa3c66867676bda59ff82b902b6e4974126f8..be8b829ec508d7de7a4cd6be6d1d4e83b09734bb 100644
--- a/arch/arm64/boot/dts/qcom/qcs615-ride.dts
+++ b/arch/arm64/boot/dts/qcom/qcs615-ride.dts
@@ -211,6 +211,13 @@ vreg_l17a: ldo17 {
};
};
+&camss {
+ vdda-phy-supply = <&vreg_l5a>;
+ vdda-pll-supply = <&vreg_l12a>;
+
+ status = "ok";
+};
+
&gcc {
clocks = <&rpmhcc RPMH_CXO_CLK>,
<&rpmhcc RPMH_CXO_CLK_A>,
--
2.34.1On 20/05/2025 09:56, Wenmeng Liu wrote:
> This change enables camera driver for QCS615 ADP AIR board.
>
> Signed-off-by: Wenmeng Liu <quic_wenmliu@quicinc.com>
> ---
> arch/arm64/boot/dts/qcom/qcs615-ride.dts | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/qcs615-ride.dts b/arch/arm64/boot/dts/qcom/qcs615-ride.dts
> index 2b5aa3c66867676bda59ff82b902b6e4974126f8..be8b829ec508d7de7a4cd6be6d1d4e83b09734bb 100644
> --- a/arch/arm64/boot/dts/qcom/qcs615-ride.dts
> +++ b/arch/arm64/boot/dts/qcom/qcs615-ride.dts
> @@ -211,6 +211,13 @@ vreg_l17a: ldo17 {
> };
> };
>
> +&camss {
> + vdda-phy-supply = <&vreg_l5a>;
> + vdda-pll-supply = <&vreg_l12a>;
> +
> + status = "ok";
> +};
> +
> &gcc {
> clocks = <&rpmhcc RPMH_CXO_CLK>,
> <&rpmhcc RPMH_CXO_CLK_A>,
>
I think there's some confusion.
I'm willing to accept CSID and VFE changes with the minimum proof of TPG
driving it.
But - CSIPHY in CAMSS which is only proven by TPG is obviously not a
proof and again I agree with the consensus here - there's little value
to an end-user in just having the TPG for a camera.
No sensor:
CAMSS::CSID
CAMSS::VFE
Just about acceptable
No sensor:
CAMSS::CSIPHY
DTS::CAMSS enable
Is too much of an ask.
Just publish your sensor code ! We need more sensor enablement upstream
anyway.
---
bod
On 2025/5/21 21:07, Bryan O'Donoghue wrote:
> On 20/05/2025 09:56, Wenmeng Liu wrote:
>> This change enables camera driver for QCS615 ADP AIR board.
>>
>> Signed-off-by: Wenmeng Liu <quic_wenmliu@quicinc.com>
>> ---
>> arch/arm64/boot/dts/qcom/qcs615-ride.dts | 7 +++++++
>> 1 file changed, 7 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/qcs615-ride.dts b/arch/arm64/
>> boot/dts/qcom/qcs615-ride.dts
>> index
>> 2b5aa3c66867676bda59ff82b902b6e4974126f8..be8b829ec508d7de7a4cd6be6d1d4e83b09734bb 100644
>> --- a/arch/arm64/boot/dts/qcom/qcs615-ride.dts
>> +++ b/arch/arm64/boot/dts/qcom/qcs615-ride.dts
>> @@ -211,6 +211,13 @@ vreg_l17a: ldo17 {
>> };
>> };
>> +&camss {
>> + vdda-phy-supply = <&vreg_l5a>;
>> + vdda-pll-supply = <&vreg_l12a>;
>> +
>> + status = "ok";
>> +};
>> +
>> &gcc {
>> clocks = <&rpmhcc RPMH_CXO_CLK>,
>> <&rpmhcc RPMH_CXO_CLK_A>,
>>
>
> I think there's some confusion.
>
> I'm willing to accept CSID and VFE changes with the minimum proof of TPG
> driving it.
>
> But - CSIPHY in CAMSS which is only proven by TPG is obviously not a
> proof and again I agree with the consensus here - there's little value
> to an end-user in just having the TPG for a camera.
>
> No sensor:
> CAMSS::CSID
> CAMSS::VFE
>
> Just about acceptable
>
> No sensor:
> CAMSS::CSIPHY
> DTS::CAMSS enable
>
> Is too much of an ask.
>
> Just publish your sensor code ! We need more sensor enablement upstream
> anyway.
>
> ---
> bod
Hi bryan,
I will upload the sensor code together in the next version.
Thanks,
Wenmeng
Hello Wenmeng,
On 5/20/25 11:56, Wenmeng Liu wrote:
> This change enables camera driver for QCS615 ADP AIR board.
what is the rationale of enabling CAMSS on the board without giving any
description of any sensors connected to the SoC?
> Signed-off-by: Wenmeng Liu <quic_wenmliu@quicinc.com>
> ---
> arch/arm64/boot/dts/qcom/qcs615-ride.dts | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/qcs615-ride.dts b/arch/arm64/boot/dts/qcom/qcs615-ride.dts
> index 2b5aa3c66867676bda59ff82b902b6e4974126f8..be8b829ec508d7de7a4cd6be6d1d4e83b09734bb 100644
> --- a/arch/arm64/boot/dts/qcom/qcs615-ride.dts
> +++ b/arch/arm64/boot/dts/qcom/qcs615-ride.dts
> @@ -211,6 +211,13 @@ vreg_l17a: ldo17 {
> };
> };
>
> +&camss {
> + vdda-phy-supply = <&vreg_l5a>;
> + vdda-pll-supply = <&vreg_l12a>;
> +
> + status = "ok";
> +};
> +
--
Best wishes,
Vladimir
On 2025/5/20 20:19, Vladimir Zapolskiy wrote: > Hello Wenmeng, > > On 5/20/25 11:56, Wenmeng Liu wrote: >> This change enables camera driver for QCS615 ADP AIR board. > > what is the rationale of enabling CAMSS on the board without giving any > description of any sensors connected to the SoC? > Hi Vladimir, We can perform validation through the CSID TPG(Test Pattern Generator), so I enabled CAMSS. Thanks, Wenmeng
On Wed, May 21, 2025 at 09:32:00AM +0800, Wenmeng Liu wrote: > > > On 2025/5/20 20:19, Vladimir Zapolskiy wrote: > > Hello Wenmeng, > > > > On 5/20/25 11:56, Wenmeng Liu wrote: > > > This change enables camera driver for QCS615 ADP AIR board. > > > > what is the rationale of enabling CAMSS on the board without giving any > > description of any sensors connected to the SoC? > > > > Hi Vladimir, > > We can perform validation through the CSID TPG(Test Pattern Generator), so I > enabled CAMSS. Are there any _actual_ cameras being a part of the RIDE platform? -- With best wishes Dmitry
Hi Wenmeng.
On 5/21/25 04:32, Wenmeng Liu wrote:
>
>
> On 2025/5/20 20:19, Vladimir Zapolskiy wrote:
>> Hello Wenmeng,
>>
>> On 5/20/25 11:56, Wenmeng Liu wrote:
>>> This change enables camera driver for QCS615 ADP AIR board.
>>
>> what is the rationale of enabling CAMSS on the board without giving any
>> description of any sensors connected to the SoC?
>>
>
> Hi Vladimir,
>
> We can perform validation through the CSID TPG(Test Pattern Generator),
> so I enabled CAMSS.
>
Since this is just a test of CAMSS without any sensors/CSIPHY, then
1. camss-csiphy-3ph-1-0.c changes from the series have never been tested
and added as dead code, it shall be removed from the series,
2. adding voltage regulators to the board dts is void and shall be removed.
Not to substitute but in addition to the above it's still doubtful, if just
a hardware/driver test configuration deserves to be added into the dts.
--
Best wishes,
Vladimir
On 21/05/2025 07:52, Vladimir Zapolskiy wrote: >> We can perform validation through the CSID TPG(Test Pattern Generator), >> so I enabled CAMSS. >> > > Since this is just a test of CAMSS without any sensors/CSIPHY, then > > 1. camss-csiphy-3ph-1-0.c changes from the series have never been tested > and added as dead code, it shall be removed from the series, > 2. adding voltage regulators to the board dts is void and shall be removed. > > Not to substitute but in addition to the above it's still doubtful, if just > a hardware/driver test configuration deserves to be added into the dts. No, it does not deserve to be added. It's useless code in upstream. They just want to push whatever they had downstream and drop their patch count. Best regards, Krzysztof
On Wed, May 21, 2025 at 08:04:10AM +0200, Krzysztof Kozlowski wrote: > On 21/05/2025 07:52, Vladimir Zapolskiy wrote: > >> We can perform validation through the CSID TPG(Test Pattern Generator), > >> so I enabled CAMSS. > >> > > > > Since this is just a test of CAMSS without any sensors/CSIPHY, then > > > > 1. camss-csiphy-3ph-1-0.c changes from the series have never been tested > > and added as dead code, it shall be removed from the series, > > 2. adding voltage regulators to the board dts is void and shall be removed. > > > > Not to substitute but in addition to the above it's still doubtful, if just > > a hardware/driver test configuration deserves to be added into the dts. > No, it does not deserve to be added. It's useless code in upstream. They > just want to push whatever they had downstream and drop their patch count. I doubt that they had camss downstream. -- With best wishes Dmitry
On 20/05/2025 10:56, Wenmeng Liu wrote:
> This change enables camera driver for QCS615 ADP AIR board.
>
> Signed-off-by: Wenmeng Liu <quic_wenmliu@quicinc.com>
> ---
> arch/arm64/boot/dts/qcom/qcs615-ride.dts | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/qcs615-ride.dts b/arch/arm64/boot/dts/qcom/qcs615-ride.dts
> index 2b5aa3c66867676bda59ff82b902b6e4974126f8..be8b829ec508d7de7a4cd6be6d1d4e83b09734bb 100644
> --- a/arch/arm64/boot/dts/qcom/qcs615-ride.dts
> +++ b/arch/arm64/boot/dts/qcom/qcs615-ride.dts
> @@ -211,6 +211,13 @@ vreg_l17a: ldo17 {
> };
> };
>
> +&camss {
> + vdda-phy-supply = <&vreg_l5a>;
> + vdda-pll-supply = <&vreg_l12a>;
> +
> + status = "ok";
Standard qcom comment...
It does not look like you tested the DTS against bindings. Please run
`make dtbs_check W=1` (see
Documentation/devicetree/bindings/writing-schema.rst or
https://www.linaro.org/blog/tips-and-tricks-for-validating-devicetree-sources-with-the-devicetree-schema/
for instructions).
Maybe you need to update your dtschema and yamllint. Don't rely on
distro packages for dtschema and be sure you are using the latest
released dtschema.
Best regards,
Krzysztof
On 2025/5/20 17:44, Krzysztof Kozlowski wrote:
> On 20/05/2025 10:56, Wenmeng Liu wrote:
>> This change enables camera driver for QCS615 ADP AIR board.
>>
>> Signed-off-by: Wenmeng Liu <quic_wenmliu@quicinc.com>
>> ---
>> arch/arm64/boot/dts/qcom/qcs615-ride.dts | 7 +++++++
>> 1 file changed, 7 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/qcs615-ride.dts b/arch/arm64/boot/dts/qcom/qcs615-ride.dts
>> index 2b5aa3c66867676bda59ff82b902b6e4974126f8..be8b829ec508d7de7a4cd6be6d1d4e83b09734bb 100644
>> --- a/arch/arm64/boot/dts/qcom/qcs615-ride.dts
>> +++ b/arch/arm64/boot/dts/qcom/qcs615-ride.dts
>> @@ -211,6 +211,13 @@ vreg_l17a: ldo17 {
>> };
>> };
>>
>> +&camss {
>> + vdda-phy-supply = <&vreg_l5a>;
>> + vdda-pll-supply = <&vreg_l12a>;
>> +
>> + status = "ok";
> Standard qcom comment...
>
> It does not look like you tested the DTS against bindings. Please run
> `make dtbs_check W=1` (see
> Documentation/devicetree/bindings/writing-schema.rst or
> https://www.linaro.org/blog/tips-and-tricks-for-validating-devicetree-sources-with-the-devicetree-schema/
> for instructions).
> Maybe you need to update your dtschema and yamllint. Don't rely on
> distro packages for dtschema and be sure you are using the latest
> released dtschema.
>
> Best regards,
> Krzysztof
Hi Krzysztof
I only used the CAMSS dt-bindings to check the DTS. Will pay more
attention to it next time.
Thanks,
Wenmeng
© 2016 - 2025 Red Hat, Inc.