[PATCH] mtd: nand: sunxi: Add randomizer configuration before randomizer enable

Wentao Liang posted 1 patch 7 months ago
drivers/mtd/nand/raw/sunxi_nand.c | 1 +
1 file changed, 1 insertion(+)
[PATCH] mtd: nand: sunxi: Add randomizer configuration before randomizer enable
Posted by Wentao Liang 7 months ago
In sunxi_nfc_hw_ecc_read_chunk(), the sunxi_nfc_randomizer_enable() is
called without the config of randomizer. A proper implementation can be
found in sunxi_nfc_hw_ecc_read_chunks_dma().

Add sunxi_nfc_randomizer_config() before the start of randomization.

Fixes: 4be4e03efc7f ("mtd: nand: sunxi: add randomizer support")
Cc: stable@vger.kernel.org # v4.6
Signed-off-by: Wentao Liang <vulab@iscas.ac.cn>
---
 drivers/mtd/nand/raw/sunxi_nand.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/mtd/nand/raw/sunxi_nand.c b/drivers/mtd/nand/raw/sunxi_nand.c
index fab371e3e9b7..9179719f639e 100644
--- a/drivers/mtd/nand/raw/sunxi_nand.c
+++ b/drivers/mtd/nand/raw/sunxi_nand.c
@@ -817,6 +817,7 @@ static int sunxi_nfc_hw_ecc_read_chunk(struct nand_chip *nand,
 	if (ret)
 		return ret;
 
+	sunxi_nfc_randomizer_config(nand, page, false);
 	sunxi_nfc_randomizer_enable(nand);
 	writel(NFC_DATA_TRANS | NFC_DATA_SWAP_METHOD | NFC_ECC_OP,
 	       nfc->regs + NFC_REG_CMD);
-- 
2.42.0.windows.2
Re: [PATCH] mtd: nand: sunxi: Add randomizer configuration before randomizer enable
Posted by Miquel Raynal 7 months ago
On Mon, 19 May 2025 23:42:24 +0800, Wentao Liang wrote:
> In sunxi_nfc_hw_ecc_read_chunk(), the sunxi_nfc_randomizer_enable() is
> called without the config of randomizer. A proper implementation can be
> found in sunxi_nfc_hw_ecc_read_chunks_dma().
> 
> Add sunxi_nfc_randomizer_config() before the start of randomization.
> 
> 
> [...]

Applied to nand/next, thanks!

[1/1] mtd: nand: sunxi: Add randomizer configuration before randomizer enable
      commit: 4a5a99bc79cdc4be63933653682b0261a67a0c9f

Patche(s) should be available on mtd/linux.git and will be
part of the next PR (provided that no robot complains by then).

Kind regards,
Miquèl