include/uapi/linux/taskstats.h | 14 ++++++++++---- 1 file changed, 10 insertions(+), 4 deletions(-)
From: Wang Yaxin <wang.yaxin@zte.com.cn>
add explain about xxx_delay_min/max and adjust indentation.
Signed-off-by: Wang Yaxin <wang.yaxin@zte.com.cn>
Signed-off-by: Jiang Kun <jiang.kun2@zte.com.cn>
---
include/uapi/linux/taskstats.h | 14 ++++++++++----
1 file changed, 10 insertions(+), 4 deletions(-)
diff --git a/include/uapi/linux/taskstats.h b/include/uapi/linux/taskstats.h
index d71aa022b2ef..62e2d7f65298 100644
--- a/include/uapi/linux/taskstats.h
+++ b/include/uapi/linux/taskstats.h
@@ -207,6 +207,12 @@ struct taskstats {
/* v15: add Delay max and Delay min */
/* v16: move Delay max and Delay min to the end of taskstat */
+ /*
+ *
+ * xxx_delay_max is the max number of delay values recorded
+ * xxx_delay_min is the min number of delay values recorded
+ *
+ */
__u64 cpu_delay_max;
__u64 cpu_delay_min;
@@ -225,11 +231,11 @@ struct taskstats {
__u64 compact_delay_max;
__u64 compact_delay_min;
- __u64 wpcopy_delay_max;
- __u64 wpcopy_delay_min;
+ __u64 wpcopy_delay_max;
+ __u64 wpcopy_delay_min;
- __u64 irq_delay_max;
- __u64 irq_delay_min;
+ __u64 irq_delay_max;
+ __u64 irq_delay_min;
};
--
2.25.1
> add explain about xxx_delay_min/max and adjust indentation.
>
> Signed-off-by: Wang Yaxin <wang.yaxin@zte.com.cn>
> Signed-off-by: Jiang Kun <jiang.kun2@zte.com.cn>
> ---
> include/uapi/linux/taskstats.h | 14 ++++++++++----
> 1 file changed, 10 insertions(+), 4 deletions(-)
>
> diff --git a/include/uapi/linux/taskstats.h b/include/uapi/linux/taskstats.h
> index d71aa022b2ef..62e2d7f65298 100644
> --- a/include/uapi/linux/taskstats.h
> +++ b/include/uapi/linux/taskstats.h
> @@ -207,6 +207,12 @@ struct taskstats {
> /* v15: add Delay max and Delay min */
>
> /* v16: move Delay max and Delay min to the end of taskstat */
> + /*
> + *
> + * xxx_delay_max is the max number of delay values recorded
> + * xxx_delay_min is the min number of delay values recorded
> + *
> + */
The naming of these variables is sufficiently clear and self-explanatory, so no need to add these comments.
> @@ -225,11 +231,11 @@ struct taskstats {
> __u64 compact_delay_max;
> __u64 compact_delay_min;
>
> - __u64 wpcopy_delay_max;
> - __u64 wpcopy_delay_min;
> + __u64 wpcopy_delay_max;
> + __u64 wpcopy_delay_min;
>
> - __u64 irq_delay_max;
> - __u64 irq_delay_min;
> + __u64 irq_delay_max;
> + __u64 irq_delay_min;
> };
this change is ok.
© 2016 - 2025 Red Hat, Inc.