[PATCH] arm64: dts: rockchip: Drop assigned-clock* from cpu nodes on rk3588

Diederik de Haas posted 1 patch 7 months ago
arch/arm64/boot/dts/rockchip/rk3588-base.dtsi | 6 ------
1 file changed, 6 deletions(-)
[PATCH] arm64: dts: rockchip: Drop assigned-clock* from cpu nodes on rk3588
Posted by Diederik de Haas 7 months ago
The assigned-clocks and assigned-clock-rates properties were moved from
the scmi_clk node onto cpu nodes in commit
87810bda8a84 ("arm64: dts: rockchip: Fix SCMI assigned clocks on rk3588s")

During review of v1 of that patch set, the following comment was made:

  why aren't you using OPP tables to define CPU frequencies.
  Assigned-clocks looks like a temporary hack because you haven't
  done proper OPP tables.

Some time later, proper OPP tables for rk3588 were added in commit
276856db91b4 ("arm64: dts: rockchip: Add OPP data for CPU cores on RK3588")

So this 'temporary hack' is no longer needed.
Dropping it fixes the following dtb validation issues:

  cpu@0: Unevaluated properties are not allowed
    ('assigned-clock-rates', 'assigned-clocks' were unexpected)
  cpu@400: Unevaluated properties are not allowed
    ('assigned-clock-rates', 'assigned-clocks' were unexpected)
  cpu@600: Unevaluated properties are not allowed
    ('assigned-clock-rates', 'assigned-clocks' were unexpected)

Link: https://lore.kernel.org/linux-rockchip/CAL_JsqL_EogoKOQ1xwU75=rJSC4o7yV3Jej4vadtacX2Pt3-hw@mail.gmail.com/
Signed-off-by: Diederik de Haas <didi.debian@cknow.org>
---
 arch/arm64/boot/dts/rockchip/rk3588-base.dtsi | 6 ------
 1 file changed, 6 deletions(-)

diff --git a/arch/arm64/boot/dts/rockchip/rk3588-base.dtsi b/arch/arm64/boot/dts/rockchip/rk3588-base.dtsi
index 548677de9a53..70f03e68ba55 100644
--- a/arch/arm64/boot/dts/rockchip/rk3588-base.dtsi
+++ b/arch/arm64/boot/dts/rockchip/rk3588-base.dtsi
@@ -96,8 +96,6 @@ cpu_l0: cpu@0 {
 			enable-method = "psci";
 			capacity-dmips-mhz = <530>;
 			clocks = <&scmi_clk SCMI_CLK_CPUL>;
-			assigned-clocks = <&scmi_clk SCMI_CLK_CPUL>;
-			assigned-clock-rates = <816000000>;
 			cpu-idle-states = <&CPU_SLEEP>;
 			i-cache-size = <32768>;
 			i-cache-line-size = <64>;
@@ -174,8 +172,6 @@ cpu_b0: cpu@400 {
 			enable-method = "psci";
 			capacity-dmips-mhz = <1024>;
 			clocks = <&scmi_clk SCMI_CLK_CPUB01>;
-			assigned-clocks = <&scmi_clk SCMI_CLK_CPUB01>;
-			assigned-clock-rates = <816000000>;
 			cpu-idle-states = <&CPU_SLEEP>;
 			i-cache-size = <65536>;
 			i-cache-line-size = <64>;
@@ -214,8 +210,6 @@ cpu_b2: cpu@600 {
 			enable-method = "psci";
 			capacity-dmips-mhz = <1024>;
 			clocks = <&scmi_clk SCMI_CLK_CPUB23>;
-			assigned-clocks = <&scmi_clk SCMI_CLK_CPUB23>;
-			assigned-clock-rates = <816000000>;
 			cpu-idle-states = <&CPU_SLEEP>;
 			i-cache-size = <65536>;
 			i-cache-line-size = <64>;
-- 
2.49.0
Re: [PATCH] arm64: dts: rockchip: Drop assigned-clock* from cpu nodes on rk3588
Posted by Heiko Stuebner 7 months ago
On Mon, 19 May 2025 12:18:28 +0200, Diederik de Haas wrote:
> The assigned-clocks and assigned-clock-rates properties were moved from
> the scmi_clk node onto cpu nodes in commit
> 87810bda8a84 ("arm64: dts: rockchip: Fix SCMI assigned clocks on rk3588s")
> 
> During review of v1 of that patch set, the following comment was made:
> 
>   why aren't you using OPP tables to define CPU frequencies.
>   Assigned-clocks looks like a temporary hack because you haven't
>   done proper OPP tables.
> 
> [...]

Applied, thanks!

[1/1] arm64: dts: rockchip: Drop assigned-clock* from cpu nodes on rk3588
      commit: 6e0f32da68fac556327666f8f81dfae7405d1c25

Best regards,
-- 
Heiko Stuebner <heiko@sntech.de>