On 19/05/2025 18:04, Dmitry Baryshkov wrote:
> From: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
>
> Inline the _setup_dsc_ops() function, it makes it easier to handle
> different conditions involving DSC configuration.
>
> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
> ---
> drivers/gpu/drm/msm/disp/dpu1/dpu_hw_dsc.c | 17 ++++++-----------
> 1 file changed, 6 insertions(+), 11 deletions(-)
>
> diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_dsc.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_dsc.c
> index cec6d4e8baec4d00282465cfd2885d365f835976..c7db917afd27e3daf1e8aad2ad671246bf6c8fbf 100644
> --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_dsc.c
> +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_dsc.c
> @@ -181,16 +181,6 @@ static void dpu_hw_dsc_bind_pingpong_blk(
> DPU_REG_WRITE(c, dsc_ctl_offset, mux_cfg);
> }
>
> -static void _setup_dsc_ops(struct dpu_hw_dsc_ops *ops,
> - unsigned long cap)
> -{
> - ops->dsc_disable = dpu_hw_dsc_disable;
> - ops->dsc_config = dpu_hw_dsc_config;
> - ops->dsc_config_thresh = dpu_hw_dsc_config_thresh;
> - if (cap & BIT(DPU_DSC_OUTPUT_CTRL))
> - ops->dsc_bind_pingpong_blk = dpu_hw_dsc_bind_pingpong_blk;
> -};
> -
> /**
> * dpu_hw_dsc_init() - Initializes the DSC hw driver object.
> * @dev: Corresponding device for devres management
> @@ -213,7 +203,12 @@ struct dpu_hw_dsc *dpu_hw_dsc_init(struct drm_device *dev,
>
> c->idx = cfg->id;
> c->caps = cfg;
> - _setup_dsc_ops(&c->ops, c->caps->features);
> +
> + c->ops.dsc_disable = dpu_hw_dsc_disable;
> + c->ops.dsc_config = dpu_hw_dsc_config;
> + c->ops.dsc_config_thresh = dpu_hw_dsc_config_thresh;
> + if (c->caps->features & BIT(DPU_DSC_OUTPUT_CTRL))
> + c->ops.dsc_bind_pingpong_blk = dpu_hw_dsc_bind_pingpong_blk;
>
> return c;
> }
>
Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>