1. Patchew
  2. linux
  3. View series

[PATCH] module: release codetag section when module load fails

David Wang posted 1 patch 7 months ago
There is a newer version of this series
kernel/module/main.c | 1 +
1 file changed, 1 insertion(+)
[PATCH] module: release codetag section when module load fails
Posted by David Wang 7 months ago 
When module load failed after memory for codetag sections ready,
codetag section memory was not properly released. This
causes memory leak, and if next module load happens to got the
same module address, codetag may pick the uninitialized section
when manipulating tags during module unload, and lead to
"unable to handle page fault" BUG.

Closes: https://lore.kernel.org/all/20250516131246.6244-1-00107082@163.com/
Signed-off-by: David Wang <00107082@163.com>
---
 kernel/module/main.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/kernel/module/main.c b/kernel/module/main.c
index a2859dc3eea6..5c6ab20240a6 100644
--- a/kernel/module/main.c
+++ b/kernel/module/main.c
@@ -2829,6 +2829,7 @@ static void module_deallocate(struct module *mod, struct load_info *info)
 {
 	percpu_modfree(mod);
 	module_arch_freeing_init(mod);
+	codetag_free_module_sections(mod);
 
 	free_mod_mem(mod);
 }
-- 
2.39.2
Re: [PATCH] module: release codetag section when module load fails
Posted by Suren Baghdasaryan 7 months ago 
On Sun, May 18, 2025 at 3:12 AM David Wang <00107082@163.com> wrote:
>
> When module load failed after memory for codetag sections ready,

nit: s/ready/is ready

> codetag section memory was not properly released. This
> causes memory leak, and if next module load happens to got the

nit: s/happens to got/happens to get


> same module address, codetag may pick the uninitialized section
> when manipulating tags during module unload, and lead to
> "unable to handle page fault" BUG.
>
> Closes: https://lore.kernel.org/all/20250516131246.6244-1-00107082@163.com/
> Signed-off-by: David Wang <00107082@163.com>

Acked-by: Suren Baghdasaryan <surenb@google.com>

> ---
>  kernel/module/main.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/kernel/module/main.c b/kernel/module/main.c
> index a2859dc3eea6..5c6ab20240a6 100644
> --- a/kernel/module/main.c
> +++ b/kernel/module/main.c
> @@ -2829,6 +2829,7 @@ static void module_deallocate(struct module *mod, struct load_info *info)
>  {
>         percpu_modfree(mod);
>         module_arch_freeing_init(mod);
> +       codetag_free_module_sections(mod);
>
>         free_mod_mem(mod);
>  }
> --
> 2.39.2
>
Re: [PATCH] module: release codetag section when module load fails
Posted by David Wang 7 months ago 
At 2025-05-20 00:03:16, "Suren Baghdasaryan" <surenb@google.com> wrote:
>On Sun, May 18, 2025 at 3:12 AM David Wang <00107082@163.com> wrote:
>>
>> When module load failed after memory for codetag sections ready,
>
>nit: s/ready/is ready
>
>> codetag section memory was not properly released. This
>> causes memory leak, and if next module load happens to got the
>
>nit: s/happens to got/happens to get
>

Thanks, I will send new version.
>
>> same module address, codetag may pick the uninitialized section
>> when manipulating tags during module unload, and lead to
>> "unable to handle page fault" BUG.
>>
>> Closes: https://lore.kernel.org/all/20250516131246.6244-1-00107082@163.com/
>> Signed-off-by: David Wang <00107082@163.com>
>
>Acked-by: Suren Baghdasaryan <surenb@google.com>
>
>> ---
>>  kernel/module/main.c | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/kernel/module/main.c b/kernel/module/main.c
>> index a2859dc3eea6..5c6ab20240a6 100644
>> --- a/kernel/module/main.c
>> +++ b/kernel/module/main.c
>> @@ -2829,6 +2829,7 @@ static void module_deallocate(struct module *mod, struct load_info *info)
>>  {
>>         percpu_modfree(mod);
>>         module_arch_freeing_init(mod);
>> +       codetag_free_module_sections(mod);
>>
>>         free_mod_mem(mod);
>>  }
>> --
>> 2.39.2
>>
[PATCH v2] module: release codetag section when module load fails
Posted by David Wang 7 months ago 
When module load fails after memory for codetag section is ready,
codetag section memory will not be properly released. This
causes memory leak, and if next module load happens to get the
same module address, codetag may pick the uninitialized section
when manipulating tags during module unload, and leads to
"unable to handle page fault" BUG.

Closes: https://lore.kernel.org/all/20250516131246.6244-1-00107082@163.com/
Signed-off-by: David Wang <00107082@163.com>
Acked-by: Suren Baghdasaryan <surenb@google.com>
---
 kernel/module/main.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/kernel/module/main.c b/kernel/module/main.c
index a2859dc3eea6..5c6ab20240a6 100644
--- a/kernel/module/main.c
+++ b/kernel/module/main.c
@@ -2829,6 +2829,7 @@ static void module_deallocate(struct module *mod, struct load_info *info)
 {
 	percpu_modfree(mod);
 	module_arch_freeing_init(mod);
+	codetag_free_module_sections(mod);
 
 	free_mod_mem(mod);
 }
-- 
2.39.2
Re: [PATCH v2] module: release codetag section when module load fails
Posted by Suren Baghdasaryan 7 months ago 
On Mon, May 19, 2025 at 9:38 AM David Wang <00107082@163.com> wrote:
>
> When module load fails after memory for codetag section is ready,
> codetag section memory will not be properly released. This
> causes memory leak, and if next module load happens to get the
> same module address, codetag may pick the uninitialized section
> when manipulating tags during module unload, and leads to
> "unable to handle page fault" BUG.
>
> Closes: https://lore.kernel.org/all/20250516131246.6244-1-00107082@163.com/
> Signed-off-by: David Wang <00107082@163.com>
> Acked-by: Suren Baghdasaryan <surenb@google.com>

Sending to Andrew for adding into the mm tree.

> ---
>  kernel/module/main.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/kernel/module/main.c b/kernel/module/main.c
> index a2859dc3eea6..5c6ab20240a6 100644
> --- a/kernel/module/main.c
> +++ b/kernel/module/main.c
> @@ -2829,6 +2829,7 @@ static void module_deallocate(struct module *mod, struct load_info *info)
>  {
>         percpu_modfree(mod);
>         module_arch_freeing_init(mod);
> +       codetag_free_module_sections(mod);
>
>         free_mod_mem(mod);
>  }
> --
> 2.39.2
>
Re: [PATCH v2] module: release codetag section when module load fails
Posted by Suren Baghdasaryan 7 months ago 
On Mon, May 19, 2025 at 9:46 AM Suren Baghdasaryan <surenb@google.com> wrote:
>
> On Mon, May 19, 2025 at 9:38 AM David Wang <00107082@163.com> wrote:
> >
> > When module load fails after memory for codetag section is ready,
> > codetag section memory will not be properly released. This
> > causes memory leak, and if next module load happens to get the
> > same module address, codetag may pick the uninitialized section
> > when manipulating tags during module unload, and leads to
> > "unable to handle page fault" BUG.
> >

Fixes: 0db6f8d7820a ("alloc_tag: load module tags into separate
contiguous memory")

> > Closes: https://lore.kernel.org/all/20250516131246.6244-1-00107082@163.com/
> > Signed-off-by: David Wang <00107082@163.com>
> > Acked-by: Suren Baghdasaryan <surenb@google.com>
>
> Sending to Andrew for adding into the mm tree.
>
> > ---
> >  kernel/module/main.c | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/kernel/module/main.c b/kernel/module/main.c
> > index a2859dc3eea6..5c6ab20240a6 100644
> > --- a/kernel/module/main.c
> > +++ b/kernel/module/main.c
> > @@ -2829,6 +2829,7 @@ static void module_deallocate(struct module *mod, struct load_info *info)
> >  {
> >         percpu_modfree(mod);
> >         module_arch_freeing_init(mod);
> > +       codetag_free_module_sections(mod);
> >
> >         free_mod_mem(mod);
> >  }
> > --
> > 2.39.2
> >

Patchew 2.1-devel-b67e4c2

© 2016 - 2025 Red Hat, Inc.