PCI/ASPM: Use boolean type for aspm_disabled and aspm_force

[PATCH] PCI/ASPM: Use boolean type for aspm_disabled and aspm_force

Posted by Hans Zhang 7 months ago

The aspm_disabled and aspm_force variables are used as boolean flags.
Change their type from int to bool and update assignments to use
true/false instead of 1/0. This improves code clarity.

Signed-off-by: Hans Zhang <18255117159@163.com>
---
 drivers/pci/pcie/aspm.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/pci/pcie/aspm.c b/drivers/pci/pcie/aspm.c
index 29fcb0689a91..98b3022802b2 100644
--- a/drivers/pci/pcie/aspm.c
+++ b/drivers/pci/pcie/aspm.c
@@ -245,7 +245,7 @@ struct pcie_link_state {
 	u32 clkpm_disable:1;		/* Clock PM disabled */
 };
 
-static int aspm_disabled, aspm_force;
+static bool aspm_disabled, aspm_force;
 static bool aspm_support_enabled = true;
 static DEFINE_MUTEX(aspm_lock);
 static LIST_HEAD(link_list);
@@ -1712,11 +1712,11 @@ static int __init pcie_aspm_disable(char *str)
 {
 	if (!strcmp(str, "off")) {
 		aspm_policy = POLICY_DEFAULT;
-		aspm_disabled = 1;
+		aspm_disabled = true;
 		aspm_support_enabled = false;
 		pr_info("PCIe ASPM is disabled\n");
 	} else if (!strcmp(str, "force")) {
-		aspm_force = 1;
+		aspm_force = true;
 		pr_info("PCIe ASPM is forcibly enabled\n");
 	}
 	return 1;
@@ -1734,7 +1734,7 @@ void pcie_no_aspm(void)
 	 */
 	if (!aspm_force) {
 		aspm_policy = POLICY_DEFAULT;
-		aspm_disabled = 1;
+		aspm_disabled = true;
 	}
 }
 

base-commit: fee3e843b309444f48157e2188efa6818bae85cf
-- 
2.25.1

Re: [PATCH] PCI/ASPM: Use boolean type for aspm_disabled and aspm_force

Posted by Manivannan Sadhasivam 6 months, 1 week ago

On Sat, 17 May 2025 23:49:39 +0800, Hans Zhang wrote:
> The aspm_disabled and aspm_force variables are used as boolean flags.
> Change their type from int to bool and update assignments to use
> true/false instead of 1/0. This improves code clarity.
> 
> 

Applied, thanks!

[1/1] PCI/ASPM: Use boolean type for aspm_disabled and aspm_force
      commit: 7a04f18b95bdefdc8d976ccc8a4c0443b460039a

Best regards,
-- 
Manivannan Sadhasivam <mani@kernel.org>

Re: [PATCH] PCI/ASPM: Use boolean type for aspm_disabled and aspm_force

Posted by Ilpo Järvinen 6 months, 2 weeks ago

On Sat, 17 May 2025, Hans Zhang wrote:

> The aspm_disabled and aspm_force variables are used as boolean flags.
> Change their type from int to bool and update assignments to use
> true/false instead of 1/0. This improves code clarity.
> 
> Signed-off-by: Hans Zhang <18255117159@163.com>
> ---
>  drivers/pci/pcie/aspm.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/pci/pcie/aspm.c b/drivers/pci/pcie/aspm.c
> index 29fcb0689a91..98b3022802b2 100644
> --- a/drivers/pci/pcie/aspm.c
> +++ b/drivers/pci/pcie/aspm.c
> @@ -245,7 +245,7 @@ struct pcie_link_state {
>  	u32 clkpm_disable:1;		/* Clock PM disabled */
>  };
>  
> -static int aspm_disabled, aspm_force;
> +static bool aspm_disabled, aspm_force;
>  static bool aspm_support_enabled = true;
>  static DEFINE_MUTEX(aspm_lock);
>  static LIST_HEAD(link_list);
> @@ -1712,11 +1712,11 @@ static int __init pcie_aspm_disable(char *str)
>  {
>  	if (!strcmp(str, "off")) {
>  		aspm_policy = POLICY_DEFAULT;
> -		aspm_disabled = 1;
> +		aspm_disabled = true;
>  		aspm_support_enabled = false;
>  		pr_info("PCIe ASPM is disabled\n");
>  	} else if (!strcmp(str, "force")) {
> -		aspm_force = 1;
> +		aspm_force = true;
>  		pr_info("PCIe ASPM is forcibly enabled\n");
>  	}
>  	return 1;
> @@ -1734,7 +1734,7 @@ void pcie_no_aspm(void)
>  	 */
>  	if (!aspm_force) {
>  		aspm_policy = POLICY_DEFAULT;
> -		aspm_disabled = 1;
> +		aspm_disabled = true;
>  	}
>  }

Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>

-- 
 i.