[PATCH v2 00/15] btrfs: convert to use rb_find() and rb_find_add() helper

Pan Chuang posted 15 patches 7 months, 1 week ago
fs/btrfs/backref.c       |   6 +-
fs/btrfs/backref.h       |  12 ++-
fs/btrfs/defrag.c        |  51 ++++++------
fs/btrfs/delayed-inode.c |  39 +++++----
fs/btrfs/misc.h          |  35 ++++----
fs/btrfs/qgroup.c        | 167 ++++++++++++++++++++-------------------
fs/btrfs/ref-verify.c    | 147 ++++++++++++++++------------------
fs/btrfs/relocation.c    |  30 ++++---
fs/btrfs/ulist.c         |  60 +++++++-------
9 files changed, 269 insertions(+), 278 deletions(-)
[PATCH v2 00/15] btrfs: convert to use rb_find() and rb_find_add() helper
Posted by Pan Chuang 7 months, 1 week ago
Based on patch v1, perform code style conversions such as function naming
and commit message adjustments without changing the logic. Additionally,
add patch 14 and patch 15.

Pan Chuang (2):
  btrfs: pass struct rb_simple_node pointer directly in
    rb_simple_insert()
  btrfs: use rb_find_add() in rb_simple_insert()

Yangtao Li (13):
  btrfs: use rb_find_add() in btrfs_insert_inode_defrag()
  btrfs: use rb_find() in __btrfs_lookup_delayed_item()
  btrfs: use rb_find() in ulist_rbtree_search()
  btrfs: use rb_find_add() in ulist_rbtree_insert()
  btrfs: use rb_find() in lookup_block_entry()
  btrfs: use rb_find_add() in insert_block_entry()
  btrfs: use rb_find() in lookup_root_entry()
  btrfs: use rb_find_add() in insert_root_entry()
  btrfs: use rb_find_add() in insert_ref_entry()
  btrfs: use rb_find() in find_qgroup_rb()
  btrfs: use rb_find_add() in add_qgroup_rb()
  btrfs: use rb_find() in btrfs_qgroup_trace_subtree_after_cow()
  btrfs: use rb_find_add() in btrfs_qgroup_add_swapped_blocks()

 fs/btrfs/backref.c       |   6 +-
 fs/btrfs/backref.h       |  12 ++-
 fs/btrfs/defrag.c        |  51 ++++++------
 fs/btrfs/delayed-inode.c |  39 +++++----
 fs/btrfs/misc.h          |  35 ++++----
 fs/btrfs/qgroup.c        | 167 ++++++++++++++++++++-------------------
 fs/btrfs/ref-verify.c    | 147 ++++++++++++++++------------------
 fs/btrfs/relocation.c    |  30 ++++---
 fs/btrfs/ulist.c         |  60 +++++++-------
 9 files changed, 269 insertions(+), 278 deletions(-)

-- 
2.39.0
Re: [PATCH v2 00/15] btrfs: convert to use rb_find() and rb_find_add() helper
Posted by David Sterba 6 months, 3 weeks ago
On Fri, May 16, 2025 at 11:03:18AM +0800, Pan Chuang wrote:
> Based on patch v1, perform code style conversions such as function naming
> and commit message adjustments without changing the logic. Additionally,
> add patch 14 and patch 15.
> 
> Pan Chuang (2):
>   btrfs: pass struct rb_simple_node pointer directly in
>     rb_simple_insert()
>   btrfs: use rb_find_add() in rb_simple_insert()
> 
> Yangtao Li (13):
>   btrfs: use rb_find_add() in btrfs_insert_inode_defrag()
>   btrfs: use rb_find() in __btrfs_lookup_delayed_item()
>   btrfs: use rb_find() in ulist_rbtree_search()
>   btrfs: use rb_find_add() in ulist_rbtree_insert()
>   btrfs: use rb_find() in lookup_block_entry()
>   btrfs: use rb_find_add() in insert_block_entry()
>   btrfs: use rb_find() in lookup_root_entry()
>   btrfs: use rb_find_add() in insert_root_entry()
>   btrfs: use rb_find_add() in insert_ref_entry()
>   btrfs: use rb_find() in find_qgroup_rb()
>   btrfs: use rb_find_add() in add_qgroup_rb()
>   btrfs: use rb_find() in btrfs_qgroup_trace_subtree_after_cow()
>   btrfs: use rb_find_add() in btrfs_qgroup_add_swapped_blocks()

Thanks for the v2, the cleanups look good, I'll add them to for-next,
with a few coding style fixups.