extcon: max14526: depends on I2C to prevent build warning/errors

[PATCH] extcon: max14526: depends on I2C to prevent build warning/errors

Posted by Randy Dunlap 7 months, 1 week ago

Make EXTCON_MAX14526 depend on I2C to address a kconfig warning and
subsequent build errors:

WARNING: unmet direct dependencies detected for REGMAP_I2C
  Depends on [m]: I2C [=m]
  Selected by [y]:
  - EXTCON_MAX14526 [=y] && EXTCON [=y]

ld: vmlinux.o: in function `max14526_driver_init':
extcon-max14526.c:(.init.text+0x77b0e): undefined reference to `i2c_register_driver'
ld: vmlinux.o: in function `max14526_driver_exit':
extcon-max14526.c:(.exit.text+0x467c): undefined reference to `i2c_del_driver'

Fixes: c2aeb8647e53 ("extcon: Add basic support for Maxim MAX14526 MUIC")
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Cc: Svyatoslav Ryhel <clamor95@gmail.com>
Cc: Chanwoo Choi <cw00.choi@samsung.com>
Cc: MyungJoo Ham <myungjoo.ham@samsung.com>
---
 drivers/extcon/Kconfig |    1 +
 1 file changed, 1 insertion(+)

--- linux-next-20250515.orig/drivers/extcon/Kconfig
+++ linux-next-20250515/drivers/extcon/Kconfig
@@ -136,6 +136,7 @@ config EXTCON_MAX8997
 
 config EXTCON_MAX14526
 	tristate "Maxim MAX14526 EXTCON Support"
+	depends on I2C
 	select IRQ_DOMAIN
 	select REGMAP_I2C
 	help

Re: [PATCH] extcon: max14526: depends on I2C to prevent build warning/errors

Posted by Chanwoo Choi 5 months, 1 week ago

Hi,

Applied it. Thanks.

On Fri, May 16, 2025 at 9:26 AM Randy Dunlap <rdunlap@infradead.org> wrote:
>
> Make EXTCON_MAX14526 depend on I2C to address a kconfig warning and
> subsequent build errors:
>
> WARNING: unmet direct dependencies detected for REGMAP_I2C
>   Depends on [m]: I2C [=m]
>   Selected by [y]:
>   - EXTCON_MAX14526 [=y] && EXTCON [=y]
>
> ld: vmlinux.o: in function `max14526_driver_init':
> extcon-max14526.c:(.init.text+0x77b0e): undefined reference to `i2c_register_driver'
> ld: vmlinux.o: in function `max14526_driver_exit':
> extcon-max14526.c:(.exit.text+0x467c): undefined reference to `i2c_del_driver'
>
> Fixes: c2aeb8647e53 ("extcon: Add basic support for Maxim MAX14526 MUIC")
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Cc: Svyatoslav Ryhel <clamor95@gmail.com>
> Cc: Chanwoo Choi <cw00.choi@samsung.com>
> Cc: MyungJoo Ham <myungjoo.ham@samsung.com>
> ---
>  drivers/extcon/Kconfig |    1 +
>  1 file changed, 1 insertion(+)
>
> --- linux-next-20250515.orig/drivers/extcon/Kconfig
> +++ linux-next-20250515/drivers/extcon/Kconfig
> @@ -136,6 +136,7 @@ config EXTCON_MAX8997
>
>  config EXTCON_MAX14526
>         tristate "Maxim MAX14526 EXTCON Support"
> +       depends on I2C
>         select IRQ_DOMAIN
>         select REGMAP_I2C
>         help
>


-- 
Best Regards,
Chanwoo Choi
Samsung Electronics