[PATCH v12 00/25] x86/resctrl: Move the resctrl filesystem code to /fs/resctrl

James Morse posted 25 patches 7 months ago
Documentation/arch/x86/index.rst              |    1 -
Documentation/filesystems/index.rst           |    1 +
.../{arch/x86 => filesystems}/resctrl.rst     |    6 +-
MAINTAINERS                                   |    5 +-
arch/Kconfig                                  |    8 +
arch/x86/Kconfig                              |   11 +-
arch/x86/include/asm/resctrl.h                |   19 +-
arch/x86/kernel/cpu/resctrl/Makefile          |    2 +
arch/x86/kernel/cpu/resctrl/core.c            |   31 +-
arch/x86/kernel/cpu/resctrl/ctrlmondata.c     |  635 ---
arch/x86/kernel/cpu/resctrl/internal.h        |  399 +-
arch/x86/kernel/cpu/resctrl/monitor.c         |  918 +---
arch/x86/kernel/cpu/resctrl/pseudo_lock.c     | 1092 +----
.../resctrl/{trace.h => pseudo_lock_trace.h}  |   26 +-
arch/x86/kernel/cpu/resctrl/rdtgroup.c        | 4164 +---------------
arch/x86/kernel/process_32.c                  |    2 +-
arch/x86/kernel/process_64.c                  |    2 +-
fs/Kconfig                                    |    1 +
fs/Makefile                                   |    1 +
fs/resctrl/Kconfig                            |   39 +
fs/resctrl/Makefile                           |    6 +
fs/resctrl/ctrlmondata.c                      |  661 +++
fs/resctrl/internal.h                         |  426 ++
fs/resctrl/monitor.c                          |  929 ++++
fs/resctrl/monitor_trace.h                    |   33 +
fs/resctrl/pseudo_lock.c                      | 1105 +++++
fs/resctrl/rdtgroup.c                         | 4353 +++++++++++++++++
include/linux/cpumask.h                       |   75 +-
include/linux/find.h                          |   25 +
include/linux/resctrl.h                       |   36 +-
include/linux/resctrl_types.h                 |   16 +-
lib/find_bit.c                                |   11 +
32 files changed, 7772 insertions(+), 7267 deletions(-)
rename Documentation/{arch/x86 => filesystems}/resctrl.rst (99%)
rename arch/x86/kernel/cpu/resctrl/{trace.h => pseudo_lock_trace.h} (56%)
create mode 100644 fs/resctrl/Kconfig
create mode 100644 fs/resctrl/Makefile
create mode 100644 fs/resctrl/ctrlmondata.c
create mode 100644 fs/resctrl/internal.h
create mode 100644 fs/resctrl/monitor.c
create mode 100644 fs/resctrl/monitor_trace.h
create mode 100644 fs/resctrl/pseudo_lock.c
create mode 100644 fs/resctrl/rdtgroup.c
[PATCH v12 00/25] x86/resctrl: Move the resctrl filesystem code to /fs/resctrl
Posted by James Morse 7 months ago
Hello!

No code changes since v11 - this is the 'final' form of the series
with patches v11:24-29 squashed together. See [v11] for the breakdown.

The first four patches are a series from Yury which I've rebased onto.

This series is based on rc5, and can be retrieved from:
git://git.kernel.org/pub/scm/linux/kernel/git/morse/linux.git mpam/move_to_fs/v12

With the exception of invalid configurations for the configurable-events, there
should be no changes in behaviour caused by this series. It is now possible for
throttle_mode to report 'undefined', but no known platform will do this.
resctrl_exit() is now something that can be called, but x86 doesn't do this.

The driving pattern is to make things like struct rdtgroup private to resctrl.
Features like pseudo-lock aren't going to work on arm64, the ability to disable
it at compile time is added.

After this, I can start posting the MPAM driver to make use of resctrl on arm64.
(What's MPAM? See the cover letter of the first series. [1])

Bugs are still welcome!
Thanks,

James

[v11] https://lore.kernel.org/all/20250513171547.15194-1-james.morse@arm.com
[v10] https://lore.kernel.org/all/20250508171858.9197-1-james.morse@arm.com
[v9] https://lore.kernel.org/all/20250425173809.5529-1-james.morse@arm.com
[v8] https://lore.kernel.org/all/20250411164229.23413-1-james.morse@arm.com
[v7] https://lore.kernel.org/all/20250228195913.24895-1-james.morse@arm.com/
[v6] https://lore.kernel.org/lkml/20250207181823.6378-1-james.morse@arm.com/
[v5] https://lore.kernel.org/r/20241004180347.19985-1-james.morse@arm.com
[v4] https://lore.kernel.org/all/20240802172853.22529-1-james.morse@arm.com/
[v3] https://lore.kernel.org/r/20240614150033.10454-1-james.morse@arm.com
[v2] https://lore.kernel.org/r/20240426150537.8094-1-Dave.Martin@arm.com
[v1] https://lore.kernel.org/r/20240321165106.31602-1-james.morse@arm.com
[1] https://lore.kernel.org/lkml/20201030161120.227225-1-james.morse@arm.com/

Amit Singh Tomar (1):
  x86/resctrl: Remove the limit on the number of CLOSID

Dave Martin (3):
  x86/resctrl: Squelch whitespace anomalies in resctrl core code
  x86/resctrl: Prefer alloc(sizeof(*foo)) idiom in rdt_init_fs_context()
  x86/resctrl: Relax some asm #includes

James Morse (17):
  x86/resctrl: Rename resctrl_sched_in() to begin with "resctrl_arch_"
  x86/resctrl: Check all domains are offline in resctrl_exit()
  x86/resctrl: resctrl_exit() teardown resctrl but leave the mount point
  x86/resctrl: Drop __init/__exit on assorted symbols
  x86/resctrl: Move is_mba_sc() out of core.c
  x86/resctrl: Add end-marker to the resctrl_event_id enum
  x86/resctrl: Expand the width of domid by replacing mon_data_bits
  x86/resctrl: Split trace.h
  x86/resctrl: Add 'resctrl' to the title of the resctrl documentation
  fs/resctrl: Add boiler plate for external resctrl code
  x86/resctrl: Move the filesystem bits to headers visible to fs/resctrl
  x86/resctrl: Move enum resctrl_event_id to resctrl.h
  x86/resctrl: Fix types in resctrl_arch_mon_ctx_{alloc,free}() stubs
  x86/resctrl: Move pseudo lock prototypes to include/linux/resctrl.h
  x86/resctrl: Always initialise rid field in rdt_resources_all[]
  x86,fs/resctrl: Move the resctrl filesystem code to live in
    /fs/resctrl
  MAINTAINERS: Add reviewers for fs/resctrl

Yury Norov [NVIDIA] (4):
  cpumask: relax cpumask_any_but()
  find: add find_first_andnot_bit()
  cpumask: add cpumask_{first,next}_andnot() API
  x86/resctrl: Optimize cpumask_any_housekeeping()

 Documentation/arch/x86/index.rst              |    1 -
 Documentation/filesystems/index.rst           |    1 +
 .../{arch/x86 => filesystems}/resctrl.rst     |    6 +-
 MAINTAINERS                                   |    5 +-
 arch/Kconfig                                  |    8 +
 arch/x86/Kconfig                              |   11 +-
 arch/x86/include/asm/resctrl.h                |   19 +-
 arch/x86/kernel/cpu/resctrl/Makefile          |    2 +
 arch/x86/kernel/cpu/resctrl/core.c            |   31 +-
 arch/x86/kernel/cpu/resctrl/ctrlmondata.c     |  635 ---
 arch/x86/kernel/cpu/resctrl/internal.h        |  399 +-
 arch/x86/kernel/cpu/resctrl/monitor.c         |  918 +---
 arch/x86/kernel/cpu/resctrl/pseudo_lock.c     | 1092 +----
 .../resctrl/{trace.h => pseudo_lock_trace.h}  |   26 +-
 arch/x86/kernel/cpu/resctrl/rdtgroup.c        | 4164 +---------------
 arch/x86/kernel/process_32.c                  |    2 +-
 arch/x86/kernel/process_64.c                  |    2 +-
 fs/Kconfig                                    |    1 +
 fs/Makefile                                   |    1 +
 fs/resctrl/Kconfig                            |   39 +
 fs/resctrl/Makefile                           |    6 +
 fs/resctrl/ctrlmondata.c                      |  661 +++
 fs/resctrl/internal.h                         |  426 ++
 fs/resctrl/monitor.c                          |  929 ++++
 fs/resctrl/monitor_trace.h                    |   33 +
 fs/resctrl/pseudo_lock.c                      | 1105 +++++
 fs/resctrl/rdtgroup.c                         | 4353 +++++++++++++++++
 include/linux/cpumask.h                       |   75 +-
 include/linux/find.h                          |   25 +
 include/linux/resctrl.h                       |   36 +-
 include/linux/resctrl_types.h                 |   16 +-
 lib/find_bit.c                                |   11 +
 32 files changed, 7772 insertions(+), 7267 deletions(-)
 rename Documentation/{arch/x86 => filesystems}/resctrl.rst (99%)
 rename arch/x86/kernel/cpu/resctrl/{trace.h => pseudo_lock_trace.h} (56%)
 create mode 100644 fs/resctrl/Kconfig
 create mode 100644 fs/resctrl/Makefile
 create mode 100644 fs/resctrl/ctrlmondata.c
 create mode 100644 fs/resctrl/internal.h
 create mode 100644 fs/resctrl/monitor.c
 create mode 100644 fs/resctrl/monitor_trace.h
 create mode 100644 fs/resctrl/pseudo_lock.c
 create mode 100644 fs/resctrl/rdtgroup.c

-- 
2.39.5
Re: [PATCH v12 00/25] x86/resctrl: Move the resctrl filesystem code to /fs/resctrl
Posted by Reinette Chatre 7 months ago
Hi Boris and x86 Maintainers,

On 5/15/25 9:58 AM, James Morse wrote:
> Hello!
> 
> No code changes since v11 - this is the 'final' form of the series
> with patches v11:24-29 squashed together. See [v11] for the breakdown.
> 
> The first four patches are a series from Yury which I've rebased onto.
> 
> This series is based on rc5, and can be retrieved from:
> git://git.kernel.org/pub/scm/linux/kernel/git/morse/linux.git mpam/move_to_fs/v12

(mpam/move_to_fs/v12 -> mpam/move_to_fs/v12_final)

> 
> With the exception of invalid configurations for the configurable-events, there
> should be no changes in behaviour caused by this series. It is now possible for
> throttle_mode to report 'undefined', but no known platform will do this.
> resctrl_exit() is now something that can be called, but x86 doesn't do this.
> 
> The driving pattern is to make things like struct rdtgroup private to resctrl.
> Features like pseudo-lock aren't going to work on arm64, the ability to disable
> it at compile time is added.
> 
> After this, I can start posting the MPAM driver to make use of resctrl on arm64.
> (What's MPAM? See the cover letter of the first series. [1])
> 
> Bugs are still welcome!
> Thanks,
> 
> James
> 

Could you please consider this work for inclusion?

Thank you very much.

Reinette
Re: [PATCH v12 00/25] x86/resctrl: Move the resctrl filesystem code to /fs/resctrl
Posted by Borislav Petkov 7 months ago
On Thu, May 15, 2025 at 04:58:30PM +0000, James Morse wrote:
> Hello!
> 
> No code changes since v11 - this is the 'final' form of the series
> with patches v11:24-29 squashed together. See [v11] for the breakdown.

Thx, lemme see if I can queue them...

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette
Re: [PATCH v12 00/25] x86/resctrl: Move the resctrl filesystem code to /fs/resctrl
Posted by Fenghua Yu 7 months ago
On 5/15/25 10:50, Borislav Petkov wrote:
> On Thu, May 15, 2025 at 04:58:30PM +0000, James Morse wrote:
>> Hello!
>>
>> No code changes since v11 - this is the 'final' form of the series
>> with patches v11:24-29 squashed together. See [v11] for the breakdown.
> Thx, lemme see if I can queue them...
>
I build and test this series. Everything looks good to me.

Thanks.

-Fenghua
Re: [PATCH v12 00/25] x86/resctrl: Move the resctrl filesystem code to /fs/resctrl
Posted by Borislav Petkov 7 months ago
On Thu, May 15, 2025 at 11:00:04AM -0700, Fenghua Yu wrote:
> 
> On 5/15/25 10:50, Borislav Petkov wrote:
> > On Thu, May 15, 2025 at 04:58:30PM +0000, James Morse wrote:
> > > Hello!
> > > 
> > > No code changes since v11 - this is the 'final' form of the series
> > > with patches v11:24-29 squashed together. See [v11] for the breakdown.
> > Thx, lemme see if I can queue them...
> > 
> I build and test this series. Everything looks good to me.

Is that you giving a 

Tested-by: you

tag?

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette
Re: [PATCH v12 00/25] x86/resctrl: Move the resctrl filesystem code to /fs/resctrl
Posted by Fenghua Yu 7 months ago
Hi, Boris,

On 5/15/25 11:06, Borislav Petkov wrote:
> On Thu, May 15, 2025 at 11:00:04AM -0700, Fenghua Yu wrote:
>> On 5/15/25 10:50, Borislav Petkov wrote:
>>> On Thu, May 15, 2025 at 04:58:30PM +0000, James Morse wrote:
>>>> Hello!
>>>>
>>>> No code changes since v11 - this is the 'final' form of the series
>>>> with patches v11:24-29 squashed together. See [v11] for the breakdown.
>>> Thx, lemme see if I can queue them...
>>>
>> I build and test this series. Everything looks good to me.
> Is that you giving a
>
> Tested-by: you
>
> tag?

Yes.

Tested-by: Fenghua Yu <fenghuay@nvidia.com>

Thanks.

-Fenghua