[PATCH v2 2/3] net: bcmgenet: count hw discarded packets in missed stat

Zak Kemble posted 3 patches 7 months, 1 week ago
There is a newer version of this series
[PATCH v2 2/3] net: bcmgenet: count hw discarded packets in missed stat
Posted by Zak Kemble 7 months, 1 week ago
Hardware discarded packets are now counted in their own missed stat
instead of being lumped in with general errors.

Signed-off-by: Zak Kemble <zakkemble@gmail.com>
---
 drivers/net/ethernet/broadcom/genet/bcmgenet.c | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/drivers/net/ethernet/broadcom/genet/bcmgenet.c b/drivers/net/ethernet/broadcom/genet/bcmgenet.c
index 64133a98a..d0c6b5d4c 100644
--- a/drivers/net/ethernet/broadcom/genet/bcmgenet.c
+++ b/drivers/net/ethernet/broadcom/genet/bcmgenet.c
@@ -2297,7 +2297,7 @@ static unsigned int bcmgenet_desc_rx(struct bcmgenet_rx_ring *ring,
 		   DMA_P_INDEX_DISCARD_CNT_MASK;
 	if (discards > ring->old_discards) {
 		discards = discards - ring->old_discards;
-		BCMGENET_STATS64_ADD(stats, errors, discards);
+		BCMGENET_STATS64_ADD(stats, missed, discards);
 		ring->old_discards += discards;
 
 		/* Clear HW register when we reach 75% of maximum 0xFFFF */
@@ -3571,7 +3571,7 @@ static void bcmgenet_get_stats64(struct net_device *dev,
 	u64 tx_errors = 0, tx_dropped = 0;
 	u64 rx_bytes = 0, rx_packets = 0;
 	u64 rx_errors = 0, rx_dropped = 0;
-	u64 rx_length_errors = 0;
+	u64 rx_missed = 0, rx_length_errors = 0;
 	u64 rx_over_errors = 0, rx_crc_errors = 0;
 	u64 rx_frame_errors = 0, rx_fragmented_errors = 0;
 	u64 multicast = 0;
@@ -3605,6 +3605,7 @@ static void bcmgenet_get_stats64(struct net_device *dev,
 			rx_packets = u64_stats_read(&rx_stats->packets);
 			rx_errors = u64_stats_read(&rx_stats->errors);
 			rx_dropped = u64_stats_read(&rx_stats->dropped);
+			rx_missed = u64_stats_read(&rx_stats->missed);
 			rx_length_errors = u64_stats_read(&rx_stats->length_errors);
 			rx_over_errors = u64_stats_read(&rx_stats->over_errors);
 			rx_crc_errors = u64_stats_read(&rx_stats->crc_errors);
@@ -3622,7 +3623,7 @@ static void bcmgenet_get_stats64(struct net_device *dev,
 		stats->rx_packets += rx_packets;
 		stats->rx_errors += rx_errors;
 		stats->rx_dropped += rx_dropped;
-		stats->rx_missed_errors += rx_errors;
+		stats->rx_missed_errors += rx_missed;
 		stats->rx_length_errors += rx_length_errors;
 		stats->rx_over_errors += rx_over_errors;
 		stats->rx_crc_errors += rx_crc_errors;
-- 
2.39.5